on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test
tools/jpackage/linux/LinuxResourceTest.java.
It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
But after 8314121, tools/jpackage/linux/LinuxResourceTest.java still reappears.
On Wed, 20 Sep 2023 03:32:55 GMT, yaqsun wrote:
> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test
> tools/jpackage/linux/LinuxResourceTest.java.
> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
> But after 8314121,
> On Oct 6, 2023, at 6:31 PM, Alexander Matveev wrote:
>
> CSR [JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631).
> We will not do any validations of certificates in this case like we do with
> --mac-signing-key-user-name or we will not check if produced application
> image or
> Add a new factory method so that a CatalogResolver can be created with a
> resolve property on top of the Catalog object.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
add a test for the NPE case
-
Changes:
- all:
On Fri, 6 Oct 2023 22:48:40 GMT, Joe Wang wrote:
>> Add a new factory method so that a CatalogResolver can be created with a
>> resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 6 Oct 2023 20:54:34 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> addressing review comments, plus use URL for relative URI
>
> test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogTest.java line
- Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` CLI
options to jpackage to provide signing identity directly to `codesign` and
`productbuild` tools as per CSR
[JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631).
- If `codesign` or `productbuild` fails, then
On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote:
>> Please review this PR which cleans up the static test utility class
>> _HexDumpReader_.
>>
>> This cleans up the code by replacing the nested _ByteArrayBuilder_ class
>> with _HexFormat_, and simplifies the File processing by using a
Hi Vamsi
May be too late but there is one question. We have 2 new methods
private static void sort(Class elemType, A array, ...
private static int[] partition(Class elemType, A array, ...
and 4 methods which are passed to them:
mixedInsertionSort, insertionSort, partitionDualPivot,
On Fri, 6 Oct 2023 18:45:59 GMT, Srinivas Vamsi Parasa wrote:
>> My tier1-7 testing passed. Good.
>
>> My tier1-7 testing passed. Good.
>
> Thank you, Vladimir!
Hi @vamsi-parasa,
May be too late but there is one question. We have 2 new methods
`private static void sort(Class elemType, A
On Fri, 6 Oct 2023 18:58:56 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/text/testlib/HexDumpReader.java line 65:
>
>> 63: String hexString =
> Please review this PR which cleans up the static test utility class
> _HexDumpReader_.
>
> This cleans up the code by replacing the nested _ByteArrayBuilder_ class with
> _HexFormat_, and simplifies the File processing by using a stream. Changes
> were tested to ensure that the _text_ tests
On Fri, 6 Oct 2023 18:57:36 GMT, Lance Andersen wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflect review comments
>
> test/jdk/java/text/testlib/HexDumpReader.java line 54:
>
>> 52:
>> 53: // Converts a
On Fri, 6 Oct 2023 19:35:57 GMT, Joe Wang wrote:
>> Add a new factory method so that a CatalogResolver can be created with a
>> resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 30 May 2023 18:54:50 GMT, Srinivas Vamsi Parasa
wrote:
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
>
The test uses specific classpath, and jar and is intended to test modules. So I
marked is as flagless,
-
Commit messages:
- 8316452
Changes: https://git.openjdk.org/jdk/pull/16080/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16080=00
Issue:
On Fri, 6 Oct 2023 19:35:57 GMT, Joe Wang wrote:
>> Add a new factory method so that a CatalogResolver can be created with a
>> resolve property on top of the Catalog object.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> Add a new factory method so that a CatalogResolver can be created with a
> resolve property on top of the Catalog object.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
addressing review comments, plus use URL for relative URI
I marked tests
sun/tools/jcmd/TestProcessHelper.java
sun/tools/jinfo/JInfoTest.java
as headless. They used different specific VM options and are not worth
executing with other VM flags.
And fixed
sun/tools/jstat/JStatInterval.java
Tested with tier1, local execution of tests, and running
On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu wrote:
> Please review this PR which cleans up the static test utility class
> _HexDumpReader_.
>
> This cleans up the code by replacing the nested _ByteArrayBuilder_ class with
> _HexFormat_, and simplifies the File processing by using a stream.
On Fri, 6 Oct 2023 17:19:29 GMT, Justin Lu wrote:
> Please review this PR which cleans up the static test utility class
> _HexDumpReader_.
>
> This cleans up the code by replacing the nested _ByteArrayBuilder_ class with
> _HexFormat_, and simplifies the File processing by using a stream.
Please review this PR which refactors a number of tests under
`test/text/NumberFormat` to use JUnit.
During the switch to JUnit, the tests had the following updates (to improve
readability)
- separate the test data generation from the actual execution of the test
- create distinct test methods
On Fri, 6 Oct 2023 18:28:21 GMT, Vladimir Kozlov wrote:
> My tier1-7 testing passed. Good.
Thank you, Vladimir!
-
PR Comment: https://git.openjdk.org/jdk/pull/14227#issuecomment-1751254526
> Please review this PR which refactors the ChoiceFormat tests to use JUnit.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
review: comment typo
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16065/files
- new:
On Fri, 6 Oct 2023 17:50:56 GMT, Justin Lu wrote:
>> Please review this PR which refactors the ChoiceFormat tests to use JUnit.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review: separate into two tests
Good point
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317630)
> which makes the implications of overriding _ChoiceFormat::applyPattern_ and
> _MessageFormat::applyPattern_ apparent by adding a implSpec tag to the
> method.
>
> That is, the constructors of both ChoiceFormat
> Please review this PR which refactors the ChoiceFormat tests to use JUnit.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Review: separate into two tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16065/files
On Fri, 6 Oct 2023 16:54:03 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review: separate into two tests
>
> test/jdk/java/text/Format/ChoiceFormat/Bug8001209.java line 78:
>
>> 76:
Please review this PR which cleans up the static test utility class
_HexDumpReader_.
This cleans up the code by replacing the nested _ByteArrayBuilder_ class with
_HexFormat_, and simplifies the File processing by using a stream. Changes were
tested to ensure that the _text_ tests are still
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317630)
which makes the implications of overriding _ChoiceFormat::applyPattern_ and
_MessageFormat::applyPattern_ apparent by adding a implSpec tag to the method.
That is, the constructors of both ChoiceFormat and
On Fri, 6 Oct 2023 14:20:13 GMT, Claes Redestad wrote:
> FWIW I'll not review or sponsor any PRs that use `ByteArrayLittleEndian` for
> trivial `byte[]` writes until there's been a thorough analysis of why this
> helps and shown that JITs can't be expected to generate code that is as
>
On Fri, 1 Sep 2023 15:13:46 GMT, Martin Balao wrote:
> In addition to the goals, scope, motivation, specification and requirement
> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would
> like to describe the most relevant decisions taken during the implementation
> of
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the
On Thu, 5 Oct 2023 20:57:07 GMT, Justin Lu wrote:
> Please review this PR which refactors the ChoiceFormat tests to use JUnit.
test/jdk/java/text/Format/ChoiceFormat/Bug8001209.java line 78:
> 76: "Mutating array returned from getter changed internals of
> ChoiceFormat");
>
On Thu, 5 Oct 2023 09:28:22 GMT, Raffaello Giulietti
wrote:
> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the
> details.
This pull request has now been integrated.
Changeset: b62e774e
Author:Raffaello Giulietti
URL:
> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the
> details.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Using compareUnsigned() rather than open logic.
-
Changes:
- all:
On Fri, 6 Oct 2023 08:32:28 GMT, Martin Stypinski wrote:
>> Martin Stypinski has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - changed for consistency
>> - improved some RandomGenerator & unuseed Imports
>
> fixed typo.
@Styp Thanks,
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the
On Mon, 2 Oct 2023 16:07:09 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Fri, 29 Sep 2023 20:03:09 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and
On Wed, 27 Sep 2023 13:35:55 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> reduce the size of HexFormat##DIGITS, from 256 to 128
>
> It is conventional to get re-reviews of any change and give the
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one
On Thu, 5 Oct 2023 14:00:12 GMT, Aggelos Biboudis
wrote:
>> Refactoring attempt No. 1 complete. I need to recheck the completeness of
>> `checkUnconditionallyExact`. In a following commit.
>
> `checkUnconditionallyExact` and dominance for constants were adjusted
> accordingly in
>
On Wed, 4 Oct 2023 10:08:31 GMT, Aggelos Biboudis
wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 3001:
>>
>>> 2999: }
>>> 3000:
>>> 3001: static class TypePairs {
>>
>> I believe this could be a record between two TypeSymbols? Then you could
>>
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one
On Fri, 6 Oct 2023 10:28:31 GMT, 温绍锦 wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid localized integers in radix-out-of-range exception messages.
>
> The reason parseUnsignedInt(CharSequence s, int
On Thu, 5 Oct 2023 10:31:31 GMT, Raffaello Giulietti
wrote:
>> See the [JBS issue](https://bugs.openjdk.org/browse/JDK-8317515) for the
>> details.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Avoid localized
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked
On Fri, 6 Oct 2023 10:12:53 GMT, Quan Anh Mai wrote:
>> @merykitty For a `String` input that would mean copying the suffix, which
>> could be quite long, or make use of the method that accepts a
>> `CharSequence`, which has different (although more complete) exception
>> messages. Perhaps in
On Fri, 6 Oct 2023 09:53:46 GMT, Raffaello Giulietti
wrote:
>> Could we parse the signed int by parsing the unsigned suffix then prepend
>> the sign? It will unify the code path of `parseInt` and `parseUnsignedInt`.
>>
>> Thanks.
>
> @merykitty For a `String` input that would mean copying
On Fri, 6 Oct 2023 03:16:50 GMT, Quan Anh Mai wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid localized integers in radix-out-of-range exception messages.
>
> Could we parse the signed int by parsing
On Fri, 6 Oct 2023 03:06:08 GMT, Quan Anh Mai wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid localized integers in radix-out-of-range exception messages.
>
>
On Mon, 21 Aug 2023 03:55:42 GMT, Martin Stypinski wrote:
>> Added a bunch of different implementations for Vector API Matrix
>> Multiplications:
>>
>> - Baseline
>> - Blocked (Cache Local)
>> - FMA
>> - Vector API Simple Implementation
>> - Vector API Blocked Implementation
>>
>> Commit was
54 matches
Mail list logo
