Should we allow use Unsafe or ByteArrayLittleEndian for trivial byte[] writes in core-libs?

2023-10-07 Thread 温绍锦(高铁)
Should we allow use Unsafe or ByteArrayLittleEndian for trivial byte[] writes in core-libs? There is already code that uses ByteArrayLittleEndian to improve performance, such as: ```java package java.util; class UUID { public String toString() { // ... ByteArrayLittleEndian.setInt( buf, 9, He

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-07 Thread Danny Thomas
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: Metal renderer threading issues [macOS]

2023-10-07 Thread Alan Bateman
On 07/10/2023 13:59, Alan Snyder wrote: I’ve been investigating a problem with a long running application that accumulates an apparently unbounded number of CVDisplayLink threads. I do not yet have an explanation or a test case. The code that creates and releases CVDisplayLinks looks fine, but

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-07 Thread iaroslavski
On Fri, 6 Oct 2023 18:45:59 GMT, Srinivas Vamsi Parasa wrote: >> My tier1-7 testing passed. Good. > >> My tier1-7 testing passed. Good. > > Thank you, Vladimir! @vamsi-parasa Please disrard my request to change high -> end. I find out a way to update Java code only. I updated my previous comme

Re: RFR: 8317471: ListFormat::parseObject() spec can be improved on parsePosition valid values

2023-10-07 Thread Hamlin Li
On Thu, 5 Oct 2023 17:57:00 GMT, Naoto Sato wrote: > Adding IOOBE clause to clarify the behavior on an invalid `parsePos` argument > on calling `ListFormat::parseObject()`. A corresponding CSR has also been > drafted. Marked as reviewed by mli (Reviewer). - PR Review: https://git

Re: RFR: JDK-8317633: Modernize text.testlib.HexDumpReader [v2]

2023-10-07 Thread Hamlin Li
On Fri, 6 Oct 2023 21:07:51 GMT, Justin Lu wrote: >> Please review this PR which cleans up the static test utility class >> _HexDumpReader_. >> >> This cleans up the code by replacing the nested _ByteArrayBuilder_ class >> with _HexFormat_, and simplifies the File processing by using a stream.

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v48]

2023-10-07 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-07 Thread iaroslavski
On Fri, 6 Oct 2023 18:45:59 GMT, Srinivas Vamsi Parasa wrote: >> My tier1-7 testing passed. Good. > >> My tier1-7 testing passed. Good. > > Thank you, Vladimir! Hi @vamsi-parasa, If DualPivotQuicksort.java is updated, can you improve `partitionDualPivot` and `partitionSinglePivot` methods a l

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v47]

2023-10-07 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Re: Integrated: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays)

2023-10-07 Thread Florian Weimer
I believe this has introduced a build failure with GCC 12.2 on Debian 12.1: Building target 'jdk' in configuration '/home/fw/build/jdk' In file included from /usr/lib/gcc/x86_64-linux-gnu/12/include/immintrin.h:49, from …/jdk/src/java.base/linux/native/libsimdsort/avx512-common-q

Metal renderer threading issues [macOS]

2023-10-07 Thread Alan Snyder
I’ve been investigating a problem with a long running application that accumulates an apparently unbounded number of CVDisplayLink threads. I do not yet have an explanation or a test case. The code that creates and releases CVDisplayLinks looks fine, but that assumes there are no threading issue

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-07 Thread Lukas Bergdoll
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>