JImageValidator has been recently converted to use ClassFile API and original
weak validation of class files was replaced with full class verification.
Unfortunately full class verification is too strong as it includes class
assignability verification according to class hierarchy resolution.
This
On Wed, 11 Oct 2023 05:44:42 GMT, Chen Liang wrote:
> Maybe we can consider moving verify to Class-File object for a new RFE?
Yes, that would be appropriate.
-
PR Comment: https://git.openjdk.org/jdk/pull/16123#issuecomment-1756874646
On Tue, 10 Oct 2023 15:09:41 GMT, Adam Sotona wrote:
> JImageValidator has been recently converted to use ClassFile API and original
> weak validation of class files was replaced with full class verification.
> Unfortunately full class verification is too strong as it includes class
> assignabi
> Hello,
>
> I have fixed the typo in the comment for the constructor
> IdentityHashMap(Map m)
>
> before: Constructs a new identity hash map containing the keys-value mappings
> in the specified map.
> after: Constructs a new identity hash map containing the key-value mappings
> in the specif
Hello,
I have fixed the typo in the comment for the constructor IdentityHashMap(Map m)
before: Constructs a new identity hash map containing the keys-value mappings
in the specified map.
after: Constructs a new identity hash map containing the key-value mappings in
the specified map.
Please re
On Wed, 11 Oct 2023 04:05:48 GMT, ANUPAM DEV wrote:
> Hello,
>
> I have fixed the typo in the comment for the constructor
> IdentityHashMap(Map m)
>
> before: Constructs a new identity hash map containing the keys-value mappings
> in the specified map.
> after: Constructs a new identity hash
On Wed, 11 Oct 2023 04:05:48 GMT, ANUPAM DEV wrote:
> Hello,
>
> I have fixed the typo in the comment for the constructor
> IdentityHashMap(Map m)
>
> before: Constructs a new identity hash map containing the keys-value mappings
> in the specified map.
> after: Constructs a new identity hash
Hello,
I have fixed the typo in the comment for the constructor IdentityHashMap(Map m)
before: Constructs a new identity hash map containing the keys-value mappings
in the specified map.
after: Constructs a new identity hash map containing the key-value mappings in
the specified map.
Please r
> Wording changes to make clear that the scenarios described are merely
> examples and are not normative requirements.
Stuart Marks has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebas
Change test to use `RandomFactory` instead of `new Random()` and convert it to
JUnit 5.
-
Commit messages:
- 8313621: Convert test to JUnit 5
- 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal
should use RandomFactory
Changes: https://git.openjdk.org/jdk/pu
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Tue, 10 Oct 2023 20:21:56 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal of this PR is to address the follow-up comments to the SIMD
>> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
>> Arrays.sort() methods.
>> The proposed changes are:
>>
>> 1) Restriction of the AVX
On Tue, 10 Oct 2023 20:14:51 GMT, iaroslavski wrote:
> Is ok that partitionDualPivot, partitionSinglePivot and mixedInsertionSort,
> insertionSort are annotated differently?
Good question. Someone familiar with this Java code should answer.
Note, **@forceinline** annotation is used by C2 JIT
On Mon, 9 Oct 2023 23:21:57 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Tue, 10 Oct 2023 09:36:47 GMT, Joachim Kern wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
>> in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system
>> lead to double pids in the child list; at least intermitt
On Tue, 10 Oct 2023 20:04:48 GMT, Srinivas Vamsi Parasa
wrote:
>> In #14227, you inadvertently added an extra space at line 230 in
>> make/modules/java.base/Lib.gmk
>> (https://github.com/openjdk/jdk/pull/14227/files#diff-c2e113e4b2661697750fd5e6dcc0908fa98563ccfb3801c8b0e3a70174041b81).
>>
>>
> The goal of this PR is to address the follow-up comments to the SIMD
> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
> Arrays.sort() methods.
> The proposed changes are:
>
> 1) Restriction of the AVX512 sort acceleration to only Intel CPUs. A
> performance regression (d
On Tue, 10 Oct 2023 19:48:50 GMT, Magnus Ihse Bursie wrote:
> In #14227, you inadvertently added an extra space at line 230 in
> make/modules/java.base/Lib.gmk
Hi Magnus (@magicus), please see the extra space fixed in the latest commit.
Thanks,
Vamsi
-
PR Comment: https://git.op
On Tue, 10 Oct 2023 19:03:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal of this PR is to address the follow-up comments to the SIMD
>> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
>> Arrays.sort() methods.
>> The proposed changes are:
>>
>> 1) Restriction of the AVX
> The goal of this PR is to address the follow-up comments to the SIMD
> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
> Arrays.sort() methods.
> The proposed changes are:
>
> 1) Restriction of the AVX512 sort acceleration to only Intel CPUs. A
> performance regression (d
On Tue, 10 Oct 2023 18:01:59 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> pragma workround for GCC12 bug
>
> What is change for "Addressing the build failure due to a bug in GCC 12"
On Tue, 10 Oct 2023 17:55:43 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> pragma workround for GCC12 bug
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4176:
>
>> 4174:
>>
On Tue, 10 Oct 2023 16:44:03 GMT, Srinivas Vamsi Parasa
wrote:
> The goal of this PR is to address the follow-up comments to the SIMD
> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
> Arrays.sort() methods.
> The proposed changes are:
>
> 1) Restriction of the AVX512 so
On Tue, 10 Oct 2023 18:01:59 GMT, Vladimir Kozlov wrote:
> What is change for "Addressing the build failure due to a bug in GCC 12"?
Hello Vladimir,
The change for addressing the build failure will be pushed shortly.
Thanks,
Vamsi
-
PR Comment: https://git.openjdk.org/jdk/pull/1
On Tue, 10 Oct 2023 16:44:03 GMT, Srinivas Vamsi Parasa
wrote:
> The goal of this PR is to address the follow-up comments to the SIMD
> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
> Arrays.sort() methods.
> The proposed changes are:
>
> 1) Restriction of the AVX512 so
On Tue, 10 Oct 2023 16:44:03 GMT, Srinivas Vamsi Parasa
wrote:
> The goal of this PR is to address the follow-up comments to the SIMD
> accelerated sort PR (#14227) which implemented AVX512 intrinsics for
> Arrays.sort() methods.
> The proposed changes are:
>
> 1) Restriction of the AVX512 so
On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote:
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
> URLEnc
The goal of this PR is to restrict the availability of AVX512 accelerated
Arrays.sort() methods to only Intel CPUs as a performance regression (due to
hardware issues) was reported for AMD Zen4 CPUs in the comments section of
#14227.
-
Commit messages:
- 8317763:Restrict AVX512 in
On Tue, 10 Oct 2023 14:27:13 GMT, Claes Redestad wrote:
>> Alternative to #16082
>>
>> Name (unchanged) Cnt Base Error Test
>> Error Unit Change
>> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ±
>> 0,007 ms/op 1,09x (p = 0,000*)
>
On Tue, 10 Oct 2023 11:29:40 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
> URLEncodeDecode.testEncodeLatin1 75 15 0,934 ± 0,017
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
> URLEncodeDecode.testEncodeLatin1 75 15 0,934 ± 0,017
On Tue, 10 Oct 2023 13:47:07 GMT, Roger Riggs wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add test cases, make set sizing more explicit
>
> test/jdk/java/util/BitSet/ImmutableBitSet.java line 65:
>
>> 63:
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request increme
On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote:
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
> URLEnc
On Tue, 10 Oct 2023 12:46:22 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 10 Oct 2023 12:46:22 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
incorporate review comments
-
Changes:
- al
On Mon, 9 Oct 2023 03:29:38 GMT, Chen Liang wrote:
>> Alternative to #16082
>>
>> Name (unchanged) Cnt Base Error Test
>> Error Unit Change
>> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ±
>> 0,007 ms/op 1,09x (p = 0,000*)
>> URL
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR goe
Alternative to #16082
Name (unchanged) Cnt Base Error Test Error
Unit Change
URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
ms/op 1,09x (p = 0,000*)
URLEncodeDecode.testEncodeLatin1 75 15 0,934 ± 0,017 0,811 ± 0,014
On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote:
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
> URLEnc
On Sun, 8 Oct 2023 21:02:25 GMT, Claes Redestad wrote:
> Alternative to #16082
>
> Name (unchanged) Cnt Base Error Test Error
> Unit Change
> URLEncodeDecode.testEncodeLatin1 0 15 2,066 ± 0,104 1,899 ± 0,007
> ms/op 1,09x (p = 0,000*)
> URLEnc
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
src/java.base/share/classes/java/util/zip/ZipFile.java line 1418:
> 1416:
> 1417: @SuppressWarnings("
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request with a new targe
> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
> in TreeTest.test5.
> The reason is: Previously the implementation based on the /proc file system
> lead to double pids in the child list; at least intermittent. Using the API
> getprocs64() instead I was able to eli
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
This is really ZipFile.Source.Key hashCode/equals being inconsistent so I think
we should rename the JBS/PR title
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
src/java.base/share/classes/java/util/zip/ZipFile.java line 1444:
> 1442: } else {
> 1443:
On Tue, 10 Oct 2023 08:32:28 GMT, Sean Coffey wrote:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
src/java.base/share/classes/java/util/zip/ZipFile.java line 1424:
> 1422: return file.
Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
objects aren't created for the same zip file.
-
Commit messages:
- Initial changes
Changes: https://git.openjdk.org/jdk/pull/16115/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16115&range=00
I
On Mon, 9 Oct 2023 15:00:18 GMT, Joachim Kern wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
>> in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system
>> lead to double pids in the child list; at least intermitte
52 matches
Mail list logo
