Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v2]

2023-10-17 Thread Shaojin Wen
> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on

Re: RFR: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16

2023-10-17 Thread Iris Clark
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote: > This change updates the IANA subtag registry to the update released on > 2023-10-16. > > Announcement -> > https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html Marked as reviewed by iris (Reviewer).

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase [v2]

2023-10-17 Thread David Holmes
On Mon, 16 Oct 2023 15:04:51 GMT, Matthias Baesken wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> windows aarch64 build issues > > Hello, any comments about the idea of calling into 'os::dll_load' instead ?

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v2]

2023-10-17 Thread Jorn Vernee
> Add the ability to pass heap segments to native code. This requires using > `Linker.Option.critical(true)` as a linker option. It has the same > limitations as normal critical calls, namely: upcalls into Java are not > allowed, and the native function should return relatively quickly. Heap >

Re: RFR: 8254693: Add Panama feature to pass heap segments to native code

2023-10-17 Thread Jorn Vernee
On Mon, 16 Oct 2023 10:19:17 GMT, Jorn Vernee wrote: > Add the ability to pass heap segments to native code. This requires using > `Linker.Option.critical(true)` as a linker option. It has the same > limitations as normal critical calls, namely: upcalls into Java are not > allowed, and the

RFR: 8254693: Add Panama feature to pass heap segments to native code

2023-10-17 Thread Jorn Vernee
Add the ability to pass heap segments to native code. This requires using `Linker.Option.critical(true)` as a linker option. It has the same limitations as normal critical calls, namely: upcalls into Java are not allowed, and the native function should return relatively quickly. Heap segments

Re: RFR: 8318363: Foreign benchmarks fail to build on some platforms

2023-10-17 Thread Jorn Vernee
On Tue, 17 Oct 2023 21:23:38 GMT, Aleksey Shipilev wrote: > Recent regression, see bug. The fix is to use the proper `jlong <-> ptr` > converters. > > Additional testing: > - [x] Build now passes on ARM32 > - [x] Two affected JMH benchmarks still run Thanks for fixing. I Suppose these

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-10-17 Thread Shaojin Wen
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-10-17 Thread Chen Liang
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-10-17 Thread Shaojin Wen
On Tue, 17 Oct 2023 15:56:58 GMT, Chen Liang wrote: > Can you export jfr recordings of two different runs to check? How to do this? I don't know how yet - PR Comment: https://git.openjdk.org/jdk/pull/16006#issuecomment-1767448022

Re: RFR: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16

2023-10-17 Thread Naoto Sato
On Tue, 17 Oct 2023 20:06:03 GMT, Justin Lu wrote: > This change updates the IANA subtag registry to the update released on > 2023-10-16. > > Announcement -> > https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html Marked as reviewed by naoto (Reviewer).

Re: RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Ioi Lam
On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung wrote: > Please review this changeset for adding support for `--module` (-m) option > for CDS. > Changes in the `ModuleBootstrap.java` are needed so that the > `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if > the main

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v23]

2023-10-17 Thread Aggelos Biboudis
> This is the proposed patch for Primitive types in patterns, instanceof, and > switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request with a new target base due to a merge

Re: RFR: 8315532: Compiler Implementation for Unnamed Variables and Patterns [v6]

2023-10-17 Thread Aggelos Biboudis
> This PR finalizes the feature of unnamed variables and patterns. Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional

Re: RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Alan Bateman
On Thu, 5 Oct 2023 16:18:57 GMT, Ioi Lam wrote: > Maybe we can add a new native method > `jdk.internal.misc.CDS.isBuiltinModule(Module m)` which tests if > `ModuleEntry::_location` starts with `"jrt:"`? There isn't any really notion of "built-in module", they may be modules in the run-time

Re: RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Calvin Cheung
On Fri, 6 Oct 2023 06:09:50 GMT, Alan Bateman wrote: >> When a named module is created, we know its location, which is also passed >> to the C code and stored inside the C++ `ModuleEntry` data structure. >> >>

Re: RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Ioi Lam
On Wed, 4 Oct 2023 15:59:54 GMT, Calvin Cheung wrote: >> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line >> 239: >> >>> 237:// only consider modules from JDK >>> 238:(mainModule.startsWith("jdk.") || >>>

Re: RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Alan Bateman
On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung wrote: > Please review this changeset for adding support for `--module` (-m) option > for CDS. > Changes in the `ModuleBootstrap.java` are needed so that the > `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if > the main

Re: RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Calvin Cheung
On Tue, 3 Oct 2023 07:11:54 GMT, Alan Bateman wrote: >> Please review this changeset for adding support for `--module` (-m) option >> for CDS. >> Changes in the `ModuleBootstrap.java` are needed so that the >> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if >> the

RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Calvin Cheung
Please review this changeset for adding support for `--module` (-m) option for CDS. Changes in the `ModuleBootstrap.java` are needed so that the `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if the main module is specified. The module name will be stored in the ro

Re: RFR: 8316969: Improve CDS module graph support for --module option

2023-10-17 Thread Ioi Lam
On Mon, 2 Oct 2023 22:17:34 GMT, Calvin Cheung wrote: > Please review this changeset for adding support for `--module` (-m) option > for CDS. > Changes in the `ModuleBootstrap.java` are needed so that the > `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if > the main

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Naoto Sato
On Tue, 17 Oct 2023 21:45:57 GMT, Steven Loomis wrote: > > CLDR provides very few short names for time zones, such as PST/PDT. This > > will typically end up substituting names from the COMPAT provider. Once the > > COMPAT is removed, they will be displayed in the GMT format, i.e., > >

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Steven Loomis
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 [v2]

2023-10-17 Thread Alexander Matveev
On Tue, 17 Oct 2023 07:04:03 GMT, yaqsun wrote: >> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test >> tools/jpackage/linux/LinuxResourceTest.java. >> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121. >> But after 8314121,

RFR: 8318363: Foreign benchmarks fail to build on some platforms

2023-10-17 Thread Aleksey Shipilev
Recent regression, see bug. The fix is to use the proper `jlong <-> ptr` converters. Additional testing: - [x] Build now passes on ARM32 - [x] Two affected JMH benchmarks still run - Commit messages: - Fix Changes: https://git.openjdk.org/jdk/pull/16228/files Webrev:

Re: RFR: 8318126: Refresh manpages

2023-10-17 Thread David Holmes
On Mon, 16 Oct 2023 23:55:01 GMT, Iris Clark wrote: >> The open nroff manpage files are out of sync with their closed markdown >> sources and need to be refreshed. >> >> The changes to apply are coming from: >> >> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor >>

Integrated: 8318126: Refresh manpages

2023-10-17 Thread David Holmes
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote: > The open nroff manpage files are out of sync with their closed markdown > sources and need to be refreshed. > > The changes to apply are coming from: > > - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor > to

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Roger Riggs
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

RFR: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16

2023-10-17 Thread Justin Lu
This change updates the IANA subtag registry to the update released on 2023-10-16. Announcement -> https://mm.icann.org/pipermail/ietf-languages-announcements/2023-October/89.html - Commit messages: - init Changes: https://git.openjdk.org/jdk/pull/16227/files Webrev:

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v6]

2023-10-17 Thread Lance Andersen
On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Iris Clark
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Erik Joelsson
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v6]

2023-10-17 Thread Sean Coffey
On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Lance Andersen
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Joe Wang
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY.

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v6]

2023-10-17 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: remove getCanonicalFile calls, update ZipFile jmh

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v5]

2023-10-17 Thread Roger Riggs
On Tue, 17 Oct 2023 14:22:10 GMT, Shaojin Wen wrote: >> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to >> use try...catch to handle CharacterCodingException and throw >> IllegalArgumentException instead of CharacterCodingException to make the >> calling code

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v22]

2023-10-17 Thread Vicente Romero
On Tue, 17 Oct 2023 14:44:38 GMT, Aggelos Biboudis wrote: >> This is the proposed patch for Primitive types in patterns, instanceof, and >> switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html > > Aggelos Biboudis

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers

2023-10-17 Thread Raffaello Giulietti
On Sun, 17 Sep 2023 16:01:33 GMT, Shaojin Wen wrote: > @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]

2023-10-17 Thread Naoto Sato
> CLDR provides very few short names for time zones, such as PST/PDT. This will > typically end up substituting names from the COMPAT provider. Once the COMPAT > is removed, they will be displayed in the GMT format, i.e., GMT+XX:YY. > Although some of the short names in the COMPAT provider are

Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v2]

2023-10-17 Thread Naoto Sato
On Tue, 17 Oct 2023 02:03:06 GMT, Roger Riggs wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use ZoneOffset to parse offset > > Looks fine. > (I can't help thinking that some of this pre-processing would be easier

Integrated: 8318295: Update launcher help for enable-native-access

2023-10-17 Thread Maurizio Cimadamore
On Tue, 17 Oct 2023 11:38:17 GMT, Maurizio Cimadamore wrote: > This simple PR updates the description of the `enable-native-access` option > in the launcher properties file. This pull request has now been integrated. Changeset: 39e2b7a6 Author:Maurizio Cimadamore URL:

Re: RFR: JDK-8315457 Implementation of String Templates (Second Preview) [v3]

2023-10-17 Thread Jim Laskey
> Update String Templates for a second preview. With the addition of > > - Expression type and throws are determined from the `process` method of the > processor type and not the processor type. > > - Qualified `STR` and `RAW` are treated the same as unqualified `STR` and > `RAW` . > > - Raw

Re: RFR: JDK-8315457 Implementation of String Templates (Second Preview) [v2]

2023-10-17 Thread Jim Laskey
On Mon, 16 Oct 2023 16:51:14 GMT, Jim Laskey wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 1691: >> >>> 1689: } >>> 1690: >>> 1691: private Type getProcessMethodType(JCStringTemplate tree, Type >>> processorType) { >> >> This method is

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-10-17 Thread Chen Liang
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-10-17 Thread Shaojin Wen
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-10-17 Thread Claes Redestad
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i

Re: RFR: 8315585: Optimization for decimal to string [v7]

2023-10-17 Thread Shaojin Wen
On Mon, 16 Oct 2023 15:00:42 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v4]

2023-10-17 Thread Chen Liang
On Tue, 17 Oct 2023 14:30:26 GMT, Shaojin Wen wrote: > @wenshao The proposal changes the exception types for seemingly no reason. > What concrete problem does this enhancement PR address? @rgiulietti The API was exposed to create a String without duplicating an array in compatible encoding.

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v21]

2023-10-17 Thread Aggelos Biboudis
On Tue, 17 Oct 2023 12:06:53 GMT, Raffaello Giulietti wrote: >> Aggelos Biboudis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust javadoc on ExactConversionsSupport > >

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v22]

2023-10-17 Thread Aggelos Biboudis
> This is the proposed patch for Primitive types in patterns, instanceof, and > switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request incrementally with one additional

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v4]

2023-10-17 Thread Shaojin Wen
On Tue, 17 Oct 2023 14:09:08 GMT, Raffaello Giulietti wrote: > @wenshao The proposal changes the exception types for seemingly no reason. > What concrete problem does this enhancement PR address? @lianch 's suggestion in PR #14812 : "Make the NoRepl methods throw IllegalArgument (like

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v5]

2023-10-17 Thread Shaojin Wen
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to > use try...catch to handle CharacterCodingException and throw > IllegalArgumentException instead of CharacterCodingException to make the > calling code cleaner. Shaojin Wen has updated the pull request incrementally

Re: RFR: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API [v5]

2023-10-17 Thread Martin Doerr
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition, > double values have only 4 Byte alignment within structures. This PR is based > on JDK22 version of the FFI. Martin Doerr has updated the pull request incrementally with two additional commits since the last

Re: RFR: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API [v4]

2023-10-17 Thread Martin Doerr
On Mon, 16 Oct 2023 22:56:42 GMT, Jorn Vernee wrote: >> Martin Doerr has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert changes to PlatformLayouts.java > >

Re: RFR: 8317545: AIX PPC64: Implementation of Foreign Function & Memory API [v5]

2023-10-17 Thread Jorn Vernee
On Tue, 17 Oct 2023 14:12:27 GMT, Martin Doerr wrote: >> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition, >> double values have only 4 Byte alignment within structures. This PR is based >> on JDK22 version of the FFI. > > Martin Doerr has updated the pull request

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v4]

2023-10-17 Thread Raffaello Giulietti
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote: >> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to >> use try...catch to handle CharacterCodingException and throw >> IllegalArgumentException instead of CharacterCodingException to make the >> calling code

Re: RFR: 8318295: Update launcher help for enable-native-access

2023-10-17 Thread Jorn Vernee
On Tue, 17 Oct 2023 11:38:17 GMT, Maurizio Cimadamore wrote: > This simple PR updates the description of the `enable-native-access` option > in the launcher properties file. Marked as reviewed by jvernee (Reviewer). - PR Review:

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Raffaello Giulietti
On Tue, 17 Oct 2023 13:12:08 GMT, Raffaello Giulietti wrote: >> This PR proposes to add a number of "capturing factories" in classes in the >> `java.util.function` package. >> >> The PR additionally (an optionally) proposes to add a new function >> `UnaryOperator::andThenUnary` to allow

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Raffaello Giulietti
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote: > This PR proposes to add a number of "capturing factories" in classes in the > `java.util.function` package. > > The PR additionally (an optionally) proposes to add a new function > `UnaryOperator::andThenUnary` to allow composition while

Re: RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 [v2]

2023-10-17 Thread Alexey Semenyuk
On Tue, 17 Oct 2023 07:04:03 GMT, yaqsun wrote: >> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test >> tools/jpackage/linux/LinuxResourceTest.java. >> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121. >> But after 8314121,

Re: RFR: 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild

2023-10-17 Thread Alexey Semenyuk
On Fri, 6 Oct 2023 22:15:00 GMT, Alexander Matveev wrote: > - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` > CLI options to jpackage to provide signing identity directly to `codesign` > and `productbuild` tools as per CSR >

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Raffaello Giulietti
On Tue, 17 Oct 2023 12:16:54 GMT, ExE Boss wrote: >> This PR proposes to add a number of "capturing factories" in classes in the >> `java.util.function` package. >> >> The PR additionally (an optionally) proposes to add a new function >> `UnaryOperator::andThenUnary` to allow composition

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Per Minborg
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote: > This PR proposes to add a number of "capturing factories" in classes in the > `java.util.function` package. > > The PR additionally (an optionally) proposes to add a new function > `UnaryOperator::andThenUnary` to allow composition while

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v21]

2023-10-17 Thread Raffaello Giulietti
On Mon, 16 Oct 2023 19:16:41 GMT, Aggelos Biboudis wrote: >> This is the proposed patch for Primitive types in patterns, instanceof, and >> switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html > > Aggelos Biboudis

Re: RFR: 8315097: Rename createJavaProcessBuilder [v4]

2023-10-17 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread ExE Boss
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote: > This PR proposes to add a number of "capturing factories" in classes in the > `java.util.function` package. > > The PR additionally (an optionally) proposes to add a new function > `UnaryOperator::andThenUnary` to allow composition while

Integrated: JDK-8249832: java/util/zip/DataDescriptorSignatureMissing.java uses @ignore w/o bug-id

2023-10-17 Thread Agnibho Hom Chowdhury
On Fri, 6 Oct 2023 12:43:02 GMT, Agnibho Hom Chowdhury wrote: > Please review this PR as a fix of > [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the > bug with after @ignore annotation. This pull request has now been integrated. Changeset: 34653c1e Author:

RFR: 8318295: Update launcher help for enable-native-access

2023-10-17 Thread Maurizio Cimadamore
This simple PR updates the description of the `enable-native-access` option in the launcher properties file. - Commit messages: - Initial push Changes: https://git.openjdk.org/jdk/pull/16217/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16217=00 Issue:

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v3]

2023-10-17 Thread Matthew Donovan
On Mon, 16 Oct 2023 23:56:24 GMT, Stuart Marks wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> retained a reference to the RMI server and improved naming > > test/lib/jdk/test/lib/Asserts.java line 588: > >>

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v4]

2023-10-17 Thread Alan Bateman
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote: >> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to >> use try...catch to handle CharacterCodingException and throw >> IllegalArgumentException instead of CharacterCodingException to make the >> calling code

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v4]

2023-10-17 Thread Shaojin Wen
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to > use try...catch to handle CharacterCodingException and throw > IllegalArgumentException instead of CharacterCodingException to make the > calling code cleaner. Shaojin Wen has updated the pull request incrementally

Integrated: 8318180: Memory model reference from foreign package-info is broken

2023-10-17 Thread Maurizio Cimadamore
On Mon, 16 Oct 2023 16:19:41 GMT, Maurizio Cimadamore wrote: > This PR fixes a wrong reference to the JLS memory model section. This pull request has now been integrated. Changeset: b2b8db65 Author:Maurizio Cimadamore URL:

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v4]

2023-10-17 Thread Alan Bateman
On Tue, 17 Oct 2023 11:11:52 GMT, Shaojin Wen wrote: >> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to >> use try...catch to handle CharacterCodingException and throw >> IllegalArgumentException instead of CharacterCodingException to make the >> calling code

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v3]

2023-10-17 Thread Claes Redestad
On Tue, 17 Oct 2023 10:42:59 GMT, Shaojin Wen wrote: >> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to >> use try...catch to handle CharacterCodingException and throw >> IllegalArgumentException instead of CharacterCodingException to make the >> calling code

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v3]

2023-10-17 Thread Shaojin Wen
> When calling String::newStringNoRepl and String::getBytesNoRepl, we need to > use try...catch to handle CharacterCodingException and throw > IllegalArgumentException instead of CharacterCodingException to make the > calling code cleaner. Shaojin Wen has updated the pull request incrementally

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v2]

2023-10-17 Thread Alan Bateman
On Tue, 17 Oct 2023 03:09:09 GMT, Chen Liang wrote: > The thrown CCE was intended for `Files.readString` and `Files.writeString`, > and is in reality, only used by those 2 sites. However, you missed updating > those sites, so they now throw IAE instead of CCE, which should be fixed. Right,

Re: RFR: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics [v2]

2023-10-17 Thread Ilya Gavrilin
On Tue, 17 Oct 2023 09:09:52 GMT, Fei Yang wrote: >> Ilya Gavrilin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix some registers usages and typos > > src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1682: > >> 1680: // use

Re: RFR: 8318200: String::newStringNoRepl and String::getBytesNoRepl does not throw CharacterCodingException [v2]

2023-10-17 Thread Claes Redestad
On Tue, 17 Oct 2023 03:09:09 GMT, Chen Liang wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix from @liach 's review > > The thrown CCE was intended for `Files.readString` and `Files.writeString`, > and is in

Re: RFR: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics [v2]

2023-10-17 Thread Fei Yang
On Mon, 16 Oct 2023 21:14:39 GMT, Ilya Gavrilin wrote: >> Hi all, please review this changes into risc-v floating point copysign and >> signum intrinsics. >> CopySign - returns first argument with the sign of second. On risc-v we have >> `fsgnj.x` instruction, which can implement this

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java [v3]

2023-10-17 Thread Mark Sheppard
On Tue, 17 Oct 2023 00:02:28 GMT, Stuart Marks wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> retained a reference to the RMI server and improved naming > > test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v5]

2023-10-17 Thread Sean Coffey
On Tue, 17 Oct 2023 08:50:15 GMT, Sean Coffey wrote: >> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source >> objects aren't created for the same zip file. > > Sean Coffey has updated the pull request with a new target base due to a > merge or a rebase. The

Re: RFR: 8317678: Fix up hashCode() for ZipFile.Source.Key [v5]

2023-10-17 Thread Sean Coffey
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source > objects aren't created for the same zip file. Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the

Re: RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Per Minborg
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote: > This PR proposes to add a number of "capturing factories" in classes in the > `java.util.function` package. > > The PR additionally (an optionally) proposes to add a new function > `UnaryOperator::andThenUnary` to allow composition while

RFR: 8317993: Add capturing factories to classes in java.util.function package

2023-10-17 Thread Per Minborg
This PR proposes to add a number of "capturing factories" in classes in the `java.util.function` package. The PR additionally (an optionally) proposes to add a new function `UnaryOperator::andThenUnary` to allow composition while retaining the `UnaryOperator` type. With the new change, it is

Re: RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

2023-10-17 Thread yaqsun
On Mon, 16 Oct 2023 17:24:01 GMT, Alexey Semenyuk wrote: > `%define _build_id_links none` must be added to a spec file in > LinuxResourceTest.java file. not on `rpmbuild` command line `%define _build_id_links none` has been added to a spec file in LinuxResourceTest.java file. Please review.

Re: RFR: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 [v2]

2023-10-17 Thread yaqsun
> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test > tools/jpackage/linux/LinuxResourceTest.java. > It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121. > But after 8314121, tools/jpackage/linux/LinuxResourceTest.java still > reappears.

Re: RFR: 8317971: RISC-V: implement copySignF/D and signumF/D intrinsics [v2]

2023-10-17 Thread Robbin Ehn
On Mon, 16 Oct 2023 21:14:39 GMT, Ilya Gavrilin wrote: >> Hi all, please review this changes into risc-v floating point copysign and >> signum intrinsics. >> CopySign - returns first argument with the sign of second. On risc-v we have >> `fsgnj.x` instruction, which can implement this