On Tue, 17 Oct 2023 19:55:19 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove getCanonicalFile calls, update ZipFile jmh benchmark test, tidy up
> junit test
Latest updates look good.
test/jdk/java/util/zip/ZipFile/ZipSourceCache.java line 103:
> 101: // the old Source in use for old file, should no longer
> map correctly
> 102: IOException ioe = assertThrows(IOException.class, () ->
> readZipFileContents(absoluteZipFile));
> 103: assertEquals("ZipFile invalid LOC header (bad
> signature)", ioe.getMessage());
Perhaps put the expected message in a constant in the event we need to change
it at some point it is easier to find
-------------
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16115#pullrequestreview-1683270909
PR Review Comment: https://git.openjdk.org/jdk/pull/16115#discussion_r1362698792
