On Wed, 6 Dec 2023 02:58:19 GMT, David Holmes wrote:
> The key point of this change is to split RUNNABLE into two states to
> indicated "runnable after yielding" and "runnable after being unparked".
That's right. This comes up with upcoming changes for monitors too - in that
case it is importa
On Fri, 1 Dec 2023 17:00:48 GMT, Viktor Klang wrote:
> Splits GatherersTest out to distinct files per built-in gatherer
>
> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
> the ProblemList.
>
> Adding increased maxOutputSize for Gatherer-related tests to improve
>
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Tue, 5 Dec 2023 09:51:50 GMT, Alan Bateman wrote:
>> When a virtual thread continues after Thread.yield it currently consumes
>> thread's parking permit. This is an oversight, the parking permit should
>> only be consumed when continuing after park.
>>
>> The changes are straight-forward. T
On Tue, 5 Dec 2023 09:51:50 GMT, Alan Bateman wrote:
>> When a virtual thread continues after Thread.yield it currently consumes
>> thread's parking permit. This is an oversight, the parking permit should
>> only be consumed when continuing after park.
>>
>> The changes are straight-forward. T
On Tue, 5 Dec 2023 23:04:55 GMT, Naoto Sato wrote:
> Currently, Locale-related system properties, such as `user.language` or
> `user.country`, are initialized when the `Locale` class is loaded. Making
> them static properties is safer than relying on the class initialization
> timing, which co
On Tue, 5 Dec 2023 23:04:55 GMT, Naoto Sato wrote:
> Currently, Locale-related system properties, such as `user.language` or
> `user.country`, are initialized when the `Locale` class is loaded. Making
> them static properties is safer than relying on the class initialization
> timing, which co
On Tue, 5 Dec 2023 10:56:44 GMT, Jaikiran Pai wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove micro optimization
>
> Thank you Stefan and Leonid for the reviews.
Sorry I missed this party :) Thanks for find
On Tue, 5 Dec 2023 13:00:04 GMT, Magnus Ihse Bursie wrote:
> So you need to check both the flag and the header file? Oh well, then this is
> probably as good as it gets.
Yes, we have to check both the flag and the header file.
-
PR Comment: https://git.openjdk.org/jdk/pull/16234#i
On Tue, 21 Nov 2023 09:16:17 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 564:
>>
>>> 562: * {@code reachabilityFence(x)}
>>> 563: * >> href="{@docRoot}/java.base/java/util/concurrent/package-summary.html#MemoryVisibility">happen-before
>>>
Currently, Locale-related system properties, such as `user.language` or
`user.country`, are initialized when the `Locale` class is loaded. Making them
static properties is safer than relying on the class initialization timing,
which could potentially be changed depending on the implementation.
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Sat, 2 Dec 2023 15:42:18 GMT, fabioromano1 wrote:
>> A faster and simpler way to generate random BigIntegers, avoiding eventually
>> trimming of leading zeros in magnitude array.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
On Tue, 5 Dec 2023 19:34:58 GMT, Joe Wang wrote:
> Improve null handling. When both the public and system IDs are null, this
> change lets the resolution process continue as usual, before the catalogs
> were added. This is consistent with the process on the other part of the
> program where a
On Tue, 5 Dec 2023 20:13:06 GMT, Jim Laskey wrote:
>> A regression is found in Java9+ creating String instance from UTF8 bytes, a
>> side effect of string compactation https://openjdk.org/jeps/254 that changed
>> the decoding logic. Specifically, when constructing a string from bytes:
>>
>> `
On Tue, 5 Dec 2023 09:51:50 GMT, Alan Bateman wrote:
>> When a virtual thread continues after Thread.yield it currently consumes
>> thread's parking permit. This is an oversight, the parking permit should
>> only be consumed when continuing after park.
>>
>> The changes are straight-forward. T
On Tue, 5 Dec 2023 09:08:59 GMT, Andrew Haley wrote:
>> We've seen some rare failures of the CLQ Whitebox test on "less-strong"
>> architectures, and the only thing which -- given my research -- could be the
>> culprit is spuriously failing weakCAS (which is correct in terms of the
>> implemen
On Tue, 5 Dec 2023 19:42:43 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Bump up memory
>> - Cotrrect NegativeSize.java
>
> test/jdk/java/lang/String/CompactString/NegativeSize.java line 36:
>
> A regression is found in Java9+ creating String instance from UTF8 bytes, a
> side effect of string compactation https://openjdk.org/jeps/254 that changed
> the decoding logic. Specifically, when constructing a string from bytes:
>
> ```
> String str = new String(largeBytes, StandardCharsets
On 05.12.23 21:02, Brett Okken wrote:
Should the private static AtomicInteger nextHashCode also be final?
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/ThreadLocal.java#L100
Yes, I think so. Feel free to submit a PR!
-Aleksey
Amazon Development Center Ger
Should the private static AtomicInteger nextHashCode also be final?
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/ThreadLocal.java#L100
Improve null handling. When both the public and system IDs are null, this
change lets the resolution process continue as usual, before the catalogs were
added. This is consistent with the process on the other part of the program
where a CatalogResolver is used only when the IDs are not null.
Te
On Mon, 4 Dec 2023 22:15:24 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX2 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
>>
On Tue, 5 Dec 2023 14:57:09 GMT, Jim Laskey wrote:
> A regression is found in Java9+ creating String instance from UTF8 bytes, a
> side effect of string compactation https://openjdk.org/jeps/254 that changed
> the decoding logic. Specifically, when constructing a string from bytes:
>
> ```
>
On Thu, 30 Nov 2023 00:03:21 GMT, Brian Burkhalter wrote:
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
This pull request has now been integrated.
Changeset: b0d14509
Author:Brian Bu
On Mon, 4 Dec 2023 22:15:24 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX2 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
>>
On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to impr
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked ru
On Mon, 4 Dec 2023 20:08:15 GMT, Alexey Semenyuk wrote:
> 8294699: Launcher causes lingering busy cursor
This pull request has now been integrated.
Changeset: d3df3eb5
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/d3df3eb5d7f5537ade917db7a36caba028f94111
Stats:
On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to impr
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8321053: Fix overlooked com
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8321053: s/tmp/tmpbuf/
---
On Tue, 5 Dec 2023 16:40:59 GMT, Brian Burkhalter wrote:
>> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
>> `BAIS.transferTo` only if the target stream is in the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additio
On Tue, 5 Dec 2023 11:19:00 GMT, Magnus Ihse Bursie wrote:
>> Hi Marcus (@magicus), please see the updated code which added guards to
>> check for GCC version >= 7.5 in
>> `src/java.base/linux/native/libsimdsort/{avx2-linux-qsort.cpp,
>> avx512-linux-qsort.cpp}`. GCC >= 7.5 is needed to compil
On Tue, 5 Dec 2023 14:55:02 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to impr
On Tue, 5 Dec 2023 12:58:45 GMT, Markus KARG wrote:
>> I suspect it's left over from a previous iteration. In any case, limiting it
>> to a small number of output streams makes this easier to look at. BAOS and
>> FOS seem okay, POP seems okay too but legacy and not interesting.
>
>> I suspect i
> Pass `ByteArrayInputStream.buf ` directly to the `OutputStream` parameter of
> `BAIS.transferTo` only if the target stream is in the `java.io` package.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8321053: Remove package che
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelate
On Tue, 5 Dec 2023 16:15:31 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reduce oversignalling and contention; add test
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelate
On Sun, 3 Dec 2023 17:13:49 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reduce oversignalling
On Sun, 3 Dec 2023 17:13:49 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reduce oversignalling
On Tue, 5 Dec 2023 12:02:59 GMT, Per Minborg wrote:
>> This PR proposes to reject paths provided to the
>> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
>> in the default file system.
>
> Per Minborg has updated the pull request incrementally with one additional
On Wed, 29 Nov 2023 23:31:56 GMT, Mandy Chung wrote:
> Thanks. I'll continue the review on the revised version.
@mlchung I've pushed the updates now. Please take another look. I'll merge
latest master in the next couple of hours.
-
PR Comment: https://git.openjdk.org/jdk/pull/1478
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked ru
On Tue, 5 Dec 2023 12:46:49 GMT, fabioromano1 wrote:
>> Relaying comments from a colleague:
>>
>> 1. Half of the random bits are wasted by the use of `nextInt()`, which by
>> default invokes `nextLong()` and throws away the lower 32 bits. Not sure if
>> complicating the code to use all the 64
A regression is found in Java9+ creating String instance from UTF8 bytes, a
side effect of string compactation https://openjdk.org/jeps/254 that changed
the decoding logic. Specifically, when constructing a string from bytes:
```
String str = new String(largeBytes, StandardCharsets.UTF_8);
``
On Tue, 5 Dec 2023 14:57:09 GMT, Jim Laskey wrote:
> A regression is found in Java9+ creating String instance from UTF8 bytes, a
> side effect of string compactation https://openjdk.org/jeps/254 that changed
> the decoding logic. Specifically, when constructing a string from bytes:
>
> ```
>
> Splits GatherersTest out to distinct files per built-in gatherer
>
> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
> the ProblemList.
>
> Adding increased maxOutputSize for Gatherer-related tests to improve
> debuggability.
>
> Lowering the composition threshold
On Tue, 5 Dec 2023 14:19:34 GMT, Viktor Klang wrote:
> Do you want me to make this change as a part of this PR or does it make more
> sense to get this one integrated first?
I think it's okay to leave it to another time, I assume these tests be updated
a few times before the feature becomes pe
On Tue, 5 Dec 2023 14:07:53 GMT, Alan Bateman wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removing extraneous built-in gatherer test output
>
> test/jdk/java/util/stream/GatherersMapConcurrentTest.java line 106
On Mon, 4 Dec 2023 14:25:05 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to impr
On Mon, 4 Dec 2023 21:25:41 GMT, Martin Doerr wrote:
> I'd like to clean this up: Use the canonical layouts which are available in
> JDK22. Use try-with-resources for `Arena.ofConfined()`.
This pull request has now been integrated.
Changeset: a1fe16b5
Author:Martin Doerr
URL:
https
On Tue, 5 Dec 2023 08:27:09 GMT, Alan Bateman wrote:
> I suspect it's left over from a previous iteration. In any case, limiting it
> to a small number of output streams makes this easier to look at. BAOS and
> FOS seem okay, POP seems okay too but legacy and not interesting.
Agreed for a rath
On Tue, 5 Dec 2023 07:21:32 GMT, Xiaohong Gong wrote:
>> also, ideally, you will add the corresponding specific overrides like in ffi:
>>
>> AC_ARG_WITH(libffi-include, [AS_HELP_STRING([--with-libffi-include],
>> [specify directory for the libffi include files])])
>> AC_ARG_WITH(libffi
On Fri, 1 Dec 2023 08:48:52 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X8
On Mon, 4 Dec 2023 22:26:32 GMT, Brian Burkhalter wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Create RandomBigIntegers.java
>>
>> Create a benchmark to measure the performance of BigInteger(int, Random)
>
> This PR proposes to reject paths provided to the
> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
> in the default file system.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Fix double negation
On Mon, 4 Dec 2023 14:25:05 GMT, Viktor Klang wrote:
>> Splits GatherersTest out to distinct files per built-in gatherer
>>
>> Fixes a test ordering issue for mapConcurrent which placed GatherersTest on
>> the ProblemList.
>>
>> Adding increased maxOutputSize for Gatherer-related tests to impr
On Tue, 5 Dec 2023 10:46:41 GMT, fabioromano1 wrote:
>> Relaying comments from a colleague:
>>
>> 1. Half of the random bits are wasted by the use of `nextInt()`, which by
>> default invokes `nextLong()` and throws away the lower 32 bits. Not sure if
>> complicating the code to use all the 64
On Mon, 4 Dec 2023 22:14:14 GMT, Srinivas Vamsi Parasa wrote:
>> Then you must add logic to check for this. Now the build will just fail if
>> building with an older gcc. That is not acceptable.
>
> Hi Marcus (@magicus), please see the updated code which added guards to check
> for GCC version
On Thu, 30 Nov 2023 17:19:14 GMT, Mandy Chung wrote:
>> Sure this can be done. Makes the jimage a bit larger, but probably
>> negligible as the total set of modules is usually small.
>
> It adds more empty files which I expect should be very small increase in
> size. Since this is added by de
On Fri, 1 Dec 2023 12:44:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change to the test library's
>> `OutputAnalyzer` class, which proposes to remove some unnecessary logging
>> from the `getExitValue()` call?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8321163,
On Fri, 1 Dec 2023 09:48:23 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change to the test library's
> `OutputAnalyzer` class, which proposes to remove some unnecessary logging
> from the `getExitValue()` call?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8321163, righ
On Wed, 29 Nov 2023 23:25:03 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions p
On Mon, 4 Dec 2023 22:26:32 GMT, Brian Burkhalter wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Create RandomBigIntegers.java
>>
>> Create a benchmark to measure the performance of BigInteger(int, Random)
>
On Tue, 5 Dec 2023 07:16:49 GMT, Per Minborg wrote:
>> This PR proposes to reject paths provided to the
>> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
>> in the default file system.
>
> Per Minborg has updated the pull request incrementally with one additional
On Wed, 29 Nov 2023 22:38:45 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tighten ModifiedFilesExitTest
>>
>> Ensure the error message is reasonable and doesn't include
>> Exceptions p
On Mon, 4 Dec 2023 21:25:41 GMT, Martin Doerr wrote:
> I'd like to clean this up: Use the canonical layouts which are available in
> JDK22. Use try-with-resources for `Arena.ofConfined()`.
Marked as reviewed by jbechberger (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull
On Sun, 3 Dec 2023 08:46:07 GMT, Alan Bateman wrote:
> This API is sitting out JDK 22, meaning no API/implementation changes in this
> PR. Some small API changes are likely for JDK 23.
>
> For now, we just need to bump JEP number/title that shows up in the preview
> section of the javadoc.
Ma
On Mon, 4 Dec 2023 21:25:41 GMT, Martin Doerr wrote:
> I'd like to clean this up: Use the canonical layouts which are available in
> JDK22. Use try-with-resources for `Arena.ofConfined()`.
Thanks for the reviews! The Pre-submit test errors are unrelated.
-
PR Comment: https://git.
On Tue, 5 Dec 2023 07:16:49 GMT, Per Minborg wrote:
>> This PR proposes to reject paths provided to the
>> `SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not
>> in the default file system.
>
> Per Minborg has updated the pull request incrementally with one additional
> When a virtual thread continues after Thread.yield it currently consumes
> thread's parking permit. This is an oversight, the parking permit should only
> be consumed when continuing after park.
>
> The changes are straight-forward. The internal "RUNNABLE" state is replaced
> with UNPARKED an
On Wed, 22 Nov 2023 20:48:05 GMT, Viktor Klang wrote:
> We've seen some rare failures of the CLQ Whitebox test on "less-strong"
> architectures, and the only thing which -- given my research -- could be the
> culprit is spuriously failing weakCAS (which is correct in terms of the
> implementat
On Mon, 4 Dec 2023 20:25:56 GMT, ExE Boss wrote:
>> When a virtual thread continues after Thread.yield it currently consumes
>> thread's parking permit. This is an oversight, the parking permit should
>> only be consumed when continuing after park.
>>
>> The changes are straight-forward. The i
On Mon, 4 Dec 2023 16:08:32 GMT, Alan Bateman wrote:
> When a virtual thread continues after Thread.yield it currently consumes
> thread's parking permit. This is an oversight, the parking permit should only
> be consumed when continuing after park.
>
> The changes are straight-forward. The in
On Mon, 4 Dec 2023 21:33:52 GMT, Serguei Spitsyn wrote:
> Just want to make sure this change is intentional. Before the comment was:
> `// runnable-mounted`.
Well spotted, the wrong comment was moved.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16953#discussion_r14151460
On Tue, 5 Dec 2023 07:37:39 GMT, Markus KARG wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8321053: instanceof -> ==
>
> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 213:
>
>> 211:
79 matches
Mail list logo
