Hello all,
After reading through Brian Goetz's "Effect cases on Switch" (specifically,
the "Other switch tricks" section), I have decided to not implement this
feature after all. The fact is, switch expressions, especially with
"when-clauses", does a better job of clarifying intent than this featu
On Sun, 31 Dec 2023 21:14:54 GMT, Lance Andersen wrote:
> With the conversion, I probably would would at separating out the test runs
> for ZipFile and ZipInputStream and introduce a DataProvider.
Thanks, I separated into two top-level parameterized tests as suggested. Indeed
this was much cle
> Please review this test-only PR which adds test coverage for
> `ZipFile.getEntry` under certain charset conditions.
>
> When `ZipFile.getEntry` is called for an entry which has the `Language
> encoding flag` general purpose bit flag set, then `ZipCoder.UTF8` is used
> unconditionally, even
On Sun, 31 Dec 2023 18:07:33 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which adds test coverage for
> `ZipFile.getEntry` under certain charset conditions.
>
> When `ZipFile.getEntry` is called for an entry which has the `Language
> encoding flag` general purpose bit flag se
On Sun, 31 Dec 2023 18:07:33 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which adds test coverage for
> `ZipFile.getEntry` under certain charset conditions.
>
> When `ZipFile.getEntry` is called for an entry which has the `Language
> encoding flag` general purpose bit flag se
Please review this test-only PR which adds test coverage for `ZipFile.getEntry`
under certain charset conditions.
When `ZipFile.getEntry` is called for an entry which has the `Language encoding
flag` general purpose bit flag set, then `ZipCoder.UTF8` is used
unconditionally, even when a diffe
