> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> -
On Fri, 5 Apr 2024 21:57:15 GMT, Roger Riggs wrote:
> The test doesn't run quickly already due to the large chunks of memory used.
OK, never mind then, if it would take considerable time.
-
PR Comment: https://git.openjdk.org/jdk/pull/18663#issuecomment-2040706486
On Fri, 5 Apr 2024 21:53:50 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall
On Fri, 5 Apr 2024 20:17:39 GMT, Naoto Sato wrote:
> LGTM. The test case could be more thorough if it tests strings with
> supplementary codepoints, as the new method computes them exclusively.
I considered that, but the worst case is the x3 expansion.
A 2 character high/low surrogate pair
> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
> this change.
>
> Overall, making this an intrinsic improves overall performance of
> `Unsafe::setMemory` by up to 4x for all buffer sizes.
On Fri, 5 Apr 2024 17:44:38 GMT, Roger Riggs wrote:
> When encoding a vary large string in String.getBytes(StandardCharset.UTF_8)
> computation of the buffer size may exceed the range of a positive 32-bit
> Integer.
> If the estimated size for the result byte array is too large, pre-compute
On Fri, 5 Apr 2024 18:14:36 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
+1
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1984005299
On Fri, 5 Apr 2024 18:32:09 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Fri, 5 Apr 2024 13:09:56 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JavaCompiler cleanup
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 2117:
>
>> 2115:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1983860994
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with three additional
commits since the last revision:
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
I like the new switch!
-
Marked as reviewed by iris (Reviewer).
PR Review:
On Fri, 5 Apr 2024 17:22:36 GMT, Naoto Sato wrote:
> Fix a file/class name in the `CLDRConverter` build tool, with some clean-up
> for a switch statement.
LGTM
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/18662#pullrequestreview-1983814332
When encoding a vary large string in String.getBytes(StandardCharset.UTF_8)
computation of the buffer size may exceed the range of a positive 32-bit
Integer.
If the estimated size for the result byte array is too large, pre-compute the
exact buffer size.
If that exceeds the range, then throw
On Fri, 5 Apr 2024 17:44:22 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
On Fri, 5 Apr 2024 17:38:50 GMT, Mandy Chung wrote:
>> Suchismith Roy has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - update tests
>> - update tests
>
>
On Fri, 5 Apr 2024 16:18:11 GMT, Mandy Chung wrote:
>> Suchismith Roy has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - spaces
>> - nits and move file to aix directory
>
>
On Fri, 5 Apr 2024 17:41:36 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Fri, 5 Apr 2024 08:58:34 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with two additional
commits since the last revision:
-
On Wed, 3 Apr 2024 05:56:55 GMT, Joe Darcy wrote:
> Exploratory work in support of https://github.com/openjdk/jdk/pull/18509.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/18590
On Wed, 3 Apr 2024 05:56:55 GMT, Joe Darcy wrote:
> Exploratory work in support of https://github.com/openjdk/jdk/pull/18509.
The changes in this PR are being incorporated into the larger PR for derived
record creation.
-
PR Comment:
Fix a file/class name in the `CLDRConverter` build tool, with some clean-up for
a switch statement.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/18662/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18662=00
Issue:
On Fri, 5 Apr 2024 08:58:34 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Fri, 5 Apr 2024 08:58:34 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request
On Fri, 5 Apr 2024 08:08:27 GMT, Suchismith Roy wrote:
>> The test should verify if `/usr/lib/libperstat.a` is present and also
>> `/usr/lib/libperfstat.so` is not present.
>>
>> Do you expect all AIX machines do not have `/usr/lib/libperfstat.so`?
>
> Yes it is expected. the hotspot code has
On Wed, 3 Apr 2024 19:01:14 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `append` for a `null` `CharSequence` parameter and
> clean up a couple of other typos.
This pull request has now been integrated.
Changeset: 040c9356
Author:Brian Burkhalter
URL:
https://openjdk.org/jeps/473
Summary: Enhance the Stream API to support custom intermediate
operations. This will allow stream pipelines to transform data in ways
that are not easily achievable with the existing built-in intermediate
operations. This is a preview API.
- Mark
On Thu, 4 Apr 2024 22:18:16 GMT, Joshua Cao wrote:
> I tried looking at the docs with `make docs-image`, but I can't test that the
> syntax/links are actually correct because `@implNote` does not actually show
> up in the web pages. As I understand from [the original
>
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Fri, 5 Apr 2024 12:40:22 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Thu, 4 Apr 2024 20:27:36 GMT, Jan Lahoda wrote:
>> src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java
>> line 133:
>>
>>> 131: */
>>> 132:
>>> @PreviewFeature(feature=PreviewFeature.Feature.DERIVED_RECORD_CREATION,
>>> reflective=true)
>>> 133:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Thu, 4 Apr 2024 17:00:33 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java
> line 1574:
>
>> 1572:
> This is a patch for javac, that adds the Derived Record Creation expressions.
> The current draft specification for the feature is:
> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>
> The current CSR is here:
>
On Thu, 4 Apr 2024 16:47:07 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 2235:
>
>> 2233:
On Fri, 5 Apr 2024 09:31:18 GMT, Severin Gehwolf wrote:
>> Kind of aligning with the "Donaudampfschiffahrtsgesellschaftskapitän"
>> prejudice of German. ;-)
>>
>>
>>
>> (In Sweden, we have "flaggstångsknoppsförgyllare" so you are not alone)
>
> Hah! My kids just recently informed me about
On Fri, 5 Apr 2024 08:21:09 GMT, Severin Gehwolf wrote:
>> Just to clarify: I did not say the name needed to be long, just that many
>> (if not all) tools has used the convention of using the package name
>> `build.tools.` and the class name `.java`.
>>
>> I think the new name sounds .
>
>
On Fri, 5 Apr 2024 09:25:49 GMT, Magnus Ihse Bursie wrote:
>> Thanks. Yes, the long name was my doing. Sorry.
>
> Kind of aligning with the "Donaudampfschiffahrtsgesellschaftskapitän"
> prejudice of German. ;-)
>
>
>
> (In Sweden, we have "flaggstångsknoppsförgyllare" so you are not alone)
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with two additional
commits since the last revision:
-
On Thu, 4 Apr 2024 20:56:02 GMT, Magnus Ihse Bursie wrote:
>> I was not aware of such a convention and I can't say I agree with it. It
>> just seems redundant and unnecessary, but I suppose we should wait for
>> Magnus to respond.
>
> Just to clarify: I did not say the name needed to be long,
On Thu, 4 Apr 2024 17:38:31 GMT, Mandy Chung wrote:
>> test/jdk/java/lang/RuntimeTests/loadLibrary/LoadLibraryTestAIX.java line 38:
>>
>>> 36: } catch (Exception e) {
>>> 37: throw new RuntimeException("LoadLibraryTestAIX : could not
>>> load libperfstat.a"+e);
>>> 38:
On Tue, 2 Apr 2024 10:37:02 GMT, Per Minborg wrote:
> This PR proposes to make empty immutable lists always throw UOE on
> `removeFirst` and `removeLast`.
This pull request has now been integrated.
Changeset: b71acc70
Author:Per Minborg
URL:
49 matches
Mail list logo
