This PR proposes to update the javadocs for `ValueLayout.JAVA_LONG` and
`ValueLayout.JAVA_DOUBLE` to reflect the changes made in
https://bugs.openjdk.org/browse/JDK-8326172 (we forgot to update the docs when
that issue was fixed)
-
Commit messages:
- Update copyright year
- Fix
> This PR proposes to add a new method `MemorySegment::maxByteAlignment` that
> returns the maximum byte alignment of a segment (both heap and native
> segments).
>
> Clients can then use this method to determine if a segment is properly
> aligned for any given layout (e.g. following a `MemoryS
> This PR proposes to add a new method `MemorySegment::maxByteAlignment` that
> returns the maximum byte alignment of a segment (both heap and native
> segments).
>
> Clients can then use this method to determine if a segment is properly
> aligned for any given layout (e.g. following a `MemoryS
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue link
On Mon, 26 Feb 2024 14:17:09 GMT, Daniel Fuchs wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/SelectorSelectEvent.java line 44:
>>
>>> 42: @Label("SelectionKey Count")
>>> 43: @Description("Number of channels ready for I/O or added to ready
>>> set")
>>> 44: public int selection
On Tue, 2 Apr 2024 09:37:52 GMT, Adam Sotona wrote:
> `IllegalArgumentException` thrown by some static factory methods of the
> following `java.lang.classfile.instruction` interfaces are not documented:
>
> - `ArrayLoadInstruction`
> - `ArrayStoreInstruction`
> - `BranchInstruction`
> - `Conver
On Mon, 15 Apr 2024 18:25:02 GMT, Sonia Zaldana Calles
wrote:
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue link
On Tue, 16 Apr 2024 07:55:26 GMT, Thomas Stuefe wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the issue lin
This PR proposes to add an internal layout transformer that could be used to
transform MemoryLayout entities. For example, it would be possible to convert a
struct layout to use network order ((big-endian) instead of native byte order
(often little-endian). Another application is to remove namin
On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken wrote:
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
To me this looks useful, although maybe the overall JLI tracing could be
revisited.
src/ja
On Mon, 15 Apr 2024 12:47:08 GMT, Matthias Baesken wrote:
> > If we expand the tracing then I think it should be consistent with the
> > existing tracing.
>
> What exactly do you see as inconsistent ?
Maybe the output of the tracing should look similar to other traces done
through `JLI_TraceL
On Tue, 16 Apr 2024 09:14:50 GMT, Christoph Langer wrote:
> > What exactly do you see as inconsistent ?
>
> Maybe the output of the tracing should look similar to other traces done
> through `JLI_TraceLauncher`? E.g. not mention method names but just tell what
> the program is doing... ?
Okay
On Tue, 16 Apr 2024 07:49:26 GMT, Per Minborg wrote:
>> This PR proposes to add a new method `MemorySegment::maxByteAlignment` that
>> returns the maximum byte alignment of a segment (both heap and native
>> segments).
>>
>> Clients can then use this method to determine if a segment is properl
On Tue, 16 Apr 2024 07:09:55 GMT, Per Minborg wrote:
> This PR proposes to update the javadocs for `ValueLayout.JAVA_LONG` and
> `ValueLayout.JAVA_DOUBLE` to reflect the changes made in
> https://bugs.openjdk.org/browse/JDK-8326172 (we forgot to update the docs
> when that issue was fixed)
M
On Tue, 16 Apr 2024 09:39:02 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update JavaDoc
>
> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 612:
>
>> 610: *
On Mon, 15 Apr 2024 21:37:15 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Mon, 15 Apr 2024 07:36:05 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void main() {
>> System.out.println("main called!");
>> }
>> }
>>
On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken wrote:
> We have already good JLI tracing capabilities. But GetApplicationHome and
> GetApplicationHomeFromDll lack some tracing and should be enhanced.
I think this is way too ad hoc and looks like lefts over from a debugging
session. So I don
On Tue, 2 Apr 2024 15:04:40 GMT, Per Minborg wrote:
> This PR proposes to add an internal layout transformer that could be used to
> transform MemoryLayout entities. For example, it would be possible to convert
> a struct layout to use network order ((big-endian) instead of native byte
> order
On Tue, 16 Apr 2024 08:25:01 GMT, Thomas Stuefe wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 912:
>>
>>> 910: private static final int MAIN_WITHOUT_ARGS = 1;
>>> 911: private static final int MAIN_NONSTATIC = 2;
>>> 912: private static int mainType = 0;
On Tue, 2 Apr 2024 15:04:40 GMT, Per Minborg wrote:
> This PR proposes to add an internal layout transformer that could be used to
> transform MemoryLayout entities. For example, it would be possible to convert
> a struct layout to use network order ((big-endian) instead of native byte
> order
On Thu, 4 Apr 2024 12:18:07 GMT, Viktor Klang wrote:
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this P
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtime link supporting classes in package
>> jdk.t
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtime link supporting classes in package
>> jdk.t
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has updat
On Tue, 16 Apr 2024 07:09:55 GMT, Per Minborg wrote:
> This PR proposes to update the javadocs for `ValueLayout.JAVA_LONG` and
> `ValueLayout.JAVA_DOUBLE` to reflect the changes made in
> https://bugs.openjdk.org/browse/JDK-8326172 (we forgot to update the docs
> when that issue was fixed)
M
On Tue, 16 Apr 2024 10:03:21 GMT, David Holmes wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback.
>
> src/java.base/share/native/libjli/java.c line 419:
>
>> 417: invokeInstanceMainWithArgs(
On Tue, 16 Apr 2024 11:59:12 GMT, Severin Gehwolf wrote:
> If I understand you correctly, this would be no longer a build-time only
> approach to produce the "linkable runtime"? It would be some-kind of
> jlink-option driven approach (as it would run some code that should only run
> when produ
On Mon, 15 Apr 2024 14:02:56 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
On Tue, 16 Apr 2024 06:30:55 GMT, Alan Bateman wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the issue link
On Tue, 16 Apr 2024 09:09:00 GMT, Christoph Langer wrote:
>> We have already good JLI tracing capabilities. But GetApplicationHome and
>> GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> src/java.base/windows/native/libjli/java_md.c line 326:
>
>> 324: }
>> 325:
>> 3
On Tue, 16 Apr 2024 10:20:23 GMT, Alan Bateman wrote:
> I think this is way too ad hoc and looks like lefts over from a debugging
> session. So I don't think it should be integrated without stepping back and
> thinking more about what this tracing option is intended for.
Currently there seem t
On Thu, 11 Apr 2024 12:08:02 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
On Wed, 3 Apr 2024 10:52:10 GMT, Alan Bateman wrote:
> This is a test-only addition to add a test for virtual threads invoking a
> synchronized native method and invoking a native method that enter/exits a
> monitor with JNI MonitorEnter/MonitorExit. The test has been in the loom repo
> for so
On Tue, 16 Apr 2024 14:40:46 GMT, Jan Kratochvil
wrote:
> IMHO `is_containerized()` is OK to return `false` even when running in a
> container but with no limitations set.
The idea here is to use this property to tune OpenJDK for in-container,
specifically k8s, use. In such a setup it's custo
On Tue, 16 Apr 2024 14:29:13 GMT, Matthias Baesken wrote:
> I am not sure if this even works any more. Maybe Alan could comment on this ?
The GetPublicJREHome function was removed at some point, I think JDK 9, as it
didn't make sense to have in the OpenJDK project. However, Oracle installer did
On Mon, 15 Apr 2024 20:41:10 GMT, Tim Prinzing wrote:
>> test/jdk/jdk/jfr/event/io/TestAsynchronousFileChannelEvents.java line 50:
>>
>>> 48:
>>> 49: public static void main(String[] args) throws Throwable {
>>> 50: File blah = File.createTempFile("blah", null);
>>
>> Can you chang
> I added `@since` tags for methods/constructors that do not match the `@since`
> of the enclosing class.
>
> The `write` method already existed in `PrintStream` in earlier versions and
> instances of it could always call this method, since it extends
> `FilterOutputStream` [which has the
> me
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote:
> Fixing a typo in the javadoc
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/18788#issuecomment-2059441642
On Mon, 15 Apr 2024 19:39:41 GMT, Naoto Sato wrote:
> Fixing a typo in the javadoc
This pull request has now been integrated.
Changeset: 2ede1433
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/2ede14335a2c9133bf4f356189cfbd5839361d17
Stats: 2 lines in 1 file changed:
On Mon, 18 Mar 2024 06:24:54 GMT, Justin Lu wrote:
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
> parsing for NumberFormat.
>
> The concrete subclasses that will utilize this leniency value are
> `DecimalFormat` and `Compa
On Tue, 16 Apr 2024 06:08:00 GMT, Jaikiran Pai wrote:
> Naoto, Roger, should we consider a release note for this change or is the CSR
> itself enough?
I think CSR is enough, as users' chance of encountering any issue is very slim.
My $0.02
-
PR Comment: https://git.openjdk.org/jd
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for these
> classes. This PR consists of changes such as b
On Tue, 16 Apr 2024 17:09:04 GMT, Justin Lu wrote:
>> Please review this PR which is a large spec reformatting for
>> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
>> and CompactNumberFormat.
>>
>> The motivation for this change was the difficulty of readability f
On Mon, 15 Apr 2024 18:43:29 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains five commits:
>>
>> - merge master and add setStrict() to nFmt class spec
>> - implement suggestions from dFmt revi
On Wed, 3 Apr 2024 22:31:39 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move CreateLinkableRuntimePlugin to build folder
>>
>> Keep runtime link supporting classes in package
>> jdk.t
On Tue, 16 Apr 2024 00:04:15 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performanc
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2004323374
On Thu, 11 Apr 2024 12:08:02 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
On Sat, 13 Apr 2024 18:29:59 GMT, Thomas Stuefe wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> comm
On Wed, 10 Apr 2024 16:17:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minim
The method `java.io.ObjectOutputStream.PutField.write` has been deprecated
since 1.4 and should be deprecated for removal. The Deprecation annotation is
updated to indicate the intention to remov the method.
-
Commit messages:
- 8329805: Deprecate for removal ObjectOutputStream.Put
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1481:
> 1479: int JAVA_23_VERSION = 67;
> 1480:
> 1481: /** 68 */
We need `@since 24` here.
-
PR Review Comment: https://git.open
On Tue, 16 Apr 2024 17:12:06 GMT, Justin Lu wrote:
>> Please review this PR which is a large spec reformatting for
>> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
>> and CompactNumberFormat.
>>
>> The motivation for this change was the difficulty of readability f
On Tue, 16 Apr 2024 17:06:50 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains five commits:
>>
>> - merge master and add setStrict() to nFmt class spec
>> - implement suggestions from dFmt revie
On Tue, 16 Apr 2024 19:44:36 GMT, Roger Riggs wrote:
> The method `java.io.ObjectOutputStream.PutField.write` has been deprecated
> since 1.4 and should be deprecated for removal. The Deprecation annotation is
> updated to indicate the intention to remov the method.
Marked as reviewed by naoto
> Please review this PR which is a large spec reformatting for
> _java.text.NumberFormat_ and related subclasses, specifically DecimalFormat
> and CompactNumberFormat.
>
> The motivation for this change was the difficulty of readability for these
> classes. This PR consists of changes such as b
On Tue, 16 Apr 2024 21:14:28 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains five commits:
>>
>> - merge master and add setStrict() to nFmt class spec
>> - implement suggestions from dFmt revi
On Tue, 16 Apr 2024 22:30:47 GMT, Justin Lu wrote:
>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 78:
>>
>>> 76: * installed. Thus, to use an instance method defined by {@code
>>> CompactNumberFormat},
>>> 77: * the {@code NumberFormat} returned by the factory method s
On Thu, 4 Apr 2024 09:20:39 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any comm
On Tue, 16 Apr 2024 19:44:36 GMT, Roger Riggs wrote:
> The method `java.io.ObjectOutputStream.PutField.write` has been deprecated
> since 1.4 and should be deprecated for removal. The Deprecation annotation is
> updated to indicate the intention to remov the method.
Marked as reviewed by iris
On Tue, 16 Apr 2024 15:17:33 GMT, Severin Gehwolf wrote:
> The idea here is to use this property to tune OpenJDK for in-container,
> specifically k8s, use. In such a setup it's custom to run a single process
> within set resource constraints.
The in-container tuning means to use all the availa
> Currently the JFR event FileForceEvent is generated by instrumenting the
> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer
> mirror events with static methods.
>
> Added the event at jdk.internal.event.FileForceEvent, and changed
> jdk.jfr.events.FileForceEvent to
On Tue, 16 Apr 2024 15:49:08 GMT, Daniel Fuchs wrote:
>> I'm not sure what you mean about the recording. The file is the
>> AsynchronousFileChannel under test and does not contain the event recording.
>
> It's anyway better to create temporary files in the test scratch directory
> rather than
On Tue, 16 Apr 2024 21:21:43 GMT, Chen Liang wrote:
>> Get JDK 24 underway.
>
> src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1481:
>
>> 1479: int JAVA_23_VERSION = 67;
>> 1480:
>> 1481: /** 68 */
>
> We need `@since 24` here.
Ah, good catch; looks like I was tre
> Get JDK 24 underway.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Correct release date as observed in review feedback.
- Improve javadoc of class file update.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/187
> Consider code like:
>
> public class MainClass {
> public MainClass() {
> System.out.println("Constructor called!");
> }
> public static void main() {
> System.out.println("main called!");
> }
> }
>
> and compile and run it, with preview enabled, like:
>
> $ jav
On Wed, 17 Apr 2024 06:34:25 GMT, Jan Lahoda wrote:
>> Consider code like:
>>
>> public class MainClass {
>> public MainClass() {
>> System.out.println("Constructor called!");
>> }
>> public static void main() {
>> System.out.println("main called!");
>> }
>> }
>>
68 matches
Mail list logo