After PR #16245, C2 optimizes stores into primitive arrays by combining values
into larger stores. In the UUID.toString method, ByteArrayLittleEndian can be
removed, making the code more elegant and faster.
-
Commit messages:
- optimization for UUID toString
Changes:
On Sat, 8 Jun 2024 00:19:55 GMT, Shaojin Wen wrote:
> After PR #16245, C2 optimizes stores into primitive arrays by combining
> values into larger stores. In the UUID.toString method,
> ByteArrayLittleEndian can be removed, making the code more elegant and faster.
The performance numbers
On Fri, 7 Jun 2024 22:16:36 GMT, Joe Darcy wrote:
>> Use the value tag to make the javadoc for various format-related constants
>> more informative to readers. Currently the information is available by
>> following the "Constant Field Values" link.
>>
>> I'll reflow the paragraphs before a
> Use the value tag to make the javadoc for various format-related constants
> more informative to readers. Currently the information is available by
> following the "Constant Field Values" link.
>
> I'll reflow the paragraphs before a push.
Joe Darcy has updated the pull request incrementally
On Fri, 7 Jun 2024 13:56:24 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method
On Fri, 7 Jun 2024 21:05:33 GMT, Joe Darcy wrote:
> Use the value tag to make the javadoc for various format-related constants
> more informative to readers. Currently the information is available by
> following the "Constant Field Values" link.
>
> I'll reflow the paragraphs before a push.
On Fri, 7 Jun 2024 21:05:33 GMT, Joe Darcy wrote:
> Use the value tag to make the javadoc for various format-related constants
> more informative to readers. Currently the information is available by
> following the "Constant Field Values" link.
>
> I'll reflow the paragraphs before a push.
On Fri, 7 Jun 2024 20:56:03 GMT, Daniel Jeliński wrote:
>> I think waiting on JVM_GetThreadInterruptEvent() is necessary during VM
>> shutdown to allow the blocked thread to exit cleanly.
>
> Interesting. Could you point me to a related bug / documentation / evidence?
> I tested the
Use the value tag to make the javadoc for various format-related constants more
informative to readers. Currently the information is available by following the
"Constant Field Values" link.
I'll reflow the paragraphs before a push.
-
Commit messages:
- JDK-8333828: Use value
On Fri, 7 Jun 2024 20:52:38 GMT, Daniel Jeliński wrote:
>> The `WaitForSingleObject(handle, 0)` seems like an indirect way to determine
>> if the process is alive.
>> Whereas `isProcessAlive(handle)` seems to directly answer the question.
>
> sorry, I still don't get it. Are you telling me that
On Fri, 7 Jun 2024 20:36:45 GMT, Roger Riggs wrote:
>> I only left it here because the wait for interrupt event was already
>> present. Is being stuck in a blocking os call a bad thing? If not, I can
>> drop the interrupt event, and wait on the process handle only.
>
> I think waiting on
On Fri, 7 Jun 2024 20:35:00 GMT, Roger Riggs wrote:
>> I don't follow. Could you explain?
>
> The `WaitForSingleObject(handle, 0)` seems like an indirect way to determine
> if the process is alive.
> Whereas `isProcessAlive(handle)` seems to directly answer the question.
sorry, I still don't
On Fri, 7 Jun 2024 16:05:06 GMT, Daniel Jeliński wrote:
>> src/java.base/windows/native/libjava/ProcessHandleImpl_win.c line 128:
>>
>>> 126: JNU_ThrowByNameWithLastError(env,
>>> 127: "java/lang/RuntimeException",
>>> "WaitForMultipleObjects");
>>> 128: }
On Fri, 7 Jun 2024 18:47:53 GMT, Claes Redestad wrote:
>> Note that [`ConstantBootstraps::primitiveClass(Lookup, String, Class)`]
>> has a static return type of `Class<?>`, so the following is also needed:
>>
>> /**
>> * Exact type used of the {@link
On Fri, 7 Jun 2024 13:56:24 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method
On Fri, 7 Jun 2024 13:46:22 GMT, Jorn Vernee wrote:
> As an aside: I suppose we pre-generate all the linkers that get spun up for
> these `invokeExact`calls already. But, we might still get a little bit of
> mileage out of switching to `invokeBasic`, which bypasses the linkers
> altogether.
> This PR refactors type matching in BootstrapMethodInvoker and adds a few
> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
> in particular the ProxyGenerator condys generated for e.g. annotation proxies
> since
On Fri, 7 Jun 2024 18:38:52 GMT, ExE Boss wrote:
>> src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java
>> line 289:
>>
>>> 287: * bootstrap method.
>>> 288: */
>>> 289: private static final MethodType CONDY_GET_STATIC_FINAL_MT =
>>>
On Wed, 24 Jan 2024 00:26:09 GMT, Joshua Cao wrote:
> Add notes for `HashMap::putAll()` conservative resizing.
>
> Note: everything below this line is from the original change. After
> discussion, we decided to keep the conservative resizing, but we should add
> an `@implNote` for the
On Fri, 7 Jun 2024 13:45:42 GMT, Chen Liang wrote:
>> This PR refactors type matching in BootstrapMethodInvoker and adds a few
>> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
>> in particular the ProxyGenerator condys generated for e.g. annotation
>> proxies
On Fri, 7 Jun 2024 13:56:24 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method
> On 6 Jun 2024, at 18:37, David Lloyd wrote:
>
> Just bumping this one more time. I intend to start by opening a JIRA to add
> the two proposed methods to `ReflectionFactory`, and go from there. I guess
> that we might need a JEP for the proposed serialization restrictions, which
> is going
On Tue, 21 Nov 2023 00:06:19 GMT, Scott Gibbons wrote:
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> Benchmark
On Mon, 20 May 2024 18:08:31 GMT, Naoto Sato wrote:
> This test intends to verify the behavior of JdkConsole for the java.base
> module, wrt restoring the echo. The test assumes the internal methods that
> sets/gets the echo status of the platform.
This pull request has now been integrated.
On Thu, 6 Jun 2024 21:49:35 GMT, Naoto Sato wrote:
>> This test intends to verify the behavior of JdkConsole for the java.base
>> module, wrt restoring the echo. The test assumes the internal methods that
>> sets/gets the echo status of the platform.
>
> Naoto Sato has updated the pull request
On Fri, 7 Jun 2024 14:58:30 GMT, Roger Riggs wrote:
>> `GetExitCodeProcess` method is not reliable for checking if a process exited
>> already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
>> the same value is returned when the process exited with code 259. In order
>>
On Wed, 5 Jun 2024 19:21:56 GMT, Jorn Vernee wrote:
> These 4 tests were failing due to an incompatibility with jcstress. They were
> problemlisted in past (https://bugs.openjdk.org/browse/JDK-8326062).
>
> Now that jcstress has been updated
> (https://github.com/openjdk/jdk/pull/19332) with
On Thu, 6 Jun 2024 18:40:51 GMT, Daniel Jeliński wrote:
> `GetExitCodeProcess` method is not reliable for checking if a process exited
> already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
> the same value is returned when the process exited with code 259. In order to
On Fri, 7 Jun 2024 13:08:24 GMT, Claes Redestad wrote:
>> Trivially move a few private static finals to their respective source type
>> to avoid eagerly loading a few small classes.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last
On Fri, 7 Jun 2024 08:21:58 GMT, Claes Redestad wrote:
> Trivially move a few private static finals to their respective source type to
> avoid eagerly loading a few small classes.
This pull request has now been integrated.
Changeset: d744059b
Author:Claes Redestad
URL:
On Wed, 5 Jun 2024 19:21:56 GMT, Jorn Vernee wrote:
> These 4 tests were failing due to an incompatibility with jcstress. They were
> problemlisted in past (https://bugs.openjdk.org/browse/JDK-8326062).
>
> Now that jcstress has been updated
> (https://github.com/openjdk/jdk/pull/19332) with
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last
On Fri, 7 Jun 2024 13:56:24 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method
> In java.base, especially in bytecode generators, we have many different
> methods converting known valid Class and MethodType into ClassDesc and
> MethodTypeDesc. These conversions should be consolidated into the same
> utility method for the ease of future maintenance.
Chen Liang has
On Fri, 7 Jun 2024 12:12:44 GMT, Claes Redestad wrote:
> This PR refactors type matching in BootstrapMethodInvoker and adds a few
> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
> in particular the ProxyGenerator condys generated for e.g. annotation proxies
>
On Fri, 7 Jun 2024 12:12:44 GMT, Claes Redestad wrote:
> This PR refactors type matching in BootstrapMethodInvoker and adds a few
> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
> in particular the ProxyGenerator condys generated for e.g. annotation proxies
>
On Fri, 7 Jun 2024 13:08:24 GMT, Claes Redestad wrote:
>> Trivially move a few private static finals to their respective source type
>> to avoid eagerly loading a few small classes.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last
On Fri, 7 Jun 2024 12:12:44 GMT, Claes Redestad wrote:
> This PR refactors type matching in BootstrapMethodInvoker and adds a few
> types, seeking to improve bootstrap overheads of some ConstantBootstraps and
> in particular the ProxyGenerator condys generated for e.g. annotation proxies
>
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
This pull request has now been integrated.
Changeset: d130d2f4
Author:SendaoYan
Committer: Julian
On Fri, 7 Jun 2024 13:01:15 GMT, SendaoYan wrote:
>> As confusing as they are, unfortunately GitHub UI does not render extra
>> trailing newlines. This is the only one I could find with grepWin.
>
> I find the extra trailing newlines through below shell command:
>
> for i in `find . -iname
On Thu, 6 Jun 2024 10:48:51 GMT, Aleksey Shipilev wrote:
>> These 4 tests were failing due to an incompatibility with jcstress. They
>> were problemlisted in past (https://bugs.openjdk.org/browse/JDK-8326062).
>>
>> Now that jcstress has been updated
>>
On Fri, 7 Jun 2024 12:35:37 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method
> Trivially move a few private static finals to their respective source type to
> avoid eagerly loading a few small classes.
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Update
On Fri, 7 Jun 2024 04:47:12 GMT, Joe Darcy wrote:
> Misc small doc updates and addition of `@Overrides` annotations.
src/java.base/share/classes/java/lang/Double.java line 595:
> 593: * This method corresponds to the convertToDecimalCharacter
> 594: * operation defined in IEEE 754.
>
On Fri, 7 Jun 2024 12:53:46 GMT, Chen Liang wrote:
>> No, it's an extra newline. A file should end with a newline but one is
>> enough.
>
> As confusing as they are, unfortunately GitHub UI does not render extra
> trailing newlines. This is the only one I could find with grepWin.
I find the
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu limits by means of the cgroup filesystem. If neither of
On Fri, 7 Jun 2024 12:38:24 GMT, Claes Redestad wrote:
>> Trivially move a few private static finals to their respective source type
>> to avoid eagerly loading a few small classes.
>
> Claes Redestad has updated the pull request incrementally with two additional
> commits since the last
On Fri, 7 Jun 2024 12:47:39 GMT, Erik Joelsson wrote:
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile line 50:
>>
>>> 48: clean:
>>> 49: rm -f *.class .classes
>>> 50:
>>
>> Hmm, shouldn't this newline at EOF be kept? Asking @ all the people who've
>> reviewed this so far,
On Fri, 7 Jun 2024 12:37:48 GMT, Julian Waters wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
>
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last
On Fri, 7 Jun 2024 07:26:39 GMT, SendaoYan wrote:
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile line 1:
>>
>>> 1: #
>>
>> This file change is dubious:
>> 1. It does not have any trailing whitespace that can fail the skara checks.
>> 2. If the duplicate blank lines in the end of
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last
> Trivially move a few private static finals to their respective source type to
> avoid eagerly loading a few small classes.
Claes Redestad has updated the pull request incrementally with two additional
commits since the last revision:
- revert typo
- Copyright
-
Changes:
-
> In java.base, especially in bytecode generators, we have many different
> methods converting known valid Class and MethodType into ClassDesc and
> MethodTypeDesc. These conversions should be consolidated into the same
> utility method for the ease of future maintenance.
Chen Liang has
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last
> In java.base, especially in bytecode generators, we have many different
> methods converting known valid Class and MethodType into ClassDesc and
> MethodTypeDesc. These conversions should be consolidated into the same
> utility method for the ease of future maintenance.
Chen Liang has
This PR refactors type matching in BootstrapMethodInvoker and adds a few types,
seeking to improve bootstrap overheads of some ConstantBootstraps and in
particular the ProxyGenerator condys generated for e.g. annotation proxies
since [JDK-8332457](https://bugs.openjdk.org/browse/JDK-8332457)
On Thu, 6 Jun 2024 21:49:35 GMT, Naoto Sato wrote:
>> This test intends to verify the behavior of JdkConsole for the java.base
>> module, wrt restoring the echo. The test assumes the internal methods that
>> sets/gets the echo status of the platform.
>
> Naoto Sato has updated the pull request
On Wed, 5 Jun 2024 13:45:46 GMT, Per Minborg wrote:
>> As a note, If we would have access to the contemplated `StableValue` and
>> `hash` was declared even as an _instance variable_ `StableValue` in
>> a regular class, then it would be trusted and would be eligible for constant
>> folding due
On Fri, 7 Jun 2024 08:21:58 GMT, Claes Redestad wrote:
> Trivially move a few private static finals to their respective source type to
> avoid eagerly loading a few small classes.
Remember to update the copyright year.
-
Marked as reviewed by liach (Author).
PR Review:
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last
`GetExitCodeProcess` method is not reliable for checking if a process exited
already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
the same value is returned when the process exited with code 259. In order to
check if the process exited, we need to check if its handle is
On Thu, 6 Jun 2024 21:44:59 GMT, Chen Liang wrote:
>> In java.base, especially in bytecode generators, we have many different
>> methods converting known valid Class and MethodType into ClassDesc and
>> MethodTypeDesc. These conversions should be consolidated into the same
>> utility method
On Wed, 5 Jun 2024 12:39:13 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> An assortment of potential improvements
>>
>> Co-authored-by: Claes Redestad
>
>
Trivially move a few private static finals to their respective source type to
avoid eagerly loading a few small classes.
-
Commit messages:
- 8333774: Avoid eagerly loading various EmptySpliterator classes
Changes: https://git.openjdk.org/jdk/pull/19591/files
Webrev:
On Thu, 6 Jun 2024 19:12:35 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 469:
>>
>>> 467: // o instanceof Wrapped(float)
>>> 468: cb.aload(SELECTOR_OBJ);
>>> 469:
On Thu, 6 Jun 2024 17:49:08 GMT, Chen Liang wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
>
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
SendaoYan has updated the pull request incrementally with one additional commit
since the last revision:
delete extra empty trailing blank line in
On Thu, 6 Jun 2024 21:21:23 GMT, David Holmes wrote:
>> ### Summary
>> This change ensures we don't get undefined behavior when
>> calling[`isspace`](https://pubs.opengroup.org/onlinepubs/007904975/functions/isspace.html).
>> `isspace` accepts an `int` argument that "the application shall
69 matches
Mail list logo
