On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>>
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementat
On Thu, 4 Aug 2022 18:10:18 GMT, Alex Kasko wrote:
> This change adds `ContextMenuCommandLabel` l10n property for file association
> context menu label. It is a follow-up to [this PR
> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>
> Note, non
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>>
On Mon, 8 Aug 2022 19:52:41 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>&g
On Wed, 10 Aug 2022 13:12:57 GMT, Alex Kasko wrote:
>> This change is a follow-up to [this
>> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>>
>>
> `.wxl` files
> - [x] ran jtreg:jdk/tools/jpackage/windows and a `BasicTest` in unpack mode
Alex Kasko has updated the pull request incrementally with one additional
commit since the last revision:
fixes for bundling with different cultures
-
Changes:
- all: https://git.openjdk.org/
On Mon, 8 Aug 2022 21:04:49 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 37:
>>
>>> 35: resource.post-app-image-script=script to run after application image is
>>> populated
>>> 36:
> `.wxl` files
> - [x] ran jtreg:jdk/tools/jpackage/windows and a `BasicTest` in unpack mode
Alex Kasko has updated the pull request incrementally with one additional
commit since the last revision:
add english entries to all l10n files
-
Changes:
- all: https://git.openjdk.org/jdk/pu
or and may need to be
> corrected.
>
> To check the contents of the label, registry query is added to
> `PackageTest::addHelloAppFileAssociationsVerifier`.
>
> Testing:
>
> - [x] ran `FileAssociationsTest` with `install` enabled
Alex Kasko has updated the pull request incremen
On Fri, 5 Aug 2022 17:04:54 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>&g
On Fri, 5 Aug 2022 16:14:35 GMT, Alex Kasko wrote:
> This change is a follow-up to [this
> comment](https://bugs.openjdk.org/browse/JDK-8290519?focusedCommentId=14512038=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14512038).
>
> Override implementat
On Fri, 5 Aug 2022 17:04:54 GMT, Alex Kasko wrote:
>> This change adds `ContextMenuCommandLabel` l10n property for file
>> association context menu label. It is a follow-up to [this PR
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>&g
On Thu, 4 Aug 2022 20:30:00 GMT, Alexey Semenyuk wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reg method access, drop l10n entries, label check enhancement
>
> test/jdk/tools/jpac
or and may need to be
> corrected.
>
> To check the contents of the label, registry query is added to
> `PackageTest::addHelloAppFileAssociationsVerifier`.
>
> Testing:
>
> - [x] ran `FileAssociationsTest` with `install` enabled
Alex Kasko has updated the pull request incremen
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote:
> This change splits existing single Feature `DefaultFeature` into 3 different
> feautures:
>
> - `DefaultFeature_Files`: application and runtime files
> - `DefaultFeature_Shortcuts`: application Desktop and Start
This change adds `ContextMenuCommandLabel` l10n property for file association
context menu label. It is a follow-up to [this PR
comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
Note, non-EN l10n values were filled using auto-translator and may need to be
corrected.
This change splits existing single Feature `DefaultFeature` into 3 different
feautures:
- `DefaultFeature_Files`: application and runtime files
- `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts
- `DefaultFeature_FileAssociations`: File Association components
These 3
On Mon, 18 Jul 2022 22:33:15 GMT, Alex Kasko wrote:
> It is proposed to introduce support for `--win-codepage` argument, and
> substitute the `Codepage` attribute with `--win-codepage` specified value in
> primary l10n file when it is being copied to the config dir.
>
> Instead
[x] ran `jtreg:jdk/tools/jpackage`
> - [x] test for `--win-codepage` argument is included with the patch
Alex Kasko has updated the pull request incrementally with two additional
commits since the last revision:
- extend the test to cover utf-8 codepage
- new argument description in --help o
On Mon, 18 Jul 2022 22:33:15 GMT, Alex Kasko wrote:
> It is proposed to introduce support for `--win-codepage` argument, and
> substitute the `Codepage` attribute with `--win-codepage` specified value in
> primary l10n file when it is being copied to the config dir.
>
> Instead
It is proposed to introduce support for `--win-codepage` argument, and
substitute the `Codepage` attribute with `--win-codepage` specified value in
primary l10n file when it is being copied to the config dir.
Instead of copying all internal l10n files, it is proposed to copy only the
primary
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote:
> jpackage implementation of file association on Windows currently passes a
> selected filename as an only argument to associated executable.
>
> It is proposed to introduce additional option in file association property
>
On Thu, 30 Jun 2022 18:50:23 GMT, Alexey Semenyuk wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> drop pass-all-args property
>
> test/jdk/tools/jpackage/share/FileAssociation
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association pr
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association pr
sts) in a final version.
>
> Testing:
>
> - [x] test to cover new logic is included
> - [x] ran jtreg:jdk/tools/jpackage with no new failures
Alex Kasko has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
On Tue, 28 Jun 2022 21:38:50 GMT, Alexey Semenyuk wrote:
> The existing behavior simply cuts off all, but the first argument from the
> argument array passed to the app launcher. Changing this looks more like a
> fix of a bug, than an enhancement. I'd keep it simple: replace the value of
>
On Tue, 28 Jun 2022 21:38:50 GMT, Alexey Semenyuk wrote:
> > I assume we will need an additional similar property for a verb label
> > displayed in a context menu.
>
> Agree. At least we need to provide l10n for it.
For runtime installers it would be great to have a custom verb label, to be
sts) in a final version.
>
> Testing:
>
> - [x] test to cover new logic is included
> - [x] ran jtreg:jdk/tools/jpackage with no new failures
Alex Kasko has updated the pull request incrementally with one additional
commit since the last revision:
drop pass-all-args property
On Mon, 27 Jun 2022 17:53:29 GMT, Alexey Semenyuk wrote:
> What would be the alternative to `pass-all-args`?
As this is intended to be a public property, I assume there should be a CSR and
some consistent name, perhaps with `win-` prefix - I assume we will need an
additional similar property
On Mon, 27 Jun 2022 17:57:53 GMT, Alexey Semenyuk wrote:
>> Alex Kasko has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use shortcut to test arguments, add argument with spaces
>
> src/jdk.jpackage/windows
sts) in a final version.
>
> Testing:
>
> - [x] test to cover new logic is included
> - [x] ran jtreg:jdk/tools/jpackage with no new failures
Alex Kasko has updated the pull request incrementally with one additional
commit since the last revision:
use shortcut to test
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parse
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parse
Please review this minor fix to the jpackage test suite.
When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite runs
(disabled by default), installation of `EXE` and `MSI` packages is performed.
`EXE` package is invoked directly and `MSI` package is installed using
jpackage implementation of file association on Windows currently passes a
selected filename as an only argument to associated executable.
It is proposed to introduce additional option in file association property file
to allow optionally support additional arguments using `%*` batch wildcard.
39 matches
Mail list logo
