Integrated: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags

2023-12-14 Thread Darragh Clarke
On Mon, 4 Dec 2023 10:39:05 GMT, Darragh Clarke wrote: > Updated tests to use vm.flagless as they already ignore Vm flags This pull request has now been integrated. Changeset: 62b7c5ea Author: Darragh Clarke URL: https://git.openjdk.org/jdk/com

RFR: 8319647: Update or mark as vm.flagless tests that ignore external VM flags

2023-12-04 Thread Darragh Clarke
Updated tests to use vm.flagless as they already ignore Vm flags - Commit messages: - ignore vm flags Changes: https://git.openjdk.org/jdk/pull/16946/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16946=00 Issue: https://bugs.openjdk.org/browse/JDK-8319647 Stats: 14 lines

Integrated: 8317834: java/lang/Thread/IsAlive.java timed out

2023-11-17 Thread Darragh Clarke
On Tue, 14 Nov 2023 16:41:31 GMT, Darragh Clarke wrote: > Currently the `IsAlive` test occasionally times out. > > This PR changes the timeout from `10` to `25` which I think is an adequate > increase based on the failures I've seen. Though I'd be happy to change it to >

Re: RFR: 8317834: java/lang/Thread/IsAlive.java timed out [v2]

2023-11-14 Thread Darragh Clarke
> Currently the `IsAlive` test occasionally times out. > > This PR changes the timeout from `10` to `25` which I think is an adequate > increase based on the failures I've seen. Though I'd be happy to change it to > another value if someone thinks `25` isn't ideal. Darragh Cla

RFR: 8317834: java/lang/Thread/IsAlive.java timed out

2023-11-14 Thread Darragh Clarke
Currently the `IsAlive` test occasionally times out. This PR changes the timeout from `10` to `25` which I think is an adequate increase based on the failures I've seen. Though I'd be happy to change it to another value if someone thinks `25` isn't ideal. - Commit messages: -

Integrated: 7065228: To interpret case-insensitive string locale independently

2023-05-22 Thread Darragh Clarke
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote: > Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3 with no is

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-22 Thread Darragh Clarke
On Fri, 19 May 2023 11:24:30 GMT, Michael McMahon wrote: > Seems like a useful change and I can see how issues could arise if strings > were stored somewhere after being upper/lower cased and then reused in a > different locale. > > Is it correct to say that the assumption is these strings

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-17 Thread Darragh Clarke
On Wed, 17 May 2023 10:41:57 GMT, Daniel JeliƄski wrote: >> Darragh Clarke has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update >> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthe

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-17 Thread Darragh Clarke
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3 with no issues Darragh Clarke has updated the pull request increme

RFR: 7065228: To interpret case-insensitive string locale independently

2023-05-16 Thread Darragh Clarke
Updated instances of `toLowerCase` and `toUpperCase` in several net and io files to specify `Locale.ROOT` to ensure that case conversion issues don't occur, I didn't add any new tests but ran tier 1-3 with no issues - Commit messages: - added some case conversions missed

Integrated: 8286394: Address possibly lossy conversions in jdk.naming.dns

2022-10-07 Thread Darragh Clarke
On Fri, 7 Oct 2022 14:14:13 GMT, Darragh Clarke wrote: > Added an int cast for the `timeoutLeft` assignment, looking through the code > and other uses of the variable it seems to show no issues with lossy > conversion. As part of this I removed the file to disable the conversion

RFR: 8286394: Address possibly lossy conversions in jdk.naming.dns

2022-10-07 Thread Darragh Clarke
Added an int cast for the `timeoutLeft` assignment, looking through the code and other uses of the variable it seems to show no issues with lossy conversion. As part of this I removed the file to disable the conversion warning I tested this build and it doesn't give any warnings on this file