On Wed, 21 Sep 2022 09:23:31 GMT, Alan Bateman wrote:
> > Assuming we are set with the other changes, did you want to add the
> > following paragraph (or similar) at line 58 to make it clear that if the
> > Manifest is not found, then the JarEntry attributes will not be available:
>
> This is
On Tue, 20 Sep 2022 17:47:03 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
On Tue, 20 Sep 2022 17:53:27 GMT, Sean Mullan wrote:
> Now that this API has a section about signed JARs, I think it is very
> important to include the following sentences which are copied from `JarFile`:
>
> "Please note that the verification process does not include validating the
>
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Added the verification note from JarFile
-
Changes:
- all: https://git.op
On Tue, 20 Sep 2022 17:37:50 GMT, Alan Bateman wrote:
>>> > OK, will make another pass at this today
>>>
>>> I looked at the latest draft
>>> ([2bafc00](https://github.com/openjdk/jdk/commit/2bafc00cc462b7af3f724371ac1bef5fd99c989c)).
>>> I think it would help if the section "Verifying a
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
More wordsmithing to the signed jar section
-
Changes:
- all: https://git.op
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address comments regarding Verifying a JarInputStreams
-
Changes:
- all: ht
On Mon, 19 Sep 2022 20:30:48 GMT, Weijun Wang wrote:
> Does this mean that the "Verifying a JarInputStream" should also avoid
> mentioning "getManifest method returns the manifest"? I understand precisely
> it should be "getManifest method is able to return the manifest if you call
> it".
On Tue, 20 Sep 2022 06:56:49 GMT, Alan Bateman wrote:
>>> I realise you've had a few iterations with Max on this section but I'm
>>> concerned that the text is telling the reader that they should use the
>>> 2-arg constructor to verify the signatures when a JAR is signed. The
>>> default is
On Mon, 19 Sep 2022 19:26:53 GMT, Sean Mullan wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor clarification for verifying an JarInputStream
>
> src/java.base/share/classes/jav
On Mon, 19 Sep 2022 20:04:18 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address Sean's input
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Mon, 19 Sep 2022 06:34:00 GMT, Alan Bateman wrote:
> > I can remove, but I am not sure I agree we need to describe main vs
> > attribute here given we are pointing to the Jar spec and if there is any
> > discussion of Pre-entry attributes, it should be in JarEntry IMHO. I guess
> > the
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Minor clarification for verifying an JarInputStream
-
Changes:
- all: https://
On Mon, 19 Sep 2022 06:45:13 GMT, Alan Bateman wrote:
> I realise you've had a few iterations with Max on this section but I'm
> concerned that the text is telling the reader that they should use the 2-arg
> constructor to verify the signatures when a JAR is signed. The default is to
> verify
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Updated to address latest feedback
-
Changes:
- all: https://git.openjdk.or
On Sun, 18 Sep 2022 19:49:51 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Incorporated latest round of input
>
> src/java.base/share/classes/java/util/j
On Sat, 17 Sep 2022 08:05:37 GMT, Alan Bateman wrote:
> It's a bit better but I think we can make it clearer and also link the JAR
> Manifest section of the JAR file spec. Can you try this:
>
> ```
> * The {@link #getManifest() getManifest} method is used to read the
> * JAR Manifest
> *
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Incorporated latest round of input
-
Changes:
- all: https://git.openjdk.or
On Wed, 31 Aug 2022 16:06:57 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this update to the ZipInputStream class description to clarify
> that ZipInputStream walks sequentially through each Zip Entry contained
> within the Zip File. As a result, the CEN header for the Z
On Fri, 16 Sep 2022 18:01:40 GMT, Alan Bateman wrote:
> Okay, in which case what would you think about just saying that the
> getNextEntry/getNextJarEntry method do not return the Manifest when it's at
> the start of the stream, and it's unspecified whether they return the
> Manifest when it
On Fri, 16 Sep 2022 13:06:28 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address latest input regarding wording
>
> src/java.base/share/classes/java/util/j
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address additional javadoc comments
-
Changes:
- all: https://git.openjdk.or
tStream not having access to information
> that is stored within the CEN Header fields such the as the external file
> attributes which can be used to store optional data such as Posix Permissions.
Lance Andersen has updated the pull request incrementally with one additional
commit
On Wed, 14 Sep 2022 11:57:17 GMT, Alan Bateman wrote:
> One other comment on the snippet is that the type of "jar" may not be obvious
> to readers. I think you'll need Path jar = ... in which case changing it
> Files.newInputStream(jar) might be simpler.
Updated per your suggestion
> I
tStream not having access to information
> that is stored within the CEN Header fields such the as the external file
> attributes which can be used to store optional data such as Posix Permissions.
Lance Andersen has updated the pull request incrementally with one additional
commit since the
On Wed, 14 Sep 2022 12:53:12 GMT, Alan Bateman wrote:
> I think you can insert a comma after "when it is the first entry in the
> stream"? I think that would make it a bit clearer that there are two cases.
Done
>
> Also I'm wondering if the paragraph should be split into two, meaning "When
>
On Wed, 14 Sep 2022 15:53:41 GMT, Weijun Wang wrote:
> I have no more comment.
Thank you Max for your time and input
-
PR: https://git.openjdk.org/jdk/pull/10045
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address latest input regarding wording
-
Changes:
- all: https://git.openjdk.or
On Wed, 14 Sep 2022 02:22:17 GMT, Weijun Wang wrote:
> Only tiny comments for the last paragraph.
Thank you Max, I addressed the above
>
> That said, I have some questions on the other parts of this file:
>
> 1. In `getNextEntry`, the method spec says "If verification has been
> enabled,
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address a couple of typos in Note
-
Changes:
- all: https://git.openjdk.or
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
changed linkplain to link and updated note wording
-
Changes:
- all: https://
On Wed, 14 Sep 2022 00:39:37 GMT, Weijun Wang wrote:
> On lines 36 and 37, there are two "Manifest". The first uses `linkplain` so
> it's using normal font style, the 2nd uses `code` so it's fixed-width. I
> would like them to be the same. In fact, I would not use `linkplain` at all.
> I only
tStream not having access to information
> that is stored within the CEN Header fields such the as the external file
> attributes which can be used to store optional data such as Posix Permissions.
Lance Andersen has updated the pull request incrementally with one additional
commit since the
On Tue, 13 Sep 2022 20:39:31 GMT, Weijun Wang wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this update,
On Fri, 26 Aug 2022 15:48:55 GMT, Lance Andersen wrote:
> Please review this PR which updates the JarInputStream class description to
> clarify when the Manifest is accessible via JarInputStream::getManifest and
> JarInputStream::get[Jar]Entry.
>
> It is worth noting that w
tStream not having access to information
> that is stored within the CEN Header fields such the as the external file
> attributes which can be used to store optional data such as Posix Permissions.
Lance Andersen has updated the pull request incrementally with one additional
commit
On Tue, 13 Sep 2022 19:30:01 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address sample indentation and typo
>
> src/java.base/share/classes/java/util/z
On Tue, 13 Sep 2022 17:38:29 GMT, Brian Burkhalter wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address sample indentation and typo
>
> src/java.base/share/classes/java/util/z
tStream not having access to information
> that is stored within the CEN Header fields such the as the external file
> attributes which can be used to store optional data such as Posix Permissions.
Lance Andersen has updated the pull request incrementally with one additional
commit
Hi,
Please review this update to the ZipInputStream class description to clarify
that ZipInputStream walks sequentially through each Zip Entry contained within
the Zip File. As a result, the CEN header for the Zip file entries are not
read resulting in ZipInputStream not having access to
On Fri, 2 Sep 2022 14:50:32 GMT, Alan Bateman wrote:
>> I could do tweak further to say:
>>
>> _`getManifest()` will return the Manifest if it is the first entry or
>> META-INF/ is the first entry and the Manifest is the second entry within the
>> Jar file. When the Manifest is returned by
On Thu, 1 Sep 2022 13:53:05 GMT, Weijun Wang wrote:
> It's better. Do you need to explicitly say "For all other cases"?
I thought it is worth being specific, but happy to leave it out if you and
others prefer
>
> My original comment was more about explaining `getManifest()` and
>
On Thu, 1 Sep 2022 17:27:23 GMT, Lance Andersen wrote:
>> It's better. Do you need to explicitly say "For all other cases"?
>>
>> My original comment was more about explaining `getManifest()` and
>> `getNextEntry()` in the same if. It's still doable.
>
>
On Wed, 31 Aug 2022 19:13:05 GMT, Weijun Wang wrote:
>> The challenge I had with the wording is due to the fact that if "META-INF/"
>> is the first entry in the Zip file, it will not be returned regardless of
>> whether there is a manifest. So open to suggestions.
>
> That's right. But I
On Tue, 30 Aug 2022 21:47:03 GMT, Weijun Wang wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this update,
Please review this PR which updates the JarInputStream class description to
clarify when the Manifest is accessible via JarInputStream::getManifest and
JarInputStream::get[Jar]Entry.
It is worth noting that with this update, we are finally documenting behavior
that dates back to when this
On Thu, 1 Sep 2022 08:12:13 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Wed, 31 Aug 2022 17:08:28 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10103
On Mon, 29 Aug 2022 11:58:15 GMT, Volker Simonis wrote:
>> Add an API note to `InflaterInputStream::read(byte[] b, int off, int len)`
>> to highlight that it might write more bytes than the returned number of
>> inflated bytes into the buffer `b`.
>>
>> The superclass `java.io.InputStream`
On Sun, 21 Aug 2022 23:19:16 GMT, Naoto Sato wrote:
>> Fixing incorrect state handling with EOF in `StreamDecoder`. There's a
>> `reset()` call to the decoder seeing the EOF before the last `decode()`
>> operation to handle the state correctly. Removing the call should not affect
>> other
On Tue, 16 Aug 2022 17:34:58 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is
On Sat, 13 Aug 2022 06:10:42 GMT, Christian Stein wrote:
>> Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by
>> accept version information in JAR file names.
>>
>> Find details in https://bugs.openjdk.org/browse/JDK-8292182
>
> Christian Stein has updated the pull
On Fri, 12 Aug 2022 16:26:30 GMT, Christian Stein wrote:
> Enhance `JAXPPolicyManager` to setup required permissions for `jtreg` 7 by
> accept version information in JAR file names.
>
> Find details in https://bugs.openjdk.org/browse/JDK-8292182
Marked as reviewed by lancea (Reviewer).
On Wed, 3 Aug 2022 10:21:43 GMT, Lance Andersen wrote:
> Hi,
>
> Please review this patch to deflate.c which reverts an unintentional change
> that was part of JDK-8284371, which reverted the reworking of (7) deflate.c
> undo (6), replaced withe the official zlib repo fix s
On Wed, 10 Aug 2022 02:54:37 GMT, Jaikiran Pai wrote:
>> (This is a recreation of a previous pull request which had received some
>> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
>> personal branch and recreate it due to some git issues)
>>
>> Can I please get a
On Tue, 9 Aug 2022 09:36:28 GMT, Jaikiran Pai wrote:
> (This is a recreation of a previous pull request which had received some
> reviews https://github.com/openjdk/jdk/pull/9036. I had to delete that
> personal branch and recreate it due to some git issues)
>
> Can I please get a review of
On Mon, 1 Aug 2022 06:51:44 GMT, Andrey Turbanov wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
Marked as reviewed by lancea (Reviewer).
On Thu, 4 Aug 2022 06:59:27 GMT, Alan Bateman wrote:
> The revert looks okay but it is concerning that the original change was not
> caught by a test. Are there tests that could have caught this?
Not that I am aware of.
per open/src/java.base/share/native/libzip/zlib/patches/ChangeLog_java
Hi,
Please review this patch to deflate.c which reverts an unintentional change
that was part of JDK-8284371, which reverted the reworking of (7) deflate.c
undo (6), replaced withe the official zlib repo fix see#305/#f969409
Mach5 tiers1-3 have been run without failure
-
On Tue, 2 Aug 2022 17:08:05 GMT, Brian Burkhalter wrote:
>> For a `String` “s”, `s.indexOf(int)` can never return a value `>=
>> s.length()` so change the check
>>
>> int pos = syntaxAndInput.indexOf(':');
>> if (pos <= 0 || pos == syntaxAndInput.length())
>>
>> to
>>
>>
On Fri, 29 Jul 2022 02:38:25 GMT, Joe Wang wrote:
> Patch to make sure the Catalog is used even when the handler is null.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9682
On Thu, 21 Jul 2022 16:01:01 GMT, Roger Riggs wrote:
>> The `ProcessBuilder.pipelineStart()` implementation does not close all of
>> the file descriptors it uses to create the pipeline of processes.
>>
>> The process calling `pipelineStart()` is creating the pipes between the
>> stages.
>> As
On Wed, 13 Jul 2022 19:34:30 GMT, Joe Wang wrote:
> Update jcup.md with additional text at the end. Refer to
> http://www2.cs.tum.edu/projects/cup/licence.php.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/141
On Wed, 13 Jul 2022 05:31:27 GMT, Joe Wang wrote:
>> src/java.xml/share/legal/dom.md line 4:
>>
>>> 2:
>>> 3: ### W3C Software Notice
>>> 4:
>>
>> Since this is a markdown, should this be three back-ticks "```" instead of
>> "pre" HTML tag?
>
> Iris can probably comment on this. It's been
On Wed, 13 Jul 2022 00:04:24 GMT, Joe Wang wrote:
> Update dom.md, adding notice.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/138
On Fri, 8 Jul 2022 18:23:05 GMT, Joe Wang wrote:
> Update module-info
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/126
On Thu, 7 Jul 2022 17:32:45 GMT, Joe Wang wrote:
>> To improve efficiency, this patch moves the limit check to within the Lexer
>> and reports any overlimit situation as soon as it happens.
>>
>> Note the change in XPathParser: diff (and also webrevs) showed the whole
>> error-report block
On Wed, 6 Jul 2022 05:32:29 GMT, Daniel Jeliński wrote:
>> This patch removes many unused variables and one unused label reported by
>> the compilers when relevant warnings are enabled.
>>
>> The unused code was found by compiling after removing `unused` from the list
>> of disabled warnings
On Mon, 4 Jul 2022 19:30:50 GMT, Alan Bateman wrote:
> The updated TestDelegation test is looking a bit better now but I think it
> would be simplified a lot more by getting rid of the data providers, just
> aren't needed in this test.
Unless you feel this is a must, I would prefer to keep
; path, Class type, LinkOption... options)
>
>
> This change allows for providers to provide optimizations when the file's
> attributes are not needed.
>
> Mach5 tiers 1 - 3 run clean with this change
>
> The CSR may be viewed at
> [JDK-8283336](https://bugs.ope
Hi all,
This PR cleans up `VersionProps::print` removing the unused parameter `newln`.
Mach5 tiers1-3 are currently running.
Best,
Lance
-
Commit messages:
- Address unused parameter in VersionProps::print
Changes: https://git.openjdk.org/jdk/pull/9382/files
Webrev:
On Tue, 5 Jul 2022 10:56:45 GMT, Alan Bateman wrote:
> > Unless you feel this is a must, I would prefer to keep the DataProviders.
> > The benefit I see is the test code does not need to be duplicated per
> > parameter, each test scenario can be run as an individual test so that you
> > do
On Wed, 22 Jun 2022 19:05:41 GMT, Lance Andersen wrote:
> Hi,
>
> Please review the following patch which will:
>
> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
> the methods
>
> - public boolean exists(Path path, LinkOption.
; path, Class type, LinkOption... options)
>
>
> This change allows for providers to provide optimizations when the file's
> attributes are not needed.
>
> Mach5 tiers 1 - 3 run clean with this change
>
> The CSR may be viewed at
> [JDK-8283336](https://bugs.ope
; path, Class type, LinkOption... options)
>
>
> This change allows for providers to provide optimizations when the file's
> attributes are not needed.
>
> Mach5 tiers 1 - 3 run clean with this change
>
> The CSR may be viewed at
> [JDK-8283336](https://bugs.ope
On Wed, 29 Jun 2022 08:20:31 GMT, Andrey Turbanov wrote:
>> There is overload method HashMap.remove(key,value) which also checks value
>> equality.
>> It's shorter and faster than pair get+remove.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since
; path, Class type, LinkOption... options)
>
>
> This change allows for providers to provide optimizations when the file's
> attributes are not needed.
>
> Mach5 tiers 1 - 3 run clean with this change
>
> The CSR may be viewed at
> [JDK-8283336](https://bugs.ope
; path, Class type, LinkOption... options)
>
>
> This change allows for providers to provide optimizations when the file's
> attributes are not needed.
>
> Mach5 tiers 1 - 3 run clean with this change
>
> The CSR may be viewed at
> [JDK-8283336](https://bugs.ope
On Sun, 26 Jun 2022 13:13:35 GMT, Alan Bateman wrote:
> The implementation changes in latest version address my previous points,
> thanks! I don't the test as it duplicates most of the existing of the
> TestProvider in this directory and the naming is inconsistent with the
> existing tests. I
; path, Class type, LinkOption... options)
>
>
> This change allows for providers to provide optimizations when the file's
> attributes are not needed.
>
> Mach5 tiers 1 - 3 run clean with this change
>
> The CSR may be viewed at
> [JDK-8283336](https://bugs.ope
On Thu, 23 Jun 2022 10:55:00 GMT, Alan Bateman wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
On Wed, 22 Jun 2022 22:26:23 GMT, Brian Burkhalter wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> -
On Thu, 23 Jun 2022 08:05:42 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
On Wed, 22 Jun 2022 21:48:35 GMT, Joe Wang wrote:
>> Fix a regression in Document.normalizeDocument() caused by a change in JDK
>> 10.
>>
>> Test: new test (as in the bug report) and Tier2 passed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the
On Wed, 22 Jun 2022 19:22:50 GMT, Brian Burkhalter wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> -
Hi,
Please review the following patch which will:
- Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
the methods
- public boolean exists(Path path, LinkOption... options)
- public A readAttributesIfExists(Path path,
Class type, LinkOption... options)
This
On Tue, 21 Jun 2022 16:52:52 GMT, Joe Wang wrote:
> Some of the links cause redirection, iso.org in particular took 1-2 seconds,
> that looks like was longer than the wait time of the doccheck and docs link
> checker. Changed it to the current homepage to avoid redirection. Also
> changed
On Fri, 17 Jun 2022 16:33:16 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch for JDK 19 to address a broken link due to PKWare
> moving the location for APPNOTE.txt
>
> Best,
> Lance
This pull request has now been integrated.
Changeset: 453e8beb
Auth
On Fri, 17 Jun 2022 16:33:16 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch for JDK 19 to address a broken link due to PKWare
> moving the location for APPNOTE.txt
>
> Best,
> Lance
> I've never communicated with pkware, but this might be a goo
On Fri, 17 Jun 2022 16:55:50 GMT, Martin Buchholz wrote:
> I would change to the imperfect
> https://urldefense.com/v3/__https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT__;!!ACWV5N9M2RV99hQ!L1f8haAwUq1MetDxmR_stKKymXfm_VGE_xJ2TysCslYfBFNeeOKsTJNxGKCLYvCx5cH9SCYL47Qgd7XTqMZkrT8$
>
>
Hi all,
Please review this patch for JDK 19 to address a broken link due to PKWare
moving the location for APPNOTE.txt
Best,
Lance
-
Commit messages:
- Address broken linke for APPNOTE.txt
Changes: https://git.openjdk.org/jdk19/pull/35/files
Webrev:
501 - 592 of 592 matches
Mail list logo
