Re: [jdk19] RFR: 8289228: SegmentAllocator::allocateArray null handling is too lax [v2]

2022-06-27 Thread Paul Sandoz
On Mon, 27 Jun 2022 20:40:43 GMT, Maurizio Cimadamore wrote: >> Recent fix for JDK-8289188 relaxed behavior or >> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts >> null handling to what it used to be. > > Maurizio Cimadamore has updated the pull request

Re: RFR: 8288840: StructureViolationException should not link to fork method

2022-06-21 Thread Paul Sandoz
On Tue, 21 Jun 2022 11:20:49 GMT, Alan Bateman wrote: > StructureViolationException has a `@see` link to a fork method that does not > throw this exception. The link should be removed for JDK 19. We'll add the > link back once the JEP for Extent-Local Variables is integrated. Marked as

Re: RFR: 8288761: SegmentAllocator:allocate(long bytesSize) not throwing IAEx when bytesSize < 0

2022-06-21 Thread Paul Sandoz
On Mon, 20 Jun 2022 21:22:42 GMT, Maurizio Cimadamore wrote: > The various SegmentAllocator subclasses do not check for the constraints > mentioned in the javadoc. > This patch pulls the checks into a common routine in the Utils class, and > then call that check routine from all the

Re: RFR: 8288534: Out of bound errors for memory segment access mentions wrong values [v2]

2022-06-16 Thread Paul Sandoz
On Thu, 16 Jun 2022 12:16:19 GMT, Maurizio Cimadamore wrote: >> While playing with the API, I've realized that some of the out of bound >> error messgaes come out incorrectly. >> >> This is because the bound check is performed as follows (to avoid overflow): >> >> >>

Re: RFR: 8288425: Footprint regression due MH creation when initializing StringConcatFactory

2022-06-15 Thread Paul Sandoz
On Wed, 15 Jun 2022 21:30:24 GMT, Maurizio Cimadamore wrote: >> Avoid doing MH creation when initializing `StringConcatFactory` by lazily >> initializing to a `@Stable` field instead. > > src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line > 729: > >> 727:

Re: RFR: 8288534: Out of bound errors for memory segment access mentions wrong values

2022-06-15 Thread Paul Sandoz
On Wed, 15 Jun 2022 21:24:04 GMT, Maurizio Cimadamore wrote: > While playing with the API, I've realized that some of the out of bound error > messgaes come out incorrectly. > > This is because the bound check is performed as follows (to avoid overflow): > > > Objects.checkIndex(offset,

Integrated: 8288414: Long::compress/expand samples are not correct

2022-06-15 Thread Paul Sandoz
On Tue, 14 Jun 2022 16:28:37 GMT, Paul Sandoz wrote: > Update the code examples in the api notes of Long::compress/expand. Some > constants need to be explicitly long values. This pull request has now been integrated. Changeset: 395aea30 Author: Paul Sandoz URL:

<    1   2   3   4