Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-09 Thread ScientificWare
On Tue, 9 Aug 2022 08:38:26 GMT, Jaikiran Pai wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request conta

Integrated: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-08-09 Thread ScientificWare
On Mon, 4 Jul 2022 07:04:40 GMT, ScientificWare wrote: > This is tracked in JBS as > > [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by > [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) > > Unused imports in DTDBuider.java. > >&

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-09 Thread ScientificWare
On Tue, 9 Aug 2022 02:37:21 GMT, Jaikiran Pai wrote: >> Hello @jaikiran, the copyright years were updated by a previous commit. > > @scientificware, please issue the integrate command when you are ready and I > can sponsor this for you. In the meantime, I'll run some t

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-05 Thread ScientificWare
On Fri, 5 Aug 2022 07:56:40 GMT, Jaikiran Pai wrote: >> Just waiting to be reviewed. > > Hello @scientificware, what you propose here, I think looks fine. > Additionally can you also update the copyright years on this file from > `Copyright (c) 1998, 2020,` to `Copyri

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-05 Thread ScientificWare
util.zip.Deflater; > - java.net.URL; > > https://github.com/scientificware/jdk/issues/4 ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request conta

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-04 Thread ScientificWare
On Wed, 6 Jul 2022 23:56:33 GMT, ScientificWare wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by >> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) >> >> Unused imports in DTD

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-07-07 Thread ScientificWare
o.OutputStream; > - java.util.BitSet; > - java.util.StringTokenizer; > - java.util.Properties; > - java.util.zip.DeflaterOutputStream; > - java.util.zip.Deflater; > - java.net.URL; > > https://github.com/scientificware/jdk/issues/4 ScientificWare has updated the pul

Re: RFR: JDK-8289730 : Deprecated code sample in java.lang.ClassCastException

2022-07-06 Thread ScientificWare
On Mon, 4 Jul 2022 06:57:12 GMT, ScientificWare wrote: > - Correct a deprecated code. > - Update Copyright. > - More wide question : How are you dealing with deprecated codes in snippets ? > ``` > @deprecated(since="9") > public Integer​(int value

Integrated: JDK-8289730 : Deprecated code sample in java.lang.ClassCastException

2022-07-06 Thread ScientificWare
On Mon, 4 Jul 2022 06:57:12 GMT, ScientificWare wrote: > - Correct a deprecated code. > - Update Copyright. > - More wide question : How are you dealing with deprecated codes in snippets ? > ``` > @deprecated(since="9") > public Integer​(int value) > ```

RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-06 Thread ScientificWare
Set; - java.util.StringTokenizer; - java.util.Properties; - java.util.zip.DeflaterOutputStream; - java.util.zip.Deflater; - java.net.URL; - Commit messages: - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder - Merge branch 'openjdk:master' into scientificware-patch-001-DTDBuilder - Me

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-06 Thread ScientificWare
On Tue, 5 Jul 2022 11:34:05 GMT, Julian Waters wrote: >> Alright, was asking since I can help create one for you, but it seems that >> others already have it covered > >> @TheShermanTanker , thank you for asking and helping. >> >> > it seems that others already have it covered >> >> In fact,

RFR: JDK-8289730 : Deprecated code in src/java.base/share/classes/java/lang/ClassCastException.java

2022-07-05 Thread ScientificWare
- Correct a deprecated code. - Update Copyright. - More wide question : How are you dealing with deprecated codes in snippets ? ``` @deprecated(since="9") public Integer​(int value) ``` - Commit messages: - Merge branch 'openjdk:master' into patch-2 - Merge branch

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread ScientificWare
>> >> - java.io.FileNotFoundException; >> - java.io.BufferedInputStream; >> - java.io.OutputStream; >> - java.util.BitSet; >> - java.util.StringTokenizer; >> - java.util.Properties; >> - java.util.zip.DeflaterOutputStream; >> - java.util.zip.Deflater; >> - j

Re: RFR: JDK-8289730 : Deprecated code sample in java.lang.ClassCastException

2022-07-05 Thread ScientificWare
On Tue, 5 Jul 2022 17:27:03 GMT, Joe Darcy wrote: >> - Correct a deprecated code. >> - Update Copyright. >> - More wide question : How are you dealing with deprecated codes in snippets >> ? >> ``` >> @deprecated(since="9") >> public Integer​(int value) >> ``` > > Looks fine. > > There

Re: RFR: JDK-8289730 : Deprecated code in src/java.base/share/classes/java/lang/ClassCastException.java

2022-07-05 Thread ScientificWare
On Tue, 5 Jul 2022 17:27:03 GMT, Joe Darcy wrote: >> - Correct a deprecated code. >> - Update Copyright. >> - More wide question : How are you dealing with deprecated codes in snippets >> ? >> ``` >> @deprecated(since="9") >> public Integer​(int value) >> ``` > > Looks fine. > > There