On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote:
> Update to remove support for -source/-target/--release 7 from javac.
>
> As seen in the PR, many test fails are affected. Further refactorings of
> javac's implementation that can be made from dropping 7 support are left as
> future work.
l
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
looks good
-
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10924
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 04:04:36 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 04:04:36 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 15:14:05 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 516:
>>
>>> 514: Name name = TreeInfo.name(invoke.meth);
>>> 515: if (name == names._super) {
>>> 516: scanInitializers
On Fri, 13 Jan 2023 04:04:36 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 17:49:05 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 685:
>>
>>> 683:
>>> 684: @Override
>>> 685: public void visitDoLoop(JCDoWhileLoop tree) {
>>
>> I was thinking, code can also loop using
On Fri, 13 Jan 2023 19:09:54 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 19:09:54 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gene
On Fri, 13 Jan 2023 21:33:02 GMT, Archie L. Cobbs wrote:
>> Sounds good - thanks.
>
> Ah. I just realized that we need to do it your way because of the following
> bug:
>
> Suppose you have a constructor and a field with initializer that both leak,
> but you have `@SuppressWarnings("this-escap
On Tue, 21 Feb 2023 01:42:41 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Tue, 21 Feb 2023 01:42:41 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Fri, 24 Feb 2023 16:04:38 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Fri, 24 Feb 2023 16:04:38 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Fri, 24 Feb 2023 19:27:02 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2719:
>>
>>> 2717: * does not override any other methods (in which case site is
>>> responsible).
>>> 2718: */
>>> 2719: void checkPotentiallyAmbigu
On Fri, 24 Feb 2023 20:05:52 GMT, Archie L. Cobbs wrote:
>> I'm not saying that we should de-stream the code, actually we can do that
>> later on, in a separate issue, iff there is a performance related complain,
>> but it is true that in the past, I have seen some performance issues and the
>
On Fri, 24 Feb 2023 18:09:16 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Fri, 24 Feb 2023 18:09:16 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Sat, 25 Feb 2023 03:57:30 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Sat, 25 Feb 2023 03:57:30 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Sat, 25 Feb 2023 16:03:39 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 2765:
>>
>>> 2763: * any other methods; in this case the class is definitely
>>> responsible.
>>> 2764: */
>>> 2765: BiPredicate
>>> buildResponsib
On Sat, 25 Feb 2023 16:07:24 GMT, Archie L. Cobbs wrote:
>> This bug relates to the "potentially ambiguous overload" warning which is
>> enabled by `-Xlint:overloads`.
>>
>> The warning detects certain ambiguities that can cause problems for lambdas.
>> For example, consider the interface `Spl
On Fri, 17 Feb 2023 10:20:46 GMT, Jan Lahoda wrote:
> This is a proposal to upgrade the JLine inside JDK to 3.22.0. It was done by:
> -for shared/classes, taking a diff between JLine 3.20.0 and the existing JDK
> version, copying the JLine 3.22.0 into the JDK, repackaing, re-appling the
> patch
On Sat, 18 Mar 2023 17:46:00 GMT, Archie L. Cobbs wrote:
> The fix for JDK-8015831, which added the new `this-escape` lint warning,
> caused the build of the `bootcycle-images` make target to fail.
>
> This commit adds the additional `@SuppressWarnings("this-escape")`
> annotations needed to f
On Sat, 18 Mar 2023 17:46:00 GMT, Archie L. Cobbs wrote:
> The fix for JDK-8015831, which added the new `this-escape` lint warning,
> caused the build of the `bootcycle-images` make target to fail.
>
> This commit adds the additional `@SuppressWarnings("this-escape")`
> annotations needed to f
On Wed, 22 Mar 2023 18:38:08 GMT, Jan Lahoda wrote:
>> If JShell is run on a system that does not have `/bin/test` (which is,
>> apparently, possible for some systems, which only have `/usr/bin/test`), it
>> won't switch the terminal into the raw mode, and the input will not work
>> properly.
On Fri, 17 Mar 2023 12:15:58 GMT, Jan Lahoda wrote:
> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>
> - the pattern matching for switch and record patterns features are made
> final, together with updates to tests.
> - parenthesized patterns are removed.
> -
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Tue, 18 Apr 2023 09:13:01 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Thu, 20 Apr 2023 13:33:17 GMT, Jan Lahoda wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 170:
>>
>>> 168: } else if (label instanceof EnumDesc enumDesc) {
>>> 169: if (target.getClass().isEnum() &&
>>> 170: ((
On Thu, 20 Apr 2023 13:41:05 GMT, Jan Lahoda wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 279:
>>
>>> 277: }
>>> 278:
>>> 279: private static int lazyDoEnumSwitch(Enum target, int
>>> startIndex, Object[] labels, MethodHandles.Lookup lookup, Class
On Thu, 20 Apr 2023 14:07:01 GMT, Vicente Romero wrote:
>> The intent here is to avoid eager initialization of enums - so, until the
>> enum is initialized, `lazyDoEnumSwitch` will be used (which, by itself,
>> won't compute any results, except the result for
On Thu, 20 Apr 2023 17:08:10 GMT, Jan Lahoda wrote:
>> That's in my upcoming update.
>
> The startIndex checks are part of this change:
> https://github.com/openjdk/jdk/pull/13074/commits/bb59254e409821c9b14287c73a35ebe2dd2cbda9
>
> Thanks for the comment!
Oh I see, thanks!
-
PR R
On Thu, 20 Apr 2023 16:54:20 GMT, Jan Lahoda wrote:
>> could you explain a bit more the relation between `lazyDoEnumSwitch` and
>> `doEnumSwitch` because my understanding is that `lazyDoEnumSwitch` is
>> invoking `doEnumSwitch` so to me whenever `lazyDoEnumSwitch` is invoked
>> there will be a
On Fri, 21 Apr 2023 10:56:55 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Fri, 21 Apr 2023 16:25:04 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Fri, 21 Apr 2023 16:25:04 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Mon, 24 Apr 2023 13:08:44 GMT, Jan Lahoda wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 315:
>>
>>> 313: Object[] labels = resolvedLabels.resolvedLabels;
>>> 314:
>>> 315: // Dumbest possible strategy
>>
>> I guess that given that we can'
On Mon, 24 Apr 2023 15:16:18 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Mon, 24 Apr 2023 15:16:18 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Mon, 24 Apr 2023 15:16:18 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Mon, 24 Apr 2023 15:16:18 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Fri, 24 Mar 2023 06:42:30 GMT, Hannes Greule wrote:
>> After merging master into https://github.com/openjdk/jdk/pull/9862, we
>> encountered test failures (e.g.,
>> https://github.com/SirYwell/jdk/actions/runs/4500940829/jobs/7923018438#step:9:2541).
>> The Classfile API tries to read from
On Fri, 5 May 2023 16:18:42 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Recommended changes #2
src/java.base/share/clas
On Fri, 5 May 2023 17:22:03 GMT, Rémi Forax wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
>> line 3999:
>>
>>> 3997: Name name = names.fromString(simplename);
>>> 3998: JCModifiers anonMods = F.at(primaryPos)
>>> 3999:
>>>
On Fri, 5 May 2023 17:31:27 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Typo
src/jdk.compiler/share/classes/com/sun/too
On Fri, 5 May 2023 19:17:53 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refactor source code launcher
looks good
-
On Thu, 4 May 2023 09:17:05 GMT, Adam Sotona wrote:
>> libjli/java.c's SelectVersion method receives argc and argv but ignores argc
>> in some circumstances an instead checks if *argv == 0 in its while loop,
>> which results in a segmentation fault if the provided array is not NULL
>> terminat
On Thu, 18 May 2023 22:22:25 GMT, Jan Lahoda wrote:
>> This is the first draft of a patch for JEP 440 and JEP 441. Changes included:
>>
>> - the pattern matching for switch and record patterns features are made
>> final, together with updates to tests.
>> - parenthesized patterns are removed.
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote:
>> javap uses proprietary com.sun.tools.classfile library to parse class files.
>>
>> This patch converts javap to use Classfile API.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target b
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote:
>> javap uses proprietary com.sun.tools.classfile library to parse class files.
>>
>> This patch converts javap to use Classfile API.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target b
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote:
>> javap uses proprietary com.sun.tools.classfile library to parse class files.
>>
>> This patch converts javap to use Classfile API.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target b
On Fri, 15 Sep 2023 09:42:24 GMT, Adam Sotona wrote:
>> javap uses proprietary com.sun.tools.classfile library to parse class files.
>>
>> This patch converts javap to use Classfile API.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with
On Mon, 18 Mar 2024 14:53:44 GMT, Pavel Rappo wrote:
> Please review this simple bugfix to properly construct links to preview JEPs.
>
> The most straightforward fix I could think of was to pass `String` rather
> than `int` (`Integer`) to a method, which eventually calls
> `java.text.MessageFo
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Wed, 3 Apr 2024 20:17:39 GMT, Joe Darcy wrote:
> When new language features are added, the javax.lang.model may need to be
> updated. For certain classes of features, the API update includes introducing
> a new set of concrete visitors to handle the language feature.
>
> The API scaffolding
On Wed, 3 Apr 2024 21:38:03 GMT, Joe Darcy wrote:
>> src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitorPreview.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2019, 2024, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> general, please check the copyri
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Mon, 8 Apr 2024 16:21:19 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Tue, 9 Apr 2024 09:28:23 GMT, Jan Lahoda wrote:
>> This is a patch for javac, that adds the Derived Record Creation
>> expressions. The current draft specification for the feature is:
>> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html
>>
>> The
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2004323374
On Thu, 18 Apr 2024 12:11:19 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and th
On Fri, 19 Apr 2024 13:17:18 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and th
On Thu, 14 Dec 2023 04:00:58 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
making the javadoc less general
-
Chan
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
Update test/jdk/java/lang/reflect/records/RecordReflec
On Wed, 24 Apr 2024 15:00:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding comment to jcod file
>
> test
> Will this fix be backported to JDK 21?
On Thu, 25 Apr 2024 23:24:07 GMT, Jonathan Gibbons wrote:
>> Please review the updates to support a proposed new
>> `-Xlint:dangling-doc-comments` option.
>>
>> The work can be thought of as in 3 parts:
>>
>> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
>> is po
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
adding more tests
-
Changes:
- all: htt
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
special case the new code for records onl
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
additional tests
-
Changes:
- all: htt
On Fri, 26 Apr 2024 21:27:55 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> special case the new code for records only
>
> src/java.base/share/classes/java/lang/re
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
code refactoring
-
Changes:
- all: htt
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Sat, 27 Apr 2024 00:14:23 GMT, Chen Liang wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> code refactoring
>
> src/java.base/share/classes/java/lang/reflect/Execu
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
minor refactoring
-
Changes:
- all: htt
On Mon, 6 May 2024 16:07:26 GMT, Adam Sotona wrote:
>> Hi,
>> During performance optimization work on Class-File API as JDK lambda
>> generator we found some static initialization killers.
>> One of them is `java.lang.classfile.Attributes` with tens of static fields
>> initialized with individu
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
On Mon, 29 Apr 2024 20:17:29 GMT, Joe Darcy wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor refactoring
>
> test/jdk/java/lang/reflect/records/R10.jcod line 1:
>
>&
On Tue, 12 Dec 2023 22:21:29 GMT, Joe Darcy wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixing comment
>
> As the core reflection code will encounter record classes compiled
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by th
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
addressing review comments
-
Changes:
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
more review comments
-
Changes:
- al
e
> information for mandated parameters if available plus changing the spec of
> the related reflection methods.
>
> TIA
Vicente Romero has updated the pull request incrementally with one additional
commit since the last revision:
fixing lines length
-
Changes:
- al
On Mon, 11 Dec 2023 23:33:16 GMT, Vicente Romero wrote:
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjd
On Thu, 28 Sep 2023 15:36:30 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the `@Restricted
On Thu, 28 Sep 2023 15:36:30 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the `@Restricted
On Fri, 29 Sep 2023 08:14:29 GMT, Maurizio Cimadamore
wrote:
> > question shouldn't the new Restricted annotation be annotated with the
> > @PreviewFeature annotation? it depends on a preview feature
>
> The Restricted annotation is an internal annotation only. So there is no
> value in annot
On Fri, 29 Sep 2023 08:30:07 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new lint warning category, namely `-Xlint:restricted` to
>> enable warnings on restricted method calls.
>>
>> The patch is relatively straightforward: javac marks methods that are marked
>> with the `@Restricted
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Mon, 2 Oct 2023 07:18:19 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/classfile/AnnotationElement.java line
>> 34:
>>
>>> 32: import jdk.internal.javac.PreviewFeature;
>>> 33:
>>> 34: /**
>>
>> shouldn't we have the preview header applied to all these compilation units?
1 - 100 of 143 matches
Mail list logo
