Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-29 Thread Raffaello Giulietti
> Add support for named groups to java.util.regex.MatchResult Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8065554: MatchResult should provide values of named-capturing groups - Changes: - all: https://git.op

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Raffaello Giulietti
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values o

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values o

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values o

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values o

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Raffaello Giulietti
On Tue, 30 Aug 2022 19:27:26 GMT, Stuart Marks wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8065554: MatchResult should provide values of named-capturing groups > > test/jdk/java/util/regex/NamedGroupsTes

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-30 Thread Stuart Marks
On Tue, 30 Aug 2022 20:17:04 GMT, Raffaello Giulietti wrote: >> test/jdk/java/util/regex/NamedGroupsTests.java line 45: >> >>> 43: >>> 44: testMatchResultStartEndGroup(); >>> 45: } >> >> I haven't gone through all the tests in great detail (yet), but it occurs to >> me that we pot

Re: RFR: 8065554: MatchResult should provide values of named-capturing groups [v4]

2022-08-31 Thread Raffaello Giulietti
On Mon, 29 Aug 2022 13:49:52 GMT, Raffaello Giulietti wrote: >> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values o