Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v3]

2023-11-08 Thread Adam Sotona
On Wed, 8 Nov 2023 17:10:11 GMT, Mandy Chung wrote: >> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to >> mechanically convert a classfile for a Class into an in-memory class >> representation of an equivalent Interface. `testPrivateMethodCall` tests >> to

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v3]

2023-11-08 Thread Mandy Chung
> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to > mechanically convert a classfile for a Class into an in-memory class > representation of an equivalent Interface. `testPrivateMethodCall` tests to > invoke a private method. Before nestmates, invoking a private

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v2]

2023-11-07 Thread Chen Liang
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote: >> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to >> mechanically convert a classfile for a Class into an in-memory class >> representation of an equivalent Interface. `testPrivateMethodCall` tests >> to

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v2]

2023-11-07 Thread Mandy Chung
On Wed, 8 Nov 2023 00:30:05 GMT, Chen Liang wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify the transformation code and easier to read > > test/jdk/jdk/lambda/separate/ClassToInterfaceConverter.java line

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v2]

2023-11-07 Thread Chen Liang
On Tue, 7 Nov 2023 19:10:18 GMT, ExE Boss wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify the transformation code and easier to read > > test/jdk/jdk/lambda/separate/ClassToInterfaceConverter.java line 53:

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v2]

2023-11-07 Thread Chen Liang
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote: >> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to >> mechanically convert a classfile for a Class into an in-memory class >> representation of an equivalent Interface. `testPrivateMethodCall` tests >> to

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v2]

2023-11-07 Thread ExE Boss
On Tue, 7 Nov 2023 18:34:42 GMT, Mandy Chung wrote: >> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to >> mechanically convert a classfile for a Class into an in-memory class >> representation of an equivalent Interface. `testPrivateMethodCall` tests >> to

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support [v2]

2023-11-07 Thread Mandy Chung
> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to > mechanically convert a classfile for a Class into an in-memory class > representation of an equivalent Interface. `testPrivateMethodCall` tests to > invoke a private method. Before nestmates, invoking a private

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support

2023-11-06 Thread Mandy Chung
On Tue, 7 Nov 2023 02:30:55 GMT, Chen Liang wrote: >> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to >> mechanically convert a classfile for a Class into an in-memory class >> representation of an equivalent Interface. `testPrivateMethodCall` tests >> to invoke

Re: RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support

2023-11-06 Thread Chen Liang
On Mon, 6 Nov 2023 19:26:26 GMT, Mandy Chung wrote: > `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to > mechanically convert a classfile for a Class into an in-memory class > representation of an equivalent Interface. `testPrivateMethodCall` tests to > invoke a

RFR: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support

2023-11-06 Thread Mandy Chung
`jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to mechanically convert a classfile for a Class into an in-memory class representation of an equivalent Interface. `testPrivateMethodCall` tests to invoke a private method. Before nestmates, invoking a private class