Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-13 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. The Release Note for this PR did n

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-10 Thread Jaikiran Pai
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. Marked as reviewed by jpai (Review

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-07 Thread Jaikiran Pai
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. Hello Eirik, I'll run this against

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-06 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. This PR is daydreaming about a sp

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-04 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. Good riddance. - PR

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-04 Thread Alan Bateman
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. Marked as reviewed by alanb (Revie

Re: RFR: 8205129: Remove java.lang.Compiler

2023-04-04 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. The CSR for this PR has been appro

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-29 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. The CSR for this PR has now been a

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-28 Thread Eirik Bjorsnos
On Tue, 28 Mar 2023 13:36:38 GMT, Alan Bateman wrote: > I think you should be able to finalize the CSR JDK-8304458. Thanks for the gentle nudge, Alan. I was actually not aware that finalization could be initiated by the assignee! I've seen the CSR lead handle this workflow previously. I presse

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-28 Thread Alan Bateman
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. I think you should be able to fina

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-21 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. The CSR for the removal of `java.l

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-20 Thread David Holmes
On Tue, 21 Mar 2023 01:46:46 GMT, David Holmes wrote: >The only part of that we have left today is that -Djava.compiler=NONE is an >alias for -Xint mode. Edit: ... unless `-Xdebug` is specified in which case it is ignored. - PR Comment: https://git.openjdk.org/jdk/pull/13092#issue

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-20 Thread David Holmes
On Mon, 20 Mar 2023 17:35:58 GMT, Stuart Marks wrote: > I don't know how much interdependency there is between the java.compiler > system property and the java.lang.Compiler class. > On the library side I think they're independent. That may be true today but originally they were very much inte

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-20 Thread Stuart Marks
On Mon, 20 Mar 2023 02:01:38 GMT, David Holmes wrote: >>> The discussion is also a reminder that -Djava.compiler=NONE is the >>> equivalent of -Xint, I thought that system property was dropped a long time >>> ago. >> >> https://bugs.openjdk.org/browse/JDK-8041676 suggests to deprecate it, but

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-20 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. I noticed there are quite a few us

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread David Holmes
On Sun, 19 Mar 2023 15:20:33 GMT, Eirik Bjorsnos wrote: > > The discussion is also a reminder that -Djava.compiler=NONE is the > > equivalent of -Xint, I thought that system property was dropped a long time > > ago. > > https://bugs.openjdk.org/browse/JDK-8041676 suggests to deprecate it, but

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Alan Bateman
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. A search of 3M classes in 130k art

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 15:08:58 GMT, Eirik Bjorsnos wrote: > The discussion is also a reminder that -Djava.compiler=NONE is the equivalent > of -Xint, I thought that system property was dropped a long time ago. https://bugs.openjdk.org/browse/JDK-8041676 suggests to deprecate it, but from the las

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 14:38:55 GMT, Alan Bateman wrote: > For reference, here's the discussion from 2016 when it was proposed to > deprecate j.l.Compiler, for removal. Tim Ellison from IBM engaged in that > discussion as one of the replies asked about applications running on the J9 > VM using th

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Alan Bateman
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. For reference, here's the discussi

Re: RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
On Sun, 19 Mar 2023 09:01:26 GMT, Eirik Bjorsnos wrote: > Please help review this PR which suggests we remove the class > `java.lang.Compiler`. The class seems non-functional for a decade, and was > terminally deprecated in Java 9. Time has come to let it go. The actual change in this PR seems

RFR: 8205129: Remove java.lang.Compiler

2023-03-19 Thread Eirik Bjorsnos
Please help review this PR which suggests we remove the class `java.lang.Compiler`. The class seems non-functional for a decade, and was terminally deprecated in Java 9. Time has come to let it go. - Commit messages: - Remove the deprecated class java.lang.Compiler Changes: https: