Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-25 Thread Pavel Rappo
On Thu, 20 Apr 2023 16:19:05 GMT, Stuart Marks wrote: >>> I didn't know about the need to specify `@throws` in order to generate the >>> throws-clauses in the docs. >> >> You need to explicitly inherit `@throws` only for exceptions that aren't >> mentioned in the `throws` clause. >> >>> As

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-20 Thread Stuart Marks
On Thu, 20 Apr 2023 09:03:03 GMT, Pavel Rappo wrote: >> @pavelrappo Aggh. >> >>> I guess, this PR has converged enough for us to discuss some trivial stuff; >>> so here it goes. >> >> All this "trivial" stuff is generating a lot of work! :-) Well, no big deal, >> Joe D still has more CSR

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-20 Thread Nir Lisker
On Wed, 19 Apr 2023 18:22:28 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/SequencedMap.java line 110: >> >>> 108: * {@code Entry} thus obtained will update a mapping in the underlying >>> map, or whether >>> 109: * it will throw an exception, or whether changes to the

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-20 Thread Pavel Rappo
On Thu, 20 Apr 2023 04:13:57 GMT, Stuart Marks wrote: > I didn't know about the need to specify `@throws` in order to generate the > throws-clauses in the docs. You need to explicitly inherit `@throws` only for exceptions that aren't mentioned in the `throws` clause. > As an aside, I note

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-20 Thread Nir Lisker
On Wed, 19 Apr 2023 14:41:59 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering of Collection.addAll and Map.putAll; add

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Stuart Marks
On Wed, 19 Apr 2023 10:29:48 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java >> line 409: >> >>> 407: * {@inheritDoc} >>> 408: */ >>> 409: public E getFirst() { >> >> Javadoc will automatically copy the specification from the

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Stuart Marks
On Wed, 19 Apr 2023 14:41:59 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering of Collection.addAll and Map.putAll; add

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Stuart Marks
On Wed, 19 Apr 2023 12:27:41 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering of Collection.addAll and Map.putAll; add

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Stuart Marks
On Wed, 19 Apr 2023 14:19:01 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering of Collection.addAll and Map.putAll; add

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Stuart Marks
On Wed, 19 Apr 2023 10:06:38 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering of Collection.addAll and Map.putAll; add

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Stuart Marks
On Wed, 19 Apr 2023 09:43:44 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering of Collection.addAll and Map.putAll; add

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Stuart Marks
On Wed, 19 Apr 2023 05:51:11 GMT, Nir Lisker wrote: >> Stuart Marks has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Remove unnecessary 'final' from a couple places. >> - Clarify ordering of Collection.addAll and Map.putAll; add

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Nir Lisker
On Wed, 19 Apr 2023 03:37:05 GMT, Stuart Marks wrote: >> PR for Sequenced Collections implementation. > > Stuart Marks has updated the pull request incrementally with three additional > commits since the last revision: > > - Remove unnecessary 'final' from a couple places. > - Clarify

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-19 Thread Pavel Rappo
On Wed, 19 Apr 2023 04:36:28 GMT, Chen Liang wrote: > Javadoc will automatically copy the specification from the overridden method, > so the javadoc block is not necessary and can be replaced by an `@Override` > to indicate inheritance. I guess, this PR has converged enough for us to discuss

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-18 Thread Chen Liang
On Wed, 19 Apr 2023 03:37:05 GMT, Stuart Marks wrote: >> PR for Sequenced Collections implementation. > > Stuart Marks has updated the pull request incrementally with three additional > commits since the last revision: > > - Remove unnecessary 'final' from a couple places. > - Clarify

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-18 Thread Chen Liang
On Wed, 19 Apr 2023 03:37:05 GMT, Stuart Marks wrote: >> PR for Sequenced Collections implementation. > > Stuart Marks has updated the pull request incrementally with three additional > commits since the last revision: > > - Remove unnecessary 'final' from a couple places. > - Clarify

Re: RFR: 8266571: Sequenced Collections [v7]

2023-04-18 Thread Stuart Marks
> PR for Sequenced Collections implementation. Stuart Marks has updated the pull request incrementally with three additional commits since the last revision: - Remove unnecessary 'final' from a couple places. - Clarify ordering of Collection.addAll and Map.putAll; add links to encounter