Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

2022-09-20 Thread Adam Sotona
On Mon, 22 Aug 2022 07:24:14 GMT, Adam Sotona wrote: >> test/jdk/java/lang/constant/ClassDescTest.java line 268: >> >>> 266: } >>> 267: >>> 268: List badInternalNames = List.of("I;", "[]", >> >> is `[]` a good test for arrays? Wouldn't something more realistic like >> `[Ljava/

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v6]

2022-09-19 Thread Adam Sotona
> The symbolic constants API (`java.lang.constant`) was designed, in part, to > provide bytecode parsing and generation APIs with a validated, common, > symbolic form for constants in Java class files. > > There is an easy way to create a `ClassDesc` from a binary name > (`ClassDesc::of`) or a

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v5]

2022-09-06 Thread Adam Sotona
> The symbolic constants API (`java.lang.constant`) was designed, in part, to > provide bytecode parsing and generation APIs with a validated, common, > symbolic form for constants in Java class files. > > There is an easy way to create a `ClassDesc` from a binary name > (`ClassDesc::of`) or a

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v4]

2022-08-22 Thread Adam Sotona
> The symbolic constants API (`java.lang.constant`) was designed, in part, to > provide bytecode parsing and generation APIs with a validated, common, > symbolic form for constants in Java class files. > > There is an easy way to create a `ClassDesc` from a binary name > (`ClassDesc::of`) or a

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

2022-08-22 Thread Adam Sotona
On Tue, 26 Jul 2022 09:25:48 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated ClassDesc::ofInternal javadoc with JVMS link and fixed indentation > > test/jdk/java/lang/constant/Class

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

2022-08-22 Thread Adam Sotona
On Tue, 26 Jul 2022 19:57:38 GMT, ExE Boss wrote: >> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 85: >> >>> 83: * given the name of the class or interface in internal form, >>> 84: * such as {@code "java/lang/String"}. >>> 85: * (To create a descriptor for a

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

2022-07-26 Thread ExE Boss
On Tue, 26 Jul 2022 09:19:07 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated ClassDesc::ofInternal javadoc with JVMS link and fixed indentation > > src/java.base/share/classes/java/

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

2022-07-26 Thread Maurizio Cimadamore
On Mon, 20 Jun 2022 07:45:46 GMT, Adam Sotona wrote: >> The symbolic constants API (`java.lang.constant`) was designed, in part, to >> provide bytecode parsing and generation APIs with a validated, common, >> symbolic form for constants in Java class files. >> >> There is an easy way to creat

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

2022-07-26 Thread Adam Sotona
On Mon, 20 Jun 2022 07:45:46 GMT, Adam Sotona wrote: >> The symbolic constants API (`java.lang.constant`) was designed, in part, to >> provide bytecode parsing and generation APIs with a validated, common, >> symbolic form for constants in Java class files. >> >> There is an easy way to creat

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v3]

2022-06-20 Thread Adam Sotona
> The symbolic constants API (`java.lang.constant`) was designed, in part, to > provide bytecode parsing and generation APIs with a validated, common, > symbolic form for constants in Java class files. > > There is an easy way to create a `ClassDesc` from a binary name > (`ClassDesc::of`) or a

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v2]

2022-06-17 Thread Jorn Vernee
On Fri, 17 Jun 2022 17:03:52 GMT, Adam Sotona wrote: >> The symbolic constants API (`java.lang.constant`) was designed, in part, to >> provide bytecode parsing and generation APIs with a validated, common, >> symbolic form for constants in Java class files. >> >> There is an easy way to creat

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v2]

2022-06-17 Thread Adam Sotona
On Fri, 17 Jun 2022 17:03:52 GMT, Adam Sotona wrote: >> The symbolic constants API (`java.lang.constant`) was designed, in part, to >> provide bytecode parsing and generation APIs with a validated, common, >> symbolic form for constants in Java class files. >> >> There is an easy way to creat

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v2]

2022-06-17 Thread Adam Sotona
On Fri, 17 Jun 2022 15:01:16 GMT, Jorn Vernee wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test/jdk/java/lang/constant/ClassDescTest.java >> >> Co-authored-by: Jorn Vernee > > test/jdk/java/lang/cons

Re: RFR: 8278863: Add method ClassDesc::ofInternalName [v2]

2022-06-17 Thread Adam Sotona
> The symbolic constants API (`java.lang.constant`) was designed, in part, to > provide bytecode parsing and generation APIs with a validated, common, > symbolic form for constants in Java class files. > > There is an easy way to create a `ClassDesc` from a binary name > (`ClassDesc::of`) or a

Re: RFR: 8278863: Add method ClassDesc::ofInternalName

2022-06-17 Thread Jorn Vernee
On Fri, 17 Jun 2022 14:19:11 GMT, Adam Sotona wrote: > The symbolic constants API (`java.lang.constant`) was designed, in part, to > provide bytecode parsing and generation APIs with a validated, common, > symbolic form for constants in Java class files. > > There is an easy way to create a `

RFR: 8278863: Add method ClassDesc::ofInternalName

2022-06-17 Thread Adam Sotona
The symbolic constants API (`java.lang.constant`) was designed, in part, to provide bytecode parsing and generation APIs with a validated, common, symbolic form for constants in Java class files. There is an easy way to create a `ClassDesc` from a binary name (`ClassDesc::of`) or a field descr