Re: RFR: 8283335 : Add exists and readAttributesIfExists methods to FileSystemProvider [v2]

2022-06-27 Thread Alan Bateman
On Sun, 26 Jun 2022 13:33:40 GMT, Lance Andersen wrote: > I thought about using TestProvider and then talked myself out of it. So yes, > I can do that. If you have a preferred name other than > `TestOverRideFSPMethods` please let me know The only change that should be needed to TestProvider

Re: RFR: 8283335 : Add exists and readAttributesIfExists methods to FileSystemProvider [v2]

2022-06-26 Thread Lance Andersen
On Sun, 26 Jun 2022 13:13:35 GMT, Alan Bateman wrote: > The implementation changes in latest version address my previous points, > thanks! I don't the test as it duplicates most of the existing of the > TestProvider in this directory and the naming is inconsistent with the > existing tests. I

Re: RFR: 8283335 : Add exists and readAttributesIfExists methods to FileSystemProvider [v2]

2022-06-26 Thread Alan Bateman
On Sun, 26 Jun 2022 11:13:58 GMT, Lance Andersen wrote: >> Hi, >> >> Please review the following patch which will: >> >> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include >> the methods >> >> - public boolean exists(Path path, LinkOption... options) >> - public

Re: RFR: 8283335 : Add exists and readAttributesIfExists methods to FileSystemProvider [v2]

2022-06-26 Thread Lance Andersen
> Hi, > > Please review the following patch which will: > > - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include > the methods > > - public boolean exists(Path path, LinkOption... options) > - public A readAttributesIfExists(Path > path, Class type, LinkOption...