Re: RFR: 8288838: jpackage: file association additional arguments [v4]

2022-07-07 Thread Alexander Matveev
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote: >> jpackage implementation of file association on Windows currently passes a >> selected filename as an only argument to associated executable. >> >> It is proposed to introduce additional option in file association property >> file to allow o

Re: RFR: 8288838: jpackage: file association additional arguments [v3]

2022-07-07 Thread Alex Kasko
On Thu, 30 Jun 2022 18:50:23 GMT, Alexey Semenyuk wrote: >> Alex Kasko has updated the pull request incrementally with one additional >> commit since the last revision: >> >> drop pass-all-args property > > test/jdk/tools/jpackage/share/FileAssociationsTest.java line 108: > >> 106:

Re: RFR: 8288838: jpackage: file association additional arguments [v4]

2022-07-07 Thread Alex Kasko
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote: >> jpackage implementation of file association on Windows currently passes a >> selected filename as an only argument to associated executable. >> >> It is proposed to introduce additional option in file association property >> file to allow o

Re: RFR: 8288838: jpackage: file association additional arguments [v3]

2022-07-07 Thread Alexey Semenyuk
On Wed, 29 Jun 2022 12:29:33 GMT, Alex Kasko wrote: >> jpackage implementation of file association on Windows currently passes a >> selected filename as an only argument to associated executable. >> >> It is proposed to introduce additional option in file association property >> file to allow

Re: RFR: 8288838: jpackage: file association additional arguments [v4]

2022-07-07 Thread Alexey Semenyuk
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote: >> jpackage implementation of file association on Windows currently passes a >> selected filename as an only argument to associated executable. >> >> It is proposed to introduce additional option in file association property >> file to allow o

Re: RFR: 8288838: jpackage: file association additional arguments [v4]

2022-07-06 Thread Alex Kasko
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote: >> jpackage implementation of file association on Windows currently passes a >> selected filename as an only argument to associated executable. >> >> It is proposed to introduce additional option in file association property >> file to allow o

Re: RFR: 8288838: jpackage: file association additional arguments [v4]

2022-07-05 Thread Alexey Semenyuk
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote: >> jpackage implementation of file association on Windows currently passes a >> selected filename as an only argument to associated executable. >> >> It is proposed to introduce additional option in file association property >> file to allow o

Re: RFR: 8288838: jpackage: file association additional arguments [v4]

2022-07-05 Thread Alex Kasko
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote: >> jpackage implementation of file association on Windows currently passes a >> selected filename as an only argument to associated executable. >> >> It is proposed to introduce additional option in file association property >> file to allow o

Re: RFR: 8288838: jpackage: file association additional arguments [v4]

2022-07-05 Thread Alex Kasko
> jpackage implementation of file association on Windows currently passes a > selected filename as an only argument to associated executable. > > It is proposed to introduce additional option in file association property > file to allow optionally support additional arguments using `%*` batch >

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-29 Thread Alexey Semenyuk
On Wed, 29 Jun 2022 12:30:05 GMT, Alex Kasko wrote: > For runtime installers it would be great to have a custom verb label, to be > able to use something like: "Open with VendorName OpenJDK". I intend to > prototype this and file in a separate PR Sounds good. > %* contains all the arguments b

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-29 Thread Alex Kasko
On Tue, 28 Jun 2022 21:38:50 GMT, Alexey Semenyuk wrote: > The existing behavior simply cuts off all, but the first argument from the > argument array passed to the app launcher. Changing this looks more like a > fix of a bug, than an enhancement. I'd keep it simple: replace the value of > the

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-29 Thread Alex Kasko
On Tue, 28 Jun 2022 21:38:50 GMT, Alexey Semenyuk wrote: > > I assume we will need an additional similar property for a verb label > > displayed in a context menu. > > Agree. At least we need to provide l10n for it. For runtime installers it would be great to have a custom verb label, to be a

Re: RFR: 8288838: jpackage: file association additional arguments [v3]

2022-06-29 Thread Alex Kasko
> jpackage implementation of file association on Windows currently passes a > selected filename as an only argument to associated executable. > > It is proposed to introduce additional option in file association property > file to allow optionally support additional arguments using `%*` batch >

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-28 Thread Alexey Semenyuk
On Tue, 28 Jun 2022 21:03:28 GMT, Alex Kasko wrote: > I assume we will need an additional similar property for a verb label > displayed in a context menu. Agree. At least we need to provide l10n for it. > Can we change the existing default behaviour? Should we? It won't break > existing usage

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-28 Thread Alex Kasko
On Mon, 27 Jun 2022 17:53:29 GMT, Alexey Semenyuk wrote: > What would be the alternative to `pass-all-args`? As this is intended to be a public property, I assume there should be a CSR and some consistent name, perhaps with `win-` prefix - I assume we will need an additional similar property

Re: RFR: 8288838: jpackage: file association additional arguments [v2]

2022-06-28 Thread Alex Kasko
On Mon, 27 Jun 2022 17:57:53 GMT, Alexey Semenyuk wrote: >> Alex Kasko has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use shortcut to test arguments, add argument with spaces > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/Wi

Re: RFR: 8288838: jpackage: file association additional arguments [v2]

2022-06-28 Thread Alex Kasko
> jpackage implementation of file association on Windows currently passes a > selected filename as an only argument to associated executable. > > It is proposed to introduce additional option in file association property > file to allow optionally support additional arguments using `%*` batch >

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-27 Thread Alexey Semenyuk
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote: > jpackage implementation of file association on Windows currently passes a > selected filename as an only argument to associated executable. > > It is proposed to introduce additional option in file association property > file to allow optio

Re: RFR: 8288838: jpackage: file association additional arguments

2022-06-27 Thread Alexey Semenyuk
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote: > jpackage implementation of file association on Windows currently passes a > selected filename as an only argument to associated executable. > > It is proposed to introduce additional option in file association property > file to allow optio

RFR: 8288838: jpackage: file association additional arguments

2022-06-21 Thread Alex Kasko
jpackage implementation of file association on Windows currently passes a selected filename as an only argument to associated executable. It is proposed to introduce additional option in file association property file to allow optionally support additional arguments using `%*` batch wildcard. N