Re: RFR: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation [v2]

2022-09-01 Thread Jaikiran Pai
On Wed, 31 Aug 2022 08:40:29 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/java/text/PatternEntry.java line 55: >> >>> 53: * Gets the current extension, quoted >>> 54: */ >>> 55: public void appendQuotedExtension(StringBuilder toAddTo) { >> >> Hello Andrey, this and

Re: RFR: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation [v2]

2022-08-31 Thread Roger Riggs
On Wed, 31 Aug 2022 08:46:32 GMT, Andrey Turbanov wrote: >> Couple of package-private classes in `java.text` package still use >> `StringBuffer`: `MergeCollation` and `PatternEntry`. >> StringBuffer is a legacy synchronized class. StringBuilder is a direct >> replacement to StringBuffer which

Re: RFR: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation [v2]

2022-08-31 Thread Andrey Turbanov
On Tue, 30 Aug 2022 08:58:30 GMT, Jaikiran Pai wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation >> >> use private for methods which

Re: RFR: 8293008: Replace uses of StringBuffer with StringBuilder in MergeCollation [v2]

2022-08-31 Thread Andrey Turbanov
> Couple of package-private classes in `java.text` package still use > `StringBuffer`: `MergeCollation` and `PatternEntry`. > StringBuffer is a legacy synchronized class. StringBuilder is a direct > replacement to StringBuffer which generally have better performance. Andrey Turbanov has updated