On Mon, 29 Aug 2022 09:33:44 GMT, Сергей Цыпанов wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Touchups
>
> src/java.base/share/classes/jdk/internal/module/ModuleHashes.java line 170:
>
>> 168: static Mo
On Mon, 29 Aug 2022 10:50:03 GMT, Aleksey Shipilev wrote:
> I would be very surprised if we actually verified the module hashes at
> startup! That would take minutes to startup on Zero, as observed by its
> build-time checking. And we don't see that, apparently.
Module hashes are checked at st
On Mon, 29 Aug 2022 09:18:16 GMT, Alan Bateman wrote:
> This issue will require discussion as it potentially impacts usage at
> run-time when the resolver runs at startup or when creating module layers.
Startup with/without CDS:
$ perf stat -r 100 build/linux-x86_64-server-release/images/jdk
> `jmod`/`jlink` are executed during build time to produce the `jmod` and the
> base modules image. On slow hardware (Raspberry Pi -class, for example)
> and/or slow VMs (debug, interpreter-only, for example) this takes a while.
> Profiling shows the considerable time is spent on hashing modules
On Mon, 29 Aug 2022 08:55:06 GMT, Aleksey Shipilev wrote:
> `jmod`/`jlink` are executed during build time to produce the `jmod` and the
> base modules image. On slow hardware (Raspberry Pi -class, for example)
> and/or slow VMs (debug, interpreter-only, for example) this takes a while.
> Profi
On Mon, 29 Aug 2022 08:55:06 GMT, Aleksey Shipilev wrote:
> `jmod`/`jlink` are executed during build time to produce the `jmod` and the
> base modules image. On slow hardware (Raspberry Pi -class, for example)
> and/or slow VMs (debug, interpreter-only, for example) this takes a while.
> Profi
`jmod`/`jlink` are executed during build time to produce the `jmod` and the
base modules image. On slow hardware (Raspberry Pi -class, for example) and/or
slow VMs (debug, interpreter-only, for example) this takes a while. Profiling
shows the considerable time is spent on hashing modules either