Re: RFR: 8293017: Improve hash calculation parallelism in jmod/jlink [v2]

2022-08-29 Thread Aleksey Shipilev
On Mon, 29 Aug 2022 09:33:44 GMT, Сергей Цыпанов wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Touchups > > src/java.base/share/classes/jdk/internal/module/ModuleHashes.java line 170: > >> 168: static Mo

Re: RFR: 8293017: Improve hash calculation parallelism in jmod/jlink

2022-08-29 Thread Alan Bateman
On Mon, 29 Aug 2022 10:50:03 GMT, Aleksey Shipilev wrote: > I would be very surprised if we actually verified the module hashes at > startup! That would take minutes to startup on Zero, as observed by its > build-time checking. And we don't see that, apparently. Module hashes are checked at st

Re: RFR: 8293017: Improve hash calculation parallelism in jmod/jlink

2022-08-29 Thread Aleksey Shipilev
On Mon, 29 Aug 2022 09:18:16 GMT, Alan Bateman wrote: > This issue will require discussion as it potentially impacts usage at > run-time when the resolver runs at startup or when creating module layers. Startup with/without CDS: $ perf stat -r 100 build/linux-x86_64-server-release/images/jdk

Re: RFR: 8293017: Improve hash calculation parallelism in jmod/jlink [v2]

2022-08-29 Thread Aleksey Shipilev
> `jmod`/`jlink` are executed during build time to produce the `jmod` and the > base modules image. On slow hardware (Raspberry Pi -class, for example) > and/or slow VMs (debug, interpreter-only, for example) this takes a while. > Profiling shows the considerable time is spent on hashing modules

Re: RFR: 8293017: Improve hash calculation parallelism in jmod/jlink

2022-08-29 Thread Сергей Цыпанов
On Mon, 29 Aug 2022 08:55:06 GMT, Aleksey Shipilev wrote: > `jmod`/`jlink` are executed during build time to produce the `jmod` and the > base modules image. On slow hardware (Raspberry Pi -class, for example) > and/or slow VMs (debug, interpreter-only, for example) this takes a while. > Profi

Re: RFR: 8293017: Improve hash calculation parallelism in jmod/jlink

2022-08-29 Thread Alan Bateman
On Mon, 29 Aug 2022 08:55:06 GMT, Aleksey Shipilev wrote: > `jmod`/`jlink` are executed during build time to produce the `jmod` and the > base modules image. On slow hardware (Raspberry Pi -class, for example) > and/or slow VMs (debug, interpreter-only, for example) this takes a while. > Profi

RFR: 8293017: Improve hash calculation parallelism in jmod/jlink

2022-08-29 Thread Aleksey Shipilev
`jmod`/`jlink` are executed during build time to produce the `jmod` and the base modules image. On slow hardware (Raspberry Pi -class, for example) and/or slow VMs (debug, interpreter-only, for example) this takes a while. Profiling shows the considerable time is spent on hashing modules either