On Fri, 10 Mar 2023 15:10:01 GMT, Adam Sotona wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incremen
On Thu, 9 Mar 2023 17:59:55 GMT, Mandy Chung wrote:
>> Yes, `Classfile::buildModule` contains logic determining if emission of
>> `ModulePackages` is required or not.
>
> It'd be helpful to add a comment that `ModulePackages` attribute is only
> emitted if there are packages that aren't exporte
On Fri, 10 Mar 2023 15:10:01 GMT, Adam Sotona wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incremen
On Fri, 10 Mar 2023 14:28:09 GMT, liach wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment fix
>> - Merge branch 'master' into JDK-8
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Mod
On Fri, 10 Mar 2023 08:46:16 GMT, Adam Sotona wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a n
On Thu, 9 Mar 2023 22:05:55 GMT, Uwe Schindler wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment fix
>> - Merge branch 'master' int
On Fri, 10 Mar 2023 07:10:11 GMT, Adam Sotona wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incremen
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now
On Thu, 9 Mar 2023 18:36:05 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment fix
>> - Merge branch 'master' into
On Thu, 9 Mar 2023 19:41:28 GMT, liach wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment fix
>> - Merge branch 'master' into JDK-82
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Upd
On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
src/java.base/share/classes/jdk/internal/module/ModuleInfoW
On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Wouldn’t “Convert java.base/jdk.internal.module to use the
On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
src/java.base/share/classes/jdk/internal/module/ModuleInfoW
On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
src/java.base/share/classes/jdk/internal/module/ModuleInfoE
On Thu, 9 Mar 2023 10:59:25 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java line
>> 146:
>>
>>> 144:
>>> 145: // packages
>>> 146: md.packages().stream().map(PackageDesc::of).toList(),
>>
>> When writing `module_
On Wed, 1 Mar 2023 01:19:24 GMT, Mandy Chung wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> src/java.base/share/classes/jdk/internal/module/Mo
On Fri, 25 Nov 2022 14:43:32 GMT, Alan Bateman wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write
>> module-info.class.
>> This patch converts it to use Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> src/java.base/share/classes/jdk/internal/module/
On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
src/java.base/share/classes/jdk/internal/module/ModuleInfoW
On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
src/java.base/share/classes/jdk/internal/module/ModuleInfoE
8294962: java.base jdk.internal.module package uses ASM to modify and write
module-info.class.
This patch converts it to use Classfile API.
Please review.
Thanks,
Adam
-
Commit messages:
- Merge branch 'master' into JDK-8294962-internal-module
- fixed jdk.internal.classfile.java.l
22 matches
Mail list logo
