Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Fri, 10 Mar 2023 14:28:09 GMT, liach wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' into JDK-8

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread liach
On Fri, 10 Mar 2023 08:46:16 GMT, Adam Sotona wrote: >> 8294962: java.base jdk.internal.module package uses ASM to modify and write >> module-info.class. >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a n

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 22:05:55 GMT, Uwe Schindler wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' int

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
> 8294962: java.base jdk.internal.module package uses ASM to modify and write > module-info.class. > This patch converts it to use Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 18:36:05 GMT, Mandy Chung wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' into

Re: RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]

2023-03-10 Thread Adam Sotona
On Thu, 9 Mar 2023 19:41:28 GMT, liach wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 198 commits: >> >> - ModuleInfoWriter fixes >> - ModuleInfoExtender comment fix >> - Merge branch 'master' into JDK-82