Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v13]

2023-03-20 Thread Mandy Chung
On Mon, 20 Mar 2023 16:44:25 GMT, Mandy Chung wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> line 581: >> >>> 579: clb.withFlags(ACC_FINAL + ACC_SUPER) >>> 580: >>> .withInterfaceSymbols(List

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v13]

2023-03-20 Thread Mandy Chung
On Mon, 20 Mar 2023 15:34:31 GMT, Alan Bateman wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added default to thrown for unknown CP tag in IncludeLocalesPlugin > > src/jdk.jlink/share/classes/jdk/tools/jlink/inter

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v13]

2023-03-20 Thread Alan Bateman
On Mon, 20 Mar 2023 12:02:31 GMT, Adam Sotona wrote: >> jdk.jlink internal plugins are heavily using ASM >> >> This patch converts ASM calls to Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v13]

2023-03-20 Thread Alan Bateman
On Mon, 20 Mar 2023 12:02:31 GMT, Adam Sotona wrote: >> jdk.jlink internal plugins are heavily using ASM >> >> This patch converts ASM calls to Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v13]

2023-03-20 Thread Mandy Chung
On Mon, 20 Mar 2023 12:02:31 GMT, Adam Sotona wrote: >> jdk.jlink internal plugins are heavily using ASM >> >> This patch converts ASM calls to Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since t

Re: RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v13]

2023-03-20 Thread Adam Sotona
> jdk.jlink internal plugins are heavily using ASM > > This patch converts ASM calls to Classfile API. > > Please review. > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: added default to thrown for unknown CP tag in