On Mon, 20 Mar 2023 16:44:25 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java >> line 581: >> >>> 579: clb.withFlags(ACC_FINAL + ACC_SUPER) >>> 580: >>> .withInterfaceSymbols(List.of(CD_SYSTEM_MODULES)) >>> 581: .withVersion(52, 0); >> >> @mlchung Do you recall why this was generated as version 52? > > When this plugin was added in JDK 9, no API to get the current class file > version. Later I added `jdk.internal.misc.VM::classFileVersion` and > converted lambda proxies and lambda forms to use it. > > I have a patch to switch class file version to > `ClassFileFormatVersion::latest` in this generated class and some others but > want to wait until this PR is integrated. I posted https://github.com/openjdk/jdk/pull/13106 regarding the class file version. Having a second thought, no need to wait until this PR is integrated. It should be easily merged. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12944#discussion_r1142551119
