On Tue, 21 Mar 2023 11:54:38 GMT, Adam Sotona wrote:
>> Yes, I think so. If `java -XX:+UnlockDiagnosticVMOptions
>> -XX:+BytecodeVerificationLocal -version` doesn't fail and you've run all the
>> tests then it should be okay to drop it.
>
> I can confirm `java -XX:+UnlockDiagnosticVMOptions
>
On Tue, 21 Mar 2023 11:31:54 GMT, Alan Bateman wrote:
>> It seems to be redundant as the following code does not expect it on stack
>> and loads it again as needed.
>
> Yes, I think so. If `java -XX:+UnlockDiagnosticVMOptions
> -XX:+BytecodeVerificationLocal -version` doesn't fail and you've ru
On Tue, 21 Mar 2023 09:10:05 GMT, Adam Sotona wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>> line 1021:
>>
>>> 1019: MethodTypeDesc.of(CD_void,
>>> CD_String))
>>> 1020:.astore(BUILDER_VAR
On Mon, 20 Mar 2023 19:53:29 GMT, Alan Bateman wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed SystemModulesClassGenerator.moduleInfos comment
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/S
On Mon, 20 Mar 2023 16:00:40 GMT, Adam Sotona wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since t
On Mon, 20 Mar 2023 16:00:40 GMT, Adam Sotona wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since t
> jdk.jlink internal plugins are heavily using ASM
>
> This patch converts ASM calls to Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixed SystemModulesClassGenerator.moduleInfos
