On Mon, 20 Mar 2023 19:53:29 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed SystemModulesClassGenerator.moduleInfos comment > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > line 1021: > >> 1019: MethodTypeDesc.of(CD_void, >> CD_String)) >> 1020: .astore(BUILDER_VAR) >> 1021: .aload(BUILDER_VAR); > > The methods to generate the MD all load the Builder onto the operand stack so > the aload at L1021 is catching my attention, is that needed? It seems to be redundant as the following code does not expect it on stack and loads it again as needed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12944#discussion_r1143070062
