Re: RFR: 8294982: Implementation of Classfile API [v8]

2023-01-26 Thread Adam Sotona
On Thu, 26 Jan 2023 14:10:47 GMT, Hannes Greule wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> merged JAVAC_FLAGS and EXCLUDES in Java.gmk > > (not a reviewer) From a quick look at it, I noticed two things: > >

Re: RFR: 8294982: Implementation of Classfile API [v8]

2023-01-26 Thread Hannes Greule
On Wed, 25 Jan 2023 13:14:43 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v8]

2023-01-25 Thread Magnus Ihse Bursie
On Wed, 25 Jan 2023 13:14:43 GMT, Adam Sotona wrote: >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >>

Re: RFR: 8294982: Implementation of Classfile API [v8]

2023-01-25 Thread Adam Sotona
> This is root pull request with Classfile API implementation, tests and > benchmarks initial drop into JDK. > > Following pull requests consolidating JDK class files parsing, generating, > and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) > will chain to this one.