Re: RFR: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory [v2]

2024-05-01 Thread Justin Lu
On Wed, 1 May 2024 20:27:19 GMT, Lance Andersen wrote: >> test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 75: >> >>> 73: } catch (InvocationTargetException ex) { >>> 74: Throwable rootEx = ex.getCause(); >>> 75: assertEquals(OutOfMemoryError.class,

Re: RFR: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory [v2]

2024-05-01 Thread Lance Andersen
On Wed, 1 May 2024 20:12:33 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflect review comments > > test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 75: > >> 73: } catch

Re: RFR: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory [v2]

2024-05-01 Thread Naoto Sato
On Wed, 1 May 2024 18:52:06 GMT, Justin Lu wrote: >> Please review this PR which converts _TestEncodingDecodingLength.java_ into >> a whitebox test which allows for testing to be done without memory usage >> issues. >> >> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte

Re: RFR: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory [v2]

2024-05-01 Thread Lance Andersen
On Wed, 1 May 2024 18:52:06 GMT, Justin Lu wrote: >> Please review this PR which converts _TestEncodingDecodingLength.java_ into >> a whitebox test which allows for testing to be done without memory usage >> issues. >> >> Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte

Re: RFR: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory [v2]

2024-05-01 Thread Justin Lu
On Wed, 1 May 2024 16:40:31 GMT, Lance Andersen wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflect review comments > > test/jdk/java/util/Base64/TestEncodingDecodingLength.java line 47: > >> 45: public class

Re: RFR: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory [v2]

2024-05-01 Thread Justin Lu
> Please review this PR which converts _TestEncodingDecodingLength.java_ into a > whitebox test which allows for testing to be done without memory usage issues. > > Currently, the test requires about ~2.75 `Integer.MAX_VALUE` sized byte > arrays worth of memory. (2 for the initial array