Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-14 Thread Naoto Sato
On Wed, 14 Dec 2022 08:46:58 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-14 Thread Alan Bateman
On Tue, 13 Dec 2022 18:29:31 GMT, Naoto Sato wrote: >> `Console` class now has a couple of internal subclasses within `java.io` >> package. It should be `sealed` and subclasses be declared in the `permits` >> clause. The implementation resided in `Console` class is separated into >>

Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-13 Thread Jaikiran Pai
On Tue, 13 Dec 2022 18:42:53 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/io/Console.java line 108: >> >>> 106: public PrintWriter writer() { >>> 107: throw new UnsupportedOperationException( >>> 108: "Console class itself does not provide >>>

Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-13 Thread Jaikiran Pai
On Tue, 13 Dec 2022 18:29:31 GMT, Naoto Sato wrote: >> `Console` class now has a couple of internal subclasses within `java.io` >> package. It should be `sealed` and subclasses be declared in the `permits` >> clause. The implementation resided in `Console` class is separated into >>

Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-13 Thread Naoto Sato
On Tue, 13 Dec 2022 04:36:24 GMT, Jaikiran Pai wrote: >> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits

Re: RFR: 8298416: Console should be declared `sealed` [v2]

2022-12-13 Thread Naoto Sato
> `Console` class now has a couple of internal subclasses within `java.io` > package. It should be `sealed` and subclasses be declared in the `permits` > clause. The implementation resided in `Console` class is separated into > `ConsoleImpl` class. Naoto Sato has updated the pull request with