Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 17:47:45 GMT, Paul Sandoz wrote: > Benchmark looks good. > > I think you need to look at the generated code and perf data to get more > insight into the differences you are observing. > > Sometimes array alignment can add variance to the results (which may not be > the case

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 17:42:16 GMT, Paul Sandoz wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use GT, LT, EQ operations since they seem to outperform GE, LE, NE. > > test/micro/org/openjdk/bench/jdk/incubator/vect

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v8]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 17:48:46 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> te

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Paul Sandoz
On Wed, 1 Mar 2023 14:28:55 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> te

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v8]

2023-03-01 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v7]

2023-03-01 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v6]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 09:10:47 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> te

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v6]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 09:10:47 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> te

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v6]

2023-03-01 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v4]

2023-03-01 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 06:34:20 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> te

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v5]

2023-03-01 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 23:55:52 GMT, Paul Sandoz wrote: >> Eirik Bjorsnos has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Uppercase Thorn is 0xDE >> - Update 'a' to 'A' and 'z' to 'Z' in comments > > test/micro/org/openjdk/bench/jdk/incu

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v4]

2023-02-28 Thread Eirik Bjorsnos
On Wed, 1 Mar 2023 02:32:23 GMT, Xiaohong Gong wrote: >> Eirik Bjorsnos has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Adjust whitespace as suggested in review >> - Replace Blackhold.consume with return values > > test/micro/org/open

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v4]

2023-02-28 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Xiaohong Gong
On Tue, 28 Feb 2023 23:08:29 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> t

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Paul Sandoz
On Tue, 28 Feb 2023 23:08:29 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> t

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Sandhya Viswanathan
On Tue, 28 Feb 2023 23:08:29 GMT, Eirik Bjorsnos wrote: >> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set >> of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark >> serves as an example of how vectorization can be useful also in the area of >> t

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

2023-02-28 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 23:11:35 GMT, Sandhya Viswanathan wrote: >> Eirik Bjorsnos has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Uppercase Thorn is 0xDE >> - Update 'a' to 'A' and 'z' to 'Z' in comments > > Looks good to me. Thanks, @

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v2]

2023-02-28 Thread Eirik Bjorsnos
On Tue, 28 Feb 2023 22:19:46 GMT, Sandhya Viswanathan wrote: >> Eirik Bjorsnos has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use GE, LE, NE operations instead of the lt,not combinations. Use >> uppercase in vectorized code to match t

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v2]

2023-02-28 Thread Eirik Bjorsnos
> This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text > processing. It takes advantage of the fact that ASCII and

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-02-28 Thread Sandhya Viswanathan
On Tue, 28 Feb 2023 15:59:26 GMT, Eirik Bjorsnos wrote: > This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text >

Re: RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-02-28 Thread Eric Caspole
On Tue, 28 Feb 2023 15:59:26 GMT, Eirik Bjorsnos wrote: > This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of > benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves > as an example of how vectorization can be useful also in the area of text >

RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark

2023-02-28 Thread Eirik Bjorsnos
This PR suggests we add a vectorized equalsIgnoreCase benchmark to the set of benchmarks in `org.openjdk.bench.jdk.incubator.vector`. This benchmark serves as an example of how vectorization can be useful also in the area of text processing. It takes advantage of the fact that ASCII and Latin-1