> CorruptedZipFiles could benefit from some spring cleaning and a conversion to
> testNG:
>
> - The actual tests are moved into their own `@Test` methods, given more
> meaningful names and a Javadoc comment explaining the constraint being
> verified
> - The setup code is moved to a `@Before` me
On Wed, 29 Mar 2023 12:19:18 GMT, Eirik Bjorsnos wrote:
>> CorruptedZipFiles could benefit from some spring cleaning and a conversion
>> to testNG:
>>
>> - The actual tests are moved into their own `@Test` methods, given more
>> meaningful names and a Javadoc comment explaining the constraint
On Wed, 29 Mar 2023 13:23:19 GMT, Daniel Fuchs wrote:
> High level comment: these days we usually try to use junit 5 / jupiter
> instead of TestNG.
I think my choice of testNG here might have been influenced by other ZIP area
tests using testNG. I guess a rewrite to junit should be pretty stra
On Mon, 27 Feb 2023 21:13:47 GMT, Lance Andersen wrote:
>> Eirik Bjorsnos has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> comm
On Wed, 29 Mar 2023 13:30:21 GMT, Eirik Bjorsnos wrote:
> > High level comment: these days we usually try to use junit 5 / jupiter
> > instead of TestNG.
>
> I think my choice of testNG here might have been influenced by other ZIP area
> tests using testNG. I guess a rewrite to junit should be
On Wed, 29 Mar 2023 15:21:04 GMT, Lance Andersen wrote:
>>> High level comment: these days we usually try to use junit 5 / jupiter
>>> instead of TestNG.
>>
>> I think my choice of testNG here might have been influenced by other ZIP
>> area tests using testNG. I guess a rewrite to junit should
