Re: RFR: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved [v2]

2023-03-21 Thread Adam Sotona
On Tue, 21 Mar 2023 09:45:56 GMT, Jaikiran Pai wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> src/java.base/share/classes/jdk/internal/classfile/impl/ClassHierarchyImpl.java >> >> Co-authored-by: li

Re: RFR: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved [v3]

2023-03-21 Thread Jaikiran Pai
On Tue, 21 Mar 2023 10:40:35 GMT, Adam Sotona wrote: >> Classfile API class hierarchy makes assumptions when class is not resolved >> and that may lead to silent generation of invalid stack maps. Only >> debug-level log information of case is actually provided. >> >> Proposed patch throws Ille

Re: RFR: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved [v3]

2023-03-21 Thread Adam Sotona
> Classfile API class hierarchy makes assumptions when class is not resolved > and that may lead to silent generation of invalid stack maps. Only > debug-level log information of case is actually provided. > > Proposed patch throws IllegalArgumentException when the class is not resolved > inste

Re: RFR: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved [v2]

2023-03-21 Thread Jaikiran Pai
On Mon, 20 Mar 2023 14:06:43 GMT, Adam Sotona wrote: >> Classfile API class hierarchy makes assumptions when class is not resolved >> and that may lead to silent generation of invalid stack maps. Only >> debug-level log information of case is actually provided. >> >> Proposed patch throws Ille

Re: RFR: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved [v2]

2023-03-20 Thread Chen Liang
On Mon, 20 Mar 2023 14:02:13 GMT, Adam Sotona wrote: >> Classfile API class hierarchy makes assumptions when class is not resolved >> and that may lead to silent generation of invalid stack maps. Only >> debug-level log information of case is actually provided. >> >> Proposed patch throws Ille

Re: RFR: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved [v2]

2023-03-20 Thread Adam Sotona
> Classfile API class hierarchy makes assumptions when class is not resolved > and that may lead to silent generation of invalid stack maps. Only > debug-level log information of case is actually provided. > > Proposed patch throws IllegalArgumentException when the class is not resolved > inste

RFR: 8304502: Classfile API class hierarchy makes assumptions when class is not resolved

2023-03-20 Thread Adam Sotona
Classfile API class hierarchy makes assumptions when class is not resolved and that may lead to silent generation of invalid stack maps. Only debug-level log information of case is actually provided. Proposed patch throws IllegalArgumentException when the class is not resolved instead. Thanks