Re: RFR: 8306455: Wrong majorVersion for multiple attributes in Classfile API

2023-05-09 Thread Chen Liang
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote: > Spotted the typo for BootstrapMethods, and another review over the API > exposed the typo on PermittedSubclasses. Withdrawing this patch in favor of removing `validSince` completely in another patch. - PR Comment:

Re: RFR: 8306455: Wrong majorVersion for multiple attributes in Classfile API

2023-05-02 Thread Chen Liang
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote: > Spotted the typo for BootstrapMethods, and another review over the API > exposed the typo on PermittedSubclasses. Agree; we should remove this validsince. I change PermittedSubclasses for Record uses its release major version than its

Re: RFR: 8306455: Wrong majorVersion for multiple attributes in Classfile API

2023-05-02 Thread Adam Sotona
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote: > Spotted the typo for BootstrapMethods, and another review over the API > exposed the typo on PermittedSubclasses. BootstrapMethods is a good catch, however I would rather recommend to remove the `AttributeMapper::validSince` from the API

Re: RFR: 8306455: Wrong majorVersion for multiple attributes in Classfile API

2023-05-01 Thread Chen Liang
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote: > Spotted the typo for BootstrapMethods, and another review over the API > exposed the typo on PermittedSubclasses. @asotona Would you mind reviewing this? - PR Comment:

RFR: 8306455: Wrong majorVersion for multiple attributes in Classfile API

2023-04-19 Thread Chen Liang
Spotted the typo for BootstrapMethods, and another review over the API exposed the typo on PermittedSubclasses. - Commit messages: - 8306455: Wrong majorVersion for multiple attributes in Classfile API Changes: https://git.openjdk.org/jdk/pull/13536/files Webrev: