Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v10]

2023-04-26 Thread Mandy Chung
On Wed, 26 Apr 2023 06:18:10 GMT, Per Minborg wrote: > Have we considered moving the Impl classes into a non-public area such as > `jdk.internal` to improve encapsulation and reduce perceived footprint? I don't see much of a problem to keep the non-public classes in `java.lang.constant` since

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v10]

2023-04-26 Thread Adam Sotona
On Tue, 25 Apr 2023 21:53:44 GMT, Mandy Chung wrote: > I wonder if `packageName()` and `packageInternalName()` methods can simply be > `name()` and `internalName()` as the type name is `PackageDesc` and `package` > prefix seems to be unnecessary. Similarly, `moduleName()` can be `name()`. > Ha

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v10]

2023-04-26 Thread Adam Sotona
On Tue, 25 Apr 2023 21:45:57 GMT, Mandy Chung wrote: >> Adam Sotona has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update ModuleDesc.java >> - Update PackageDesc.java > > src/java.base/share/classes/java/lang/constant/ModuleDesc.java

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v10]

2023-04-25 Thread Per Minborg
On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona wrote: >> Constants API already provides models for all loadable constants to help >> programs manipulating class files and modelling bytecode instructions. >> However no models of module and package constants are provided by Constants >> API. Ever

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v10]

2023-04-25 Thread Mandy Chung
On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona wrote: >> Constants API already provides models for all loadable constants to help >> programs manipulating class files and modelling bytecode instructions. >> However no models of module and package constants are provided by Constants >> API. Ever

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v10]

2023-04-25 Thread Adam Sotona
> Constants API already provides models for all loadable constants to help > programs manipulating class files and modelling bytecode instructions. > However no models of module and package constants are provided by Constants > API. Every program manipulating class files must implement own model