Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v13]

2023-04-27 Thread Adam Sotona
On Wed, 26 Apr 2023 18:15:34 GMT, Alan Bateman wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed prefixes from name methods > > src/java.base/share/classes/java/lang/constant/ConstantUtils.java line 133: >

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v13]

2023-04-26 Thread Mandy Chung
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote: >> Constants API already provides models for all loadable constants to help >> programs manipulating class files and modelling bytecode instructions. >> However no models of module and package constants are provided by Constants >> API.

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v13]

2023-04-26 Thread Alan Bateman
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote: >> Constants API already provides models for all loadable constants to help >> programs manipulating class files and modelling bytecode instructions. >> However no models of module and package constants are provided by Constants >> API.

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v13]

2023-04-26 Thread Mandy Chung
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote: >> Constants API already provides models for all loadable constants to help >> programs manipulating class files and modelling bytecode instructions. >> However no models of module and package constants are provided by Constants >> API.

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v13]

2023-04-26 Thread Adam Sotona
> Constants API already provides models for all loadable constants to help > programs manipulating class files and modelling bytecode instructions. > However no models of module and package constants are provided by Constants > API. Every program manipulating class files must implement own