On Wed, 26 Apr 2023 18:15:34 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed prefixes from name methods
>
> src/java.base/share/classes/java/lang/constant/ConstantUtils.java line 133:
>
>> 131: if ((ch >= '\u0000' && ch <= '\u001F')
>> 132: || ((ch == '\\' || ch == ':' || ch =='@') && (i == 0 ||
>> name.charAt(--i) != '\\')))
>> 133: throw new IllegalArgumentException("Invalid module
>> name: " + name);
>
> test/jdk/java/lang/module/ModuleNames.java has tables of legal and illegal
> module names, including tests that escape backslash, @, and :. It might be
> useful to run these tests on this method.
I've updated `ModuleDescTest` with all the positive and negative cases from
`test/jdk/java/lang/module/ModuleNames.java`, except for the empty name.
Thanks for the review.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13615#discussion_r1178736304
