Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v4]

2023-04-25 Thread Adam Sotona
On Tue, 25 Apr 2023 16:26:01 GMT, Mandy Chung wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> added custom toString() methods > > src/java.base/share/classes/java/lang/constant/PackageDesc.java line 44: > >> 42:

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v4]

2023-04-25 Thread Mandy Chung
On Tue, 25 Apr 2023 08:11:24 GMT, Adam Sotona wrote: >> Constants API already provides models for all loadable constants to help >> programs manipulating class files and modelling bytecode instructions. >> However no models of module and package constants are provided by Constants >> API. Ever

Re: RFR: 8306729: Add nominal descriptors of modules and packages to Constants API [v4]

2023-04-25 Thread Adam Sotona
> Constants API already provides models for all loadable constants to help > programs manipulating class files and modelling bytecode instructions. > However no models of module and package constants are provided by Constants > API. Every program manipulating class files must implement own model