Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Alan Bateman
On Mon, 22 May 2023 10:30:27 GMT, Jaikiran Pai wrote: >> I don't mind moving this but it would require changing them everywhere (as >> you point out). > > I think it's fine to leave it in the current form then. If/when any of these > tests fail due to unexpected exception type in these

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Daniel Fuchs
On Mon, 22 May 2023 10:09:27 GMT, Alan Bateman wrote: >> test/jdk/java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java >> line 578: >> >>> 576: try { >>> 577: >>> scheduleInterruptAt("java.util.concurrent.ThreadPerTaskExecutor.invokeAny"); >>>

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Daniel Fuchs
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote: > This is a test only change to the unit test for the ExecutorService returned > by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll > assume the threads started to execute the tasks do actually execute the task >

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Jaikiran Pai
On Mon, 22 May 2023 10:11:25 GMT, Alan Bateman wrote: >> test/jdk/java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java >> line 269: >> >>> 267: assertTrue(executor.awaitTermination(10, >>> TimeUnit.MILLISECONDS)); >>> 268: Throwable e =

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Jaikiran Pai
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote: > This is a test only change to the unit test for the ExecutorService returned > by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll > assume the threads started to execute the tasks do actually execute the task >

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Alan Bateman
On Mon, 22 May 2023 09:48:15 GMT, Daniel Fuchs wrote: > Seems strange to test invokeAny when there is only one task? There are several tests further up that exercise invokeAny with more than one task. This one is testing interrupt of invokeAny, we could expect it to test interrupting with

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Alan Bateman
On Mon, 22 May 2023 10:05:49 GMT, Jaikiran Pai wrote: >> This is a test only change to the unit test for the ExecutorService returned >> by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll >> assume the threads started to execute the tasks do actually execute the task

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Jaikiran Pai
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote: > This is a test only change to the unit test for the ExecutorService returned > by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll > assume the threads started to execute the tasks do actually execute the task >

Re: RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Daniel Fuchs
On Sun, 21 May 2023 13:52:06 GMT, Alan Bateman wrote: > This is a test only change to the unit test for the ExecutorService returned > by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll > assume the threads started to execute the tasks do actually execute the task >

RFR: 8308038: java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java timed out

2023-05-22 Thread Alan Bateman
This is a test only change to the unit test for the ExecutorService returned by Executors.newThreadPerTaskExecutor. The tests for interrupting invokeAll assume the threads started to execute the tasks do actually execute the task code. The refresh in JEP 444 changed the implementation to use