On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
> arr
On Fri, 19 May 2023 13:03:34 GMT, Adam Sotona wrote:
> Tier1 tests just passed on all platforms.
Okay, in that case we should get the change in because there is build breakage
right now.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14060#discussion_r1198940202
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
> arr
On Fri, 19 May 2023 12:35:47 GMT, Alan Bateman wrote:
>> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
>> compilation on windows.
>> Unfortunately MSVC does not support variable length arrays.
>> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
On Fri, 19 May 2023 13:01:37 GMT, Adam Sotona wrote:
>> test/jdk/tools/launcher/exeJliLaunchTest.c line 39:
>>
>>> 37: {
>>> 38: //avoid null-terminated array of arguments to test JDK-8303669
>>> 39: char **argv = malloc(sizeof(char *) * argc);
>>
>> If this is building on all platforms
On Fri, 19 May 2023 12:08:55 GMT, Adam Sotona wrote:
> JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
> compilation on windows.
> Unfortunately MSVC does not support variable length arrays.
> This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
> arr
JDK-8303669 patch to test\jdk\tools\launcher\exeJliLaunchTest.c broke
compilation on windows.
Unfortunately MSVC does not support variable length arrays.
This patch fixes test\jdk\tools\launcher\exeJliLaunchTest.c to use dynamic
array allocation.
Please review.
Thanks,
Adam
-
Comm
