Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API [v5]

2023-06-05 Thread Adam Sotona
> Class-File API actually throws wide variety of exceptions based on the actual > situation. Complete error handling code must cover > `IndexOutOfBoundsException`, `IllegalStateException` and > `IllegalArgumentException`. > > Based on previous discussions we decided to consolidate on > `Illeg

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API [v4]

2023-06-05 Thread Adam Sotona
> Class-File API actually throws wide variety of exceptions based on the actual > situation. Complete error handling code must cover > `IndexOutOfBoundsException`, `IllegalStateException` and > `IllegalArgumentException`. > > Based on previous discussions we decided to consolidate on > `Illeg

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API [v3]

2023-06-05 Thread Adam Sotona
On Mon, 5 Jun 2023 15:03:01 GMT, Brian Goetz wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits s

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API [v3]

2023-06-05 Thread Brian Goetz
On Mon, 5 Jun 2023 14:38:47 GMT, Adam Sotona wrote: >> Class-File API actually throws wide variety of exceptions based on the >> actual situation. Complete error handling code must cover >> `IndexOutOfBoundsException`, `IllegalStateException` and >> `IllegalArgumentException`. >> >> Based on

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API [v3]

2023-06-05 Thread Adam Sotona
> Class-File API actually throws wide variety of exceptions based on the actual > situation. Complete error handling code must cover > `IndexOutOfBoundsException`, `IllegalStateException` and > `IllegalArgumentException`. > > Based on previous discussions we decided to consolidate on > `Illeg

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API [v2]

2023-05-26 Thread Adam Sotona
On Thu, 25 May 2023 22:45:01 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc > > src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 389: > >> 387: // Check

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API [v2]

2023-05-26 Thread Adam Sotona
> Class-File API actually throws wide variety of exceptions based on the actual > situation. Complete error handling code must cover > `IndexOutOfBoundsException`, `IllegalStateException` and > `IllegalArgumentException`. > > Based on previous discussions we decided to consolidate on > `Illeg

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API

2023-05-25 Thread ExE Boss
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote: > Class-File API actually throws wide variety of exceptions based on the actual > situation. Complete error handling code must cover > `IndexOutOfBoundsException`, `IllegalStateException` and > `IllegalArgumentException`. > > Based on prev

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API

2023-05-25 Thread Chen Liang
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote: > Class-File API actually throws wide variety of exceptions based on the actual > situation. Complete error handling code must cover > `IndexOutOfBoundsException`, `IllegalStateException` and > `IllegalArgumentException`. > > Based on prev

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API

2023-05-25 Thread Adam Sotona
On Thu, 25 May 2023 09:12:58 GMT, Chen Liang wrote: > What other types of exceptions does javap distinguish, and should Classfile > API distinguish them as well? Invalid CP index or content are cases where javap tries to recover, replace the value with '???' and print the rest. This PR is extr

Re: RFR: 8308842: Consolidate exceptions thrown from Class-File API

2023-05-25 Thread Chen Liang
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote: > Class-File API actually throws wide variety of exceptions based on the actual > situation. Complete error handling code must cover > `IndexOutOfBoundsException`, `IllegalStateException` and > `IllegalArgumentException`. > > Based on prev

RFR: 8308842: Consolidate exceptions thrown from Class-File API

2023-05-25 Thread Adam Sotona
Class-File API actually throws wide variety of exceptions based on the actual situation. Complete error handling code must cover `IndexOutOfBoundsException`, `IllegalStateException` and `IllegalArgumentException`. Based on previous discussions we decided to consolidate on `IllegalArgumentExcep