Re: RFR: 8308899: Introduce Classfile context and improve Classfile options [v25]

2023-06-26 Thread Maurizio Cimadamore
On Mon, 26 Jun 2023 15:39:15 GMT, Maurizio Cimadamore wrote: > The API changes look great. I like the instance usages of ClassFile, and how > CF is now used in a centralized fashion to double down as a cache/option > store (and entry point for transformation). Seems like a step in a good > di

Re: RFR: 8308899: Introduce Classfile context and improve Classfile options [v25]

2023-06-26 Thread Maurizio Cimadamore
On Mon, 26 Jun 2023 13:33:38 GMT, Adam Sotona wrote: >> Classfile context object and multi-state options have been discussed at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html >> This patch implements the proposed changes in Classfile API and fixes all >> affected c

Re: RFR: 8308899: Introduce Classfile context and improve Classfile options [v25]

2023-06-26 Thread Chen Liang
On Mon, 26 Jun 2023 15:40:39 GMT, Maurizio Cimadamore wrote: > Also, another observation: the number of updates snippets in javadoc seems > rather low for something that touches the main entry point by which client > interacts with classfiles. This seems a sign of perhaps not having many end

Re: RFR: 8308899: Introduce Classfile context and improve Classfile options [v25]

2023-06-26 Thread Adam Sotona
On Mon, 26 Jun 2023 15:40:39 GMT, Maurizio Cimadamore wrote: >> The API changes look great. I like the instance usages of ClassFile, and how >> CF is now used in a centralized fashion to double down as a cache/option >> store (and entry point for transformation). Seems like a step in a good >

Re: RFR: 8308899: Introduce Classfile context and improve Classfile options [v25]

2023-06-26 Thread Adam Sotona
On Mon, 26 Jun 2023 14:56:34 GMT, Chen Liang wrote: > I ran `make docs-classfile-api-javadoc` Thanks for pointing this out. The makefile patches accidentally fell into this PR. > One thing of note is that the JDK itself has a `@sealedGraph` taglet to > render the sealed class hierarchy of an