Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-21 Thread Chen Liang
On Wed, 21 Jun 2023 09:54:53 GMT, Alan Bateman wrote: >> Binary name is a long-standing behavior. It's a spec bug. > >> Binary name is a long-standing behavior. It's a spec bug. > > Yes, I view this PR as just specifying long standing behavior. The name used > for array class may be

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-21 Thread Alan Bateman
On Tue, 20 Jun 2023 17:45:03 GMT, Mandy Chung wrote: > Binary name is a long-standing behavior. It's a spec bug. Yes, I view this PR as just specifying long standing behavior. The name used for array class may be surprising but I don't think it can be changed. - PR Review

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-20 Thread Mandy Chung
On Mon, 19 Jun 2023 01:34:59 GMT, David Holmes wrote: >> src/java.base/share/classes/java/lang/Class.java line 395: >> >>> 393: * attached thread), the system class loader is used. >>> 394: * >>> 395: * @param className the binary name >>> of the class >> >> Where do these

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-20 Thread Mandy Chung
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote: >> This PR clarifies the spec of the 3-arg Class::forName regarding the format >> of the name for an array type which is of the form: one or more of "[" + >> binary name of the element type + ";'. > > Mandy Chung has updated the pull

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-19 Thread Chen Liang
On Sat, 17 Jun 2023 13:56:15 GMT, Alan Bateman wrote: > This changes look okay but they do make me wonder if we should add a note to > the 2-arg Class.forName to make it clear that it does not allow class names > for array types, the class name has to be a binary name. In its specification:

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread David Holmes
On Sun, 18 Jun 2023 18:54:22 GMT, Jens Lidestrom wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> missing 'L' for the array class name > > src/java.base/share/classes/java/lang/Class.java line 395: > >> 393: *

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread Chen Liang
On Sun, 18 Jun 2023 18:36:28 GMT, Jens Lidestrom wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> missing 'L' for the array class name > > src/java.base/share/classes/java/lang/Class.java line 395: > >> 393: *

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread ExE Boss
On Sun, 18 Jun 2023 18:56:39 GMT, Jens Lidestrom wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> missing 'L' for the array class name > > src/java.base/share/classes/java/lang/Class.java line 427: > >> 425: *

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread Jens Lidestrom
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote: >> This PR clarifies the spec of the 3-arg Class::forName regarding the format >> of the name for an array type which is of the form: one or more of "[" + >> binary name of the element type + ";'. > > Mandy Chung has updated the pull

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-18 Thread Jens Lidestrom
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote: >> This PR clarifies the spec of the 3-arg Class::forName regarding the format >> of the name for an array type which is of the form: one or more of "[" + >> binary name of the element type + ";'. > > Mandy Chung has updated the pull

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-17 Thread Alan Bateman
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote: >> This PR clarifies the spec of the 3-arg Class::forName regarding the format >> of the name for an array type which is of the form: one or more of "[" + >> binary name of the element type + ";'. > > Mandy Chung has updated the pull

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-16 Thread Mandy Chung
> This PR clarifies the spec of the 3-arg Class::forName regarding the format > of the name for an array type which is of the form: one or more of "[" + > binary name of the element type + ";'. Mandy Chung has updated the pull request incrementally with one additional commit since the last