Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Stuart Marks
On Fri, 4 Aug 2023 07:11:58 GMT, dan1st wrote: >> Thanks for the updates. I've drafted a CSR; see link in header. Please take >> a look. > >> Thanks for the updates. I've drafted a CSR; see link in header. Please take >> a look. > > @stuart-marks Thanks, the CSR looks good to me. I guess the

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Brian Burkhalter
On Fri, 4 Aug 2023 15:36:05 GMT, dan1st wrote: >> src/java.base/share/classes/java/util/ArrayList.java line 46: >> >>> 44: * {@code listIterator}, and {@code reversed} operations run in >>> constant time. >>> 45: * The {@code add}, and {@code addLast} operations runs in amortized >>> 46: *

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Brian Burkhalter
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread dan1st
On Fri, 4 Aug 2023 15:31:59 GMT, Brian Burkhalter wrote: >> dan1st has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8311517: ArrayList Javadoc of getFirst/getLast/removeLast >> >> as requested by >>

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Brian Burkhalter
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread Raffaello Giulietti
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread dan1st
On Fri, 4 Aug 2023 03:08:26 GMT, Stuart Marks wrote: > Thanks for the updates. I've drafted a CSR; see link in header. Please take a > look. @stuart-marks Thanks, the CSR looks good to me. I guess the `Fix versions` field will be added when the CSR is reviewed? - PR Comment:

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-03 Thread Stuart Marks
On Thu, 27 Jul 2023 06:31:06 GMT, dan1st wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterator

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-07-27 Thread dan1st
> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, and listIterator operations run in > constant time. The add operation