Re: [External] : Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

> On Aug 11, 2023, at 3:55 PM, Alexander Matveev > wrote: > > Hi Michael, > >> On Aug 10, 2023, at 10:48 PM, Michael Hall > > wrote: >> >> I assume done with jpackage by indicating something like —mac-sign only? If wrong feel free to correct. >>>

Re: [External] : Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

Hi Michael, On Aug 10, 2023, at 10:48 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: I assume done with jpackage by indicating something like —mac-sign only? If wrong feel free to correct. No, it is always done if —mac-sign is NOT specified and we doing ad-hoc signing on app bundle

Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

On Thu, 10 Aug 2023 22:58:18 GMT, Alexander Matveev wrote: > - This is regression from > [JDK-8298488](https://bugs.openjdk.org/browse/JDK-8298488). > - Since JDK-8298488 unsigned app bundles are ad-hoc signed and `codesign` > will report that app bundle is signed and thus our tests failed. >

Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

>> >> I assume done with jpackage by indicating something like —mac-sign only? If >> wrong feel free to correct. > > No, it is always done if —mac-sign is NOT specified and we doing ad-hoc > signing on app bundle only. PKG will not be ad-hoc signed. > If —mac-sign is provided we will use

Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

Hi Michael, On Aug 10, 2023, at 6:11 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: On Aug 10, 2023, at 6:35 PM, Michael Hall mailto:mik3h...@gmail.com>> wrote: On Aug 10, 2023, at 6:21 PM, Alexander Matveev mailto:almat...@openjdk.org>> wrote: - Fixed tests by checking that all

Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

> On Aug 10, 2023, at 6:35 PM, Michael Hall wrote: > > > >> On Aug 10, 2023, at 6:21 PM, Alexander Matveev wrote: >> >> - Fixed tests by checking that all app bundles are signed and by checking >> how they signed ad-hoc vs actual certificate. > > How is ad-hoc signing done? > > If

Re: RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

> On Aug 10, 2023, at 6:21 PM, Alexander Matveev wrote: > > - Fixed tests by checking that all app bundles are signed and by checking how > they signed ad-hoc vs actual certificate. How is ad-hoc signing done?

RFR: 8313904: [macos] All signing tests which verifies unsigned app images are failing

- This is regression from [JDK-8298488](https://bugs.openjdk.org/browse/JDK-8298488). - Since JDK-8298488 unsigned app bundles are ad-hoc signed and `codesign` will report that app bundle is signed and thus our tests failed. - Fixed tests by checking that all app bundles are signed and by