RFR: 8314483: Optionally override copyright header in generated source

2023-08-18 Thread Erik Joelsson
In the JDK build we have various build tools that generate source code from data files. For most of these tools, the source files are based on template files, which already have copyright headers, but for some, the complete source file is generated by the tool, which is providing the copyright h

Re: RFR: 8314483: Optionally override copyright header in generated source

2023-08-23 Thread David Holmes
On Fri, 18 Aug 2023 14:22:49 GMT, Erik Joelsson wrote: > In the JDK build we have various build tools that generate source code from > data files. For most of these tools, the source files are based on template > files, which already have copyright headers, but for some, the complete > source

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-24 Thread Erik Joelsson
> In the JDK build we have various build tools that generate source code from > data files. For most of these tools, the source files are based on template > files, which already have copyright headers, but for some, the complete > source file is generated by the tool, which is providing the cop

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-24 Thread Erik Joelsson
On Thu, 24 Aug 2023 04:46:31 GMT, David Holmes wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Suggestion from dholmes > > make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java > line 62:

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-24 Thread Iris Clark
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote: >> In the JDK build we have various build tools that generate source code from >> data files. For most of these tools, the source files are based on template >> files, which already have copyright headers, but for some, the complete >> sou

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-24 Thread David Holmes
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote: >> In the JDK build we have various build tools that generate source code from >> data files. For most of these tools, the source files are based on template >> files, which already have copyright headers, but for some, the complete >> sou

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-24 Thread Andrey Turbanov
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote: >> In the JDK build we have various build tools that generate source code from >> data files. For most of these tools, the source files are based on template >> files, which already have copyright headers, but for some, the complete >> sou

Re: RFR: 8314483: Optionally override copyright header in generated source [v2]

2023-08-25 Thread Erik Joelsson
On Fri, 25 Aug 2023 06:45:25 GMT, Andrey Turbanov wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Suggestion from dholmes > > make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 236: > >> 234:

Re: RFR: 8314483: Optionally override copyright header in generated source [v3]

2023-08-25 Thread Erik Joelsson
> In the JDK build we have various build tools that generate source code from > data files. For most of these tools, the source files are based on template > files, which already have copyright headers, but for some, the complete > source file is generated by the tool, which is providing the cop